Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1033,
    "url": "http://patchwork.ozlabs.org/api/patches/1033/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.013406.65754438.davem@davemloft.net/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080923.013406.65754438.davem@davemloft.net>",
    "list_archive_url": null,
    "date": "2008-09-23T08:34:06",
    "name": ": tcp: Fix order of tests in tcp_retransmit_skb()",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f68f448356191081382e7e06e52cc0cc8fd09719",
    "submitter": {
        "id": 15,
        "url": "http://patchwork.ozlabs.org/api/people/15/?format=api",
        "name": "David Miller",
        "email": "davem@davemloft.net"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.013406.65754438.davem@davemloft.net/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1033/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1033/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id F3690DDE0A\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 18:34:38 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752425AbYIWIeU (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 04:34:20 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1754443AbYIWIeU\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 04:34:20 -0400",
            "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:55360\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1754390AbYIWIeS (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 23 Sep 2008 04:34:18 -0400",
            "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 06B1DC8C181\n\tfor <netdev@vger.kernel.org>; Tue, 23 Sep 2008 01:34:06 -0700 (PDT)"
        ],
        "Date": "Tue, 23 Sep 2008 01:34:06 -0700 (PDT)",
        "Message-Id": "<20080923.013406.65754438.davem@davemloft.net>",
        "To": "netdev@vger.kernel.org",
        "Subject": "[PATCH]: tcp: Fix order of tests in tcp_retransmit_skb()",
        "From": "David Miller <davem@davemloft.net>",
        "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)",
        "Mime-Version": "1.0",
        "Content-Type": "Text/Plain; charset=us-ascii",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "The assertion I placed in skb_queue_next() found a bug already,\nbut this specific case turned out to be harmless :-)\n\ntcp: Fix order of tests in tcp_retransmit_skb()\n\ntcp_write_queue_next() must only be made if we know that\ntcp_skb_is_last() evaluates to false.\n\nSigned-off-by: David S. Miller <davem@davemloft.net>\n---\n net/ipv4/tcp_output.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)",
    "diff": "diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c\nindex c3d58ee..a8499ef 100644\n--- a/net/ipv4/tcp_output.c\n+++ b/net/ipv4/tcp_output.c\n@@ -1932,8 +1932,8 @@ int tcp_retransmit_skb(struct sock *sk, struct sk_buff *skb)\n \t/* Collapse two adjacent packets if worthwhile and we can. */\n \tif (!(TCP_SKB_CB(skb)->flags & TCPCB_FLAG_SYN) &&\n \t    (skb->len < (cur_mss >> 1)) &&\n-\t    (tcp_write_queue_next(sk, skb) != tcp_send_head(sk)) &&\n \t    (!tcp_skb_is_last(sk, skb)) &&\n+\t    (tcp_write_queue_next(sk, skb) != tcp_send_head(sk)) &&\n \t    (skb_shinfo(skb)->nr_frags == 0 &&\n \t     skb_shinfo(tcp_write_queue_next(sk, skb))->nr_frags == 0) &&\n \t    (tcp_skb_pcount(skb) == 1 &&\n",
    "prefixes": []
}