Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1032843,
    "url": "http://patchwork.ozlabs.org/api/patches/1032843/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20190129150143.12681-5-mika.westerberg@linux.intel.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20190129150143.12681-5-mika.westerberg@linux.intel.com>",
    "list_archive_url": null,
    "date": "2019-01-29T15:01:19",
    "name": "[04/28] thunderbolt: Add dummy read after port capability list walk on Light Ridge",
    "commit_ref": null,
    "pull_url": null,
    "state": "not-applicable",
    "archived": false,
    "hash": "384c1bfcad0a3455acb3ffd82c7a9ad2d031ac53",
    "submitter": {
        "id": 14534,
        "url": "http://patchwork.ozlabs.org/api/people/14534/?format=api",
        "name": "Mika Westerberg",
        "email": "mika.westerberg@linux.intel.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20190129150143.12681-5-mika.westerberg@linux.intel.com/mbox/",
    "series": [
        {
            "id": 88859,
            "url": "http://patchwork.ozlabs.org/api/series/88859/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=88859",
            "date": "2019-01-29T15:01:18",
            "name": "thunderbolt: Software connection manager improvements",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/88859/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/1032843/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1032843/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming-netdev@ozlabs.org",
        "Delivered-To": "patchwork-incoming-netdev@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.intel.com"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 43pqZk4D72z9sML\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tWed, 30 Jan 2019 02:06:22 +1100 (AEDT)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727697AbfA2PBs (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tTue, 29 Jan 2019 10:01:48 -0500",
            "from mga12.intel.com ([192.55.52.136]:8099 \"EHLO mga12.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1725811AbfA2PBr (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 29 Jan 2019 10:01:47 -0500",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jan 2019 07:01:47 -0800",
            "from black.fi.intel.com ([10.237.72.28])\n\tby fmsmga006.fm.intel.com with ESMTP; 29 Jan 2019 07:01:45 -0800",
            "by black.fi.intel.com (Postfix, from userid 1001)\n\tid 525DF377; Tue, 29 Jan 2019 17:01:44 +0200 (EET)"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.56,537,1539673200\"; d=\"scan'208\";a=\"314531707\"",
        "From": "Mika Westerberg <mika.westerberg@linux.intel.com>",
        "To": "linux-kernel@vger.kernel.org",
        "Cc": "Michael Jamet <michael.jamet@intel.com>,\n\tYehezkel Bernat <YehezkelShB@gmail.com>,\n\tAndreas Noever <andreas.noever@gmail.com>,\n\tLukas Wunner <lukas@wunner.de>, \"David S . Miller\" <davem@davemloft.net>,\n\tMika Westerberg <mika.westerberg@linux.intel.com>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>,\n\tnetdev@vger.kernel.org",
        "Subject": "[PATCH 04/28] thunderbolt: Add dummy read after port capability\n\tlist walk on Light Ridge",
        "Date": "Tue, 29 Jan 2019 18:01:19 +0300",
        "Message-Id": "<20190129150143.12681-5-mika.westerberg@linux.intel.com>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190129150143.12681-1-mika.westerberg@linux.intel.com>",
        "References": "<20190129150143.12681-1-mika.westerberg@linux.intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Light Ridge has an issue where reading the next capability pointer\nlocation in port config space the read data is not cleared. It is fine\nto read capabilities each after another so only thing we need to do is\nto make sure we issue dummy read after tb_port_find_cap() is finished to\navoid the issue in next read.\n\nSigned-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>\n---\n drivers/thunderbolt/cap.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)",
    "diff": "diff --git a/drivers/thunderbolt/cap.c b/drivers/thunderbolt/cap.c\nindex 94a507f12b71..b7a3b62805a6 100644\n--- a/drivers/thunderbolt/cap.c\n+++ b/drivers/thunderbolt/cap.c\n@@ -56,6 +56,21 @@ static int tb_port_enable_tmu(struct tb_port *port, bool enable)\n \treturn tb_sw_write(sw, &value, TB_CFG_SWITCH, offset, 1);\n }\n \n+static void tb_port_dummy_read(struct tb_port *port)\n+{\n+\t/*\n+\t * When reading from next capability pointer location in port\n+\t * config space the read data is not cleared on LR. To avoid\n+\t * reading stale data on next read perform one dummy read after\n+\t * port capabilities are walked.\n+\t */\n+\tif (port->sw->config.device_id == PCI_DEVICE_ID_INTEL_LIGHT_RIDGE) {\n+\t\tu32 dummy;\n+\n+\t\ttb_port_read(port, &dummy, TB_CFG_PORT, 0, 1);\n+\t}\n+}\n+\n static int __tb_port_find_cap(struct tb_port *port, enum tb_port_cap cap)\n {\n \tu32 offset = 1;\n@@ -96,6 +111,7 @@ int tb_port_find_cap(struct tb_port *port, enum tb_port_cap cap)\n \n \tret = __tb_port_find_cap(port, cap);\n \n+\ttb_port_dummy_read(port);\n \ttb_port_enable_tmu(port, false);\n \n \treturn ret;\n",
    "prefixes": [
        "04/28"
    ]
}