Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1032827/?format=api
{ "id": 1032827, "url": "http://patchwork.ozlabs.org/api/patches/1032827/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20190129150143.12681-21-mika.westerberg@linux.intel.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190129150143.12681-21-mika.westerberg@linux.intel.com>", "list_archive_url": null, "date": "2019-01-29T15:01:35", "name": "[20/28] thunderbolt: Rework NFC credits handling", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "00e48da84df263c2cee4ee58e1ff3068fdbd4dc3", "submitter": { "id": 14534, "url": "http://patchwork.ozlabs.org/api/people/14534/?format=api", "name": "Mika Westerberg", "email": "mika.westerberg@linux.intel.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20190129150143.12681-21-mika.westerberg@linux.intel.com/mbox/", "series": [ { "id": 88859, "url": "http://patchwork.ozlabs.org/api/series/88859/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=88859", "date": "2019-01-29T15:01:18", "name": "thunderbolt: Software connection manager improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/88859/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1032827/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1032827/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.intel.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 43pqXM6zFTz9sDr\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tWed, 30 Jan 2019 02:04:19 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1729101AbfA2PER (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tTue, 29 Jan 2019 10:04:17 -0500", "from mga06.intel.com ([134.134.136.31]:3058 \"EHLO mga06.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1728347AbfA2PBy (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 29 Jan 2019 10:01:54 -0500", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jan 2019 07:01:53 -0800", "from black.fi.intel.com ([10.237.72.28])\n\tby orsmga007.jf.intel.com with ESMTP; 29 Jan 2019 07:01:51 -0800", "by black.fi.intel.com (Postfix, from userid 1001)\n\tid 2D270ABF; Tue, 29 Jan 2019 17:01:45 +0200 (EET)" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,537,1539673200\"; d=\"scan'208\";a=\"110723796\"", "From": "Mika Westerberg <mika.westerberg@linux.intel.com>", "To": "linux-kernel@vger.kernel.org", "Cc": "Michael Jamet <michael.jamet@intel.com>,\n\tYehezkel Bernat <YehezkelShB@gmail.com>,\n\tAndreas Noever <andreas.noever@gmail.com>,\n\tLukas Wunner <lukas@wunner.de>, \"David S . Miller\" <davem@davemloft.net>,\n\tMika Westerberg <mika.westerberg@linux.intel.com>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>,\n\tnetdev@vger.kernel.org", "Subject": "[PATCH 20/28] thunderbolt: Rework NFC credits handling", "Date": "Tue, 29 Jan 2019 18:01:35 +0300", "Message-Id": "<20190129150143.12681-21-mika.westerberg@linux.intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190129150143.12681-1-mika.westerberg@linux.intel.com>", "References": "<20190129150143.12681-1-mika.westerberg@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "NFC (non flow control) credits is actually 20-bit field so update\ntb_port_add_nfc_credits() to handle this properly. This allows us to set\nNFC credits for Display Port path in subsequent patches.\n\nAlso make sure the function does not update the hardware if the\nunderlying switch is already unplugged.\n\nSigned-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>\n---\n drivers/thunderbolt/switch.c | 20 +++++++++++++-------\n drivers/thunderbolt/tb_regs.h | 3 +++\n 2 files changed, 16 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c\nindex de69ada9a2f7..42681431eb7e 100644\n--- a/drivers/thunderbolt/switch.c\n+++ b/drivers/thunderbolt/switch.c\n@@ -544,14 +544,20 @@ int tb_wait_for_port(struct tb_port *port, bool wait_if_unplugged)\n */\n int tb_port_add_nfc_credits(struct tb_port *port, int credits)\n {\n-\tif (credits == 0)\n+\tu32 nfc_credits;\n+\n+\tif (credits == 0 || port->sw->is_unplugged)\n \t\treturn 0;\n-\ttb_port_info(port,\n-\t\t \"adding %#x NFC credits (%#x -> %#x)\",\n-\t\t credits,\n-\t\t port->config.nfc_credits,\n-\t\t port->config.nfc_credits + credits);\n-\tport->config.nfc_credits += credits;\n+\n+\tnfc_credits = port->config.nfc_credits & TB_PORT_NFC_CREDITS_MASK;\n+\tnfc_credits += credits;\n+\n+\ttb_port_dbg(port, \"adding %d NFC credits to %lu\",\n+\t\t credits, port->config.nfc_credits & TB_PORT_NFC_CREDITS_MASK);\n+\n+\tport->config.nfc_credits &= ~TB_PORT_NFC_CREDITS_MASK;\n+\tport->config.nfc_credits |= nfc_credits;\n+\n \treturn tb_port_write(port, &port->config.nfc_credits,\n \t\t\t TB_CFG_PORT, 4, 1);\n }\ndiff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h\nindex 75e935acade5..74c0f4a5606d 100644\n--- a/drivers/thunderbolt/tb_regs.h\n+++ b/drivers/thunderbolt/tb_regs.h\n@@ -211,6 +211,9 @@ struct tb_regs_port_header {\n \n } __packed;\n \n+/* DWORD 4 */\n+#define TB_PORT_NFC_CREDITS_MASK\tGENMASK(19, 0)\n+\n /* PCIe adapter registers */\n \n #define TB_PCI_EN\t\t\tBIT(31)\n", "prefixes": [ "20/28" ] }