Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1032814/?format=api
{ "id": 1032814, "url": "http://patchwork.ozlabs.org/api/patches/1032814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20190129150143.12681-4-mika.westerberg@linux.intel.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190129150143.12681-4-mika.westerberg@linux.intel.com>", "list_archive_url": null, "date": "2019-01-29T15:01:18", "name": "[03/28] thunderbolt: Enable TMU access when accessing port space on legacy devices", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "1eae4032e268c5765cc6095852ece203d8780545", "submitter": { "id": 14534, "url": "http://patchwork.ozlabs.org/api/people/14534/?format=api", "name": "Mika Westerberg", "email": "mika.westerberg@linux.intel.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20190129150143.12681-4-mika.westerberg@linux.intel.com/mbox/", "series": [ { "id": 88859, "url": "http://patchwork.ozlabs.org/api/series/88859/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=88859", "date": "2019-01-29T15:01:18", "name": "thunderbolt: Software connection manager improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/88859/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1032814/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1032814/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=linux.intel.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 43pqTW2sd2z9sDP\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tWed, 30 Jan 2019 02:01:51 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1728044AbfA2PBt (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tTue, 29 Jan 2019 10:01:49 -0500", "from mga09.intel.com ([134.134.136.24]:12289 \"EHLO mga09.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1727772AbfA2PBs (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 29 Jan 2019 10:01:48 -0500", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jan 2019 07:01:47 -0800", "from black.fi.intel.com ([10.237.72.28])\n\tby fmsmga007.fm.intel.com with ESMTP; 29 Jan 2019 07:01:45 -0800", "by black.fi.intel.com (Postfix, from userid 1001)\n\tid 41632323; Tue, 29 Jan 2019 17:01:44 +0200 (EET)" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,537,1539673200\"; d=\"scan'208\";a=\"118367165\"", "From": "Mika Westerberg <mika.westerberg@linux.intel.com>", "To": "linux-kernel@vger.kernel.org", "Cc": "Michael Jamet <michael.jamet@intel.com>,\n\tYehezkel Bernat <YehezkelShB@gmail.com>,\n\tAndreas Noever <andreas.noever@gmail.com>,\n\tLukas Wunner <lukas@wunner.de>, \"David S . Miller\" <davem@davemloft.net>,\n\tMika Westerberg <mika.westerberg@linux.intel.com>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>,\n\tnetdev@vger.kernel.org", "Subject": "[PATCH 03/28] thunderbolt: Enable TMU access when accessing port\n\tspace on legacy devices", "Date": "Tue, 29 Jan 2019 18:01:18 +0300", "Message-Id": "<20190129150143.12681-4-mika.westerberg@linux.intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190129150143.12681-1-mika.westerberg@linux.intel.com>", "References": "<20190129150143.12681-1-mika.westerberg@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Light Ridge and Eagle Ridge both need to have TMU access enabled before\nport space can be fully accessed so make sure it happens on those. This\nallows us to get rid of the offset quirk in tb_port_find_cap().\n\nSigned-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>\n---\n drivers/thunderbolt/cap.c | 73 ++++++++++++++++++++++++++++++---------\n 1 file changed, 56 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/thunderbolt/cap.c b/drivers/thunderbolt/cap.c\nindex 9553305c63ea..94a507f12b71 100644\n--- a/drivers/thunderbolt/cap.c\n+++ b/drivers/thunderbolt/cap.c\n@@ -22,28 +22,43 @@ struct tb_cap_any {\n \t};\n } __packed;\n \n-/**\n- * tb_port_find_cap() - Find port capability\n- * @port: Port to find the capability for\n- * @cap: Capability to look\n- *\n- * Returns offset to start of capability or %-ENOENT if no such\n- * capability was found. Negative errno is returned if there was an\n- * error.\n- */\n-int tb_port_find_cap(struct tb_port *port, enum tb_port_cap cap)\n+static int tb_port_enable_tmu(struct tb_port *port, bool enable)\n {\n-\tu32 offset;\n+\tstruct tb_switch *sw = port->sw;\n+\tu32 value, offset;\n+\tint ret;\n \n \t/*\n-\t * DP out adapters claim to implement TMU capability but in\n-\t * reality they do not so we hard code the adapter specific\n-\t * capability offset here.\n+\t * Legacy devices need to have TMU access enabled before port\n+\t * space can be fully accessed.\n \t */\n-\tif (port->config.type == TB_TYPE_DP_HDMI_OUT)\n-\t\toffset = 0x39;\n+\tswitch (sw->config.device_id) {\n+\tcase PCI_DEVICE_ID_INTEL_LIGHT_RIDGE:\n+\t\toffset = 0x26;\n+\t\tbreak;\n+\tcase PCI_DEVICE_ID_INTEL_EAGLE_RIDGE:\n+\t\toffset = 0x2a;\n+\t\tbreak;\n+\n+\tdefault:\n+\t\treturn 0;\n+\t}\n+\n+\tret = tb_sw_read(sw, &value, TB_CFG_SWITCH, offset, 1);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tif (enable)\n+\t\tvalue |= BIT(20);\n \telse\n-\t\toffset = 0x1;\n+\t\tvalue &= ~BIT(20);\n+\n+\treturn tb_sw_write(sw, &value, TB_CFG_SWITCH, offset, 1);\n+}\n+\n+static int __tb_port_find_cap(struct tb_port *port, enum tb_port_cap cap)\n+{\n+\tu32 offset = 1;\n \n \tdo {\n \t\tstruct tb_cap_any header;\n@@ -62,6 +77,30 @@ int tb_port_find_cap(struct tb_port *port, enum tb_port_cap cap)\n \treturn -ENOENT;\n }\n \n+/**\n+ * tb_port_find_cap() - Find port capability\n+ * @port: Port to find the capability for\n+ * @cap: Capability to look\n+ *\n+ * Returns offset to start of capability or %-ENOENT if no such\n+ * capability was found. Negative errno is returned if there was an\n+ * error.\n+ */\n+int tb_port_find_cap(struct tb_port *port, enum tb_port_cap cap)\n+{\n+\tint ret;\n+\n+\tret = tb_port_enable_tmu(port, true);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = __tb_port_find_cap(port, cap);\n+\n+\ttb_port_enable_tmu(port, false);\n+\n+\treturn ret;\n+}\n+\n static int tb_switch_find_cap(struct tb_switch *sw, enum tb_switch_cap cap)\n {\n \tint offset = sw->config.first_cap_offset;\n", "prefixes": [ "03/28" ] }