Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1031,
    "url": "http://patchwork.ozlabs.org/api/patches/1031/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.011152.193685128.davem@davemloft.net/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080923.011152.193685128.davem@davemloft.net>",
    "list_archive_url": null,
    "date": "2008-09-23T08:11:52",
    "name": ": neigh: Remove by-hand SKB queue handling.",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d7e18fa7adfacf4a4c1b44efd08a378ac1a58355",
    "submitter": {
        "id": 15,
        "url": "http://patchwork.ozlabs.org/api/people/15/?format=api",
        "name": "David Miller",
        "email": "davem@davemloft.net"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.011152.193685128.davem@davemloft.net/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1031/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1031/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 15A60DDE9F\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 18:12:12 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751652AbYIWIMG (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 04:12:06 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1751459AbYIWIMG\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 04:12:06 -0400",
            "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:45822\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751357AbYIWIME (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 23 Sep 2008 04:12:04 -0400",
            "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 92D11C8C181\n\tfor <netdev@vger.kernel.org>; Tue, 23 Sep 2008 01:11:52 -0700 (PDT)"
        ],
        "Date": "Tue, 23 Sep 2008 01:11:52 -0700 (PDT)",
        "Message-Id": "<20080923.011152.193685128.davem@davemloft.net>",
        "To": "netdev@vger.kernel.org",
        "Subject": "[PATCH]: neigh: Remove by-hand SKB queue handling.",
        "From": "David Miller <davem@davemloft.net>",
        "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)",
        "Mime-Version": "1.0",
        "Content-Type": "Text/Plain; charset=us-ascii",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "neigh: Remove by-hand SKB queue handling.\n\nSigned-off-by: David S. Miller <davem@davemloft.net>\n---\n net/core/neighbour.c |   21 ++++++++-------------\n 1 files changed, 8 insertions(+), 13 deletions(-)",
    "diff": "diff --git a/net/core/neighbour.c b/net/core/neighbour.c\nindex 9d92e41..1dc728b 100644\n--- a/net/core/neighbour.c\n+++ b/net/core/neighbour.c\n@@ -927,8 +927,7 @@ int __neigh_event_send(struct neighbour *neigh, struct sk_buff *skb)\n \t\t\tif (skb_queue_len(&neigh->arp_queue) >=\n \t\t\t    neigh->parms->queue_len) {\n \t\t\t\tstruct sk_buff *buff;\n-\t\t\t\tbuff = neigh->arp_queue.next;\n-\t\t\t\t__skb_unlink(buff, &neigh->arp_queue);\n+\t\t\t\tbuff = __skb_dequeue(&neigh->arp_queue);\n \t\t\t\tkfree_skb(buff);\n \t\t\t\tNEIGH_CACHE_STAT_INC(neigh->tbl, unres_discards);\n \t\t\t}\n@@ -1259,24 +1258,20 @@ static void neigh_proxy_process(unsigned long arg)\n \tstruct neigh_table *tbl = (struct neigh_table *)arg;\n \tlong sched_next = 0;\n \tunsigned long now = jiffies;\n-\tstruct sk_buff *skb;\n+\tstruct sk_buff *skb, *n;\n \n \tspin_lock(&tbl->proxy_queue.lock);\n \n-\tskb = tbl->proxy_queue.next;\n-\n-\twhile (skb != (struct sk_buff *)&tbl->proxy_queue) {\n-\t\tstruct sk_buff *back = skb;\n-\t\tlong tdif = NEIGH_CB(back)->sched_next - now;\n+\tskb_queue_walk_safe(&tbl->proxy_queue, skb, n) {\n+\t\tlong tdif = NEIGH_CB(skb)->sched_next - now;\n \n-\t\tskb = skb->next;\n \t\tif (tdif <= 0) {\n-\t\t\tstruct net_device *dev = back->dev;\n-\t\t\t__skb_unlink(back, &tbl->proxy_queue);\n+\t\t\tstruct net_device *dev = skb->dev;\n+\t\t\t__skb_unlink(skb, &tbl->proxy_queue);\n \t\t\tif (tbl->proxy_redo && netif_running(dev))\n-\t\t\t\ttbl->proxy_redo(back);\n+\t\t\t\ttbl->proxy_redo(skb);\n \t\t\telse\n-\t\t\t\tkfree_skb(back);\n+\t\t\t\tkfree_skb(skb);\n \n \t\t\tdev_put(dev);\n \t\t} else if (!sched_next || tdif < sched_next)\n",
    "prefixes": []
}