Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1024050/?format=api
{ "id": 1024050, "url": "http://patchwork.ozlabs.org/api/patches/1024050/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190113092231.40675-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190113092231.40675-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-01-13T09:22:31", "name": "[1/1] igc: Remove unneeded code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c6f14b56a15fc09d11c67c897fc6cfa42e678c72", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190113092231.40675-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 85832, "url": "http://patchwork.ozlabs.org/api/series/85832/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=85832", "date": "2019-01-13T09:22:31", "name": "[1/1] igc: Remove unneeded code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/85832/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1024050/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1024050/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43crjX4NX2z9s3q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 13 Jan 2019 20:22:39 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1FDFB85005;\n\tSun, 13 Jan 2019 09:22:37 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TYlX2sa5LFLI; Sun, 13 Jan 2019 09:22:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3EE4984B96;\n\tSun, 13 Jan 2019 09:22:35 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 64C8E1BF5AA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 13 Jan 2019 09:22:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 60BE6228B3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 13 Jan 2019 09:22:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id olAm3qaSQyAS for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 13 Jan 2019 09:22:32 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D109E2202C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 13 Jan 2019 09:22:32 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jan 2019 01:22:32 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby fmsmga007.fm.intel.com with ESMTP; 13 Jan 2019 01:22:31 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,473,1539673200\"; d=\"scan'208\";a=\"114303423\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Sun, 13 Jan 2019 11:22:31 +0200", "Message-Id": "<20190113092231.40675-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH 1/1] igc: Remove unneeded code", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Remove the 'igc_get_link_up_info_base method' from igc_base.c file.\nUse the 'igc_get_speed_and_duplex_copper' method directly and reduce\nthe code redundancy.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_base.c | 22 +---------------------\n 1 file changed, 1 insertion(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c\nindex 19ff987922d2..a31ec1682090 100644\n--- a/drivers/net/ethernet/intel/igc/igc_base.c\n+++ b/drivers/net/ethernet/intel/igc/igc_base.c\n@@ -334,26 +334,6 @@ static void igc_release_phy_base(struct igc_hw *hw)\n }\n \n /**\n- * igc_get_link_up_info_base - Get link speed/duplex info\n- * @hw: pointer to the HW structure\n- * @speed: stores the current speed\n- * @duplex: stores the current duplex\n- *\n- * This is a wrapper function, if using the serial gigabit media independent\n- * interface, use PCS to retrieve the link speed and duplex information.\n- * Otherwise, use the generic function to get the link speed and duplex info.\n- */\n-static s32 igc_get_link_up_info_base(struct igc_hw *hw, u16 *speed,\n-\t\t\t\t u16 *duplex)\n-{\n-\ts32 ret_val;\n-\n-\tret_val = igc_get_speed_and_duplex_copper(hw, speed, duplex);\n-\n-\treturn ret_val;\n-}\n-\n-/**\n * igc_init_hw_base - Initialize hardware\n * @hw: pointer to the HW structure\n *\n@@ -499,7 +479,7 @@ static struct igc_mac_operations igc_mac_ops_base = {\n \t.check_for_link\t\t= igc_check_for_copper_link,\n \t.rar_set\t\t= igc_rar_set,\n \t.read_mac_addr\t\t= igc_read_mac_addr_base,\n-\t.get_speed_and_duplex\t= igc_get_link_up_info_base,\n+\t.get_speed_and_duplex\t= igc_get_speed_and_duplex_copper,\n };\n \n static const struct igc_phy_operations igc_phy_ops_base = {\n", "prefixes": [ "1/1" ] }