Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1022724/?format=api
{ "id": 1022724, "url": "http://patchwork.ozlabs.org/api/patches/1022724/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190110042157.8445-1-natechancellor@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190110042157.8445-1-natechancellor@gmail.com>", "list_archive_url": null, "date": "2019-01-10T04:21:57", "name": "iavf: Use printf instead of gnu_printf for iavf_debug_d", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ac35a2b4b935d5d38be3d65454aa92ab6859e569", "submitter": { "id": 73753, "url": "http://patchwork.ozlabs.org/api/people/73753/?format=api", "name": "Nathan Chancellor", "email": "natechancellor@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190110042157.8445-1-natechancellor@gmail.com/mbox/", "series": [ { "id": 85287, "url": "http://patchwork.ozlabs.org/api/series/85287/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=85287", "date": "2019-01-10T04:21:57", "name": "iavf: Use printf instead of gnu_printf for iavf_debug_d", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/85287/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1022724/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1022724/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Rqen0wuO\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43ZtCN4D1Cz9sN4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 10 Jan 2019 15:23:11 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 075C985F2F;\n\tThu, 10 Jan 2019 04:23:09 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hFySPGMNjeP4; Thu, 10 Jan 2019 04:23:07 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B22B985F97;\n\tThu, 10 Jan 2019 04:23:07 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 023941C266A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Jan 2019 04:23:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F2D288217F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Jan 2019 04:23:06 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id p0ShaVxgwrlY for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Jan 2019 04:23:00 +0000 (UTC)", "from mail-wm1-f65.google.com (mail-wm1-f65.google.com\n\t[209.85.128.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 3C0B78742F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 10 Jan 2019 04:23:00 +0000 (UTC)", "by mail-wm1-f65.google.com with SMTP id m1so9867302wml.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 09 Jan 2019 20:23:00 -0800 (PST)", "from localhost.localdomain ([2a01:4f8:10b:24a5::2])\n\tby smtp.gmail.com with ESMTPSA id\n\to17sm31424404wmg.35.2019.01.09.20.22.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 09 Jan 2019 20:22:57 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=QqX0rVPHii2lBkNIAiDC7sBkxbxQR0a9q1iDJSjqxlc=;\n\tb=Rqen0wuOTZdcHwhIBQKC3NfCebb22kcMUIBKJjYOy0rNOoFf6Nzo8GE1bRSxJQjM3m\n\tu1c+YnkOTiei1YT72J8OlWnYl8wA2wiKLDW6S3byk9y0GJeVQncKnRMWsoT3pRNUePFW\n\tc27MXDbObamUa2L1kIVbFFzfk/VYKmFgmfSMV+2OGVE8Y/8IMbv4QFt48vO/jboS57+2\n\t2Qx/Y+BGlpWQy1QoxeFWzHMs6eDAxf0/5rdVfxIm4Hd8VNA7epdgXyZ4T0M4+zweMwIm\n\t2X6XR/5s8VHUb6TDRbVTYj6Ns05oy4+xB2/00vGNxqG5dTT9Y2dtljffhjx8V2yYV3P4\n\tBoqQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=QqX0rVPHii2lBkNIAiDC7sBkxbxQR0a9q1iDJSjqxlc=;\n\tb=p1n7YN3DCNPAC0+pyvrLFUEv47SDwWly9vH1YVp6JkRdIfOX5nLrzR/gOi7gDc2nKo\n\t+8br2ljubl1Kp8hXyvYhXIDdvqilooIu/+6azuDL8hPT/n4BISbN0BRycMMRy2slAEjz\n\tCh1DO0QJkL2AYlYX08vTc9ZpU6eIN/2AYBXfDjiY4CcikesflT8i7bgB9ZFpxIa4bha4\n\tuSPxszIAcEcNf0qUEgIhLJgjjBrJE5eM2SGdg7XRXi8MBhC6EVUm3VzdZuy3D+rqmHoF\n\tIigGraSnsOJaucU/J5mxWncSJARUhj98p8dSy/scXapOi8bXBb4OwBd21RC7oVxn8lSX\n\tJUIg==", "X-Gm-Message-State": "AJcUukc20/sfe/t9d8lqci6no0p/NMfv9ShADtPsshqTS/uYbSoG7wHB\n\tqUpGvT71PX31QnD+3cj2qbo=", "X-Google-Smtp-Source": "ALg8bN6NUzhMjMNUeJ9GUcxi661elHrpdgfTM/go1BxH+6ID8PPpiEPM6XooZkp4kkEb5Ru4kkptJw==", "X-Received": "by 2002:a1c:2787:: with SMTP id\n\tn129mr8450620wmn.128.1547094178308; \n\tWed, 09 Jan 2019 20:22:58 -0800 (PST)", "From": "Nathan Chancellor <natechancellor@gmail.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Wed, 9 Jan 2019 21:21:57 -0700", "Message-Id": "<20190110042157.8445-1-natechancellor@gmail.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "X-Patchwork-Bot": "notify", "Subject": "[Intel-wired-lan] [PATCH] iavf: Use printf instead of gnu_printf\n\tfor iavf_debug_d", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Nick Desaulniers <ndesaulniers@google.com>,\n\tlinux-kernel@vger.kernel.org,\n\tMiguel Ojeda <miguel.ojeda.sandonis@gmail.com>, \n\tintel-wired-lan@lists.osuosl.org,\n\tNathan Chancellor <natechancellor@gmail.com>, \n\t\"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Clang warns:\n\nIn file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4:\nIn file included from drivers/net/ethernet/intel/iavf/iavf.h:37:\nIn file included from drivers/net/ethernet/intel/iavf/iavf_type.h:8:\ndrivers/net/ethernet/intel/iavf/iavf_osdep.h:49:18: warning: 'format' attribute argument not supported: gnu_printf [-Wignored-attributes]\n __attribute__ ((format(gnu_printf, 3, 4)));\n ^\n1 warning generated.\n\nWe can convert from gnu_printf to printf without any side effects for\ntwo reasons:\n\n1. All iavf_debug instances use standard printf formats, as pointed out\n by Miguel Ojeda at the below link, meaning gnu_printf is not strictly\n required.\n\n2. However, GCC has aliased printf to gnu_printf on Linux since at least\n 2010 based on git history.\n\n From gcc/c-family/c-format.c:\n\n /* Attributes such as \"printf\" are equivalent to those such as\n \"gnu_printf\" unless this is overridden by a target. */\n static const target_ovr_attr gnu_target_overrides_format_attributes[] =\n {\n { \"gnu_printf\", \"printf\" },\n { \"gnu_scanf\", \"scanf\" },\n { \"gnu_strftime\", \"strftime\" },\n { \"gnu_strfmon\", \"strfmon\" },\n { NULL, NULL }\n };\n\nThe mentioned override only happens on Windows (mingw32). Changing from\ngnu_printf to printf is a no-op for GCC and stops Clang from warning.\n\nLink: https://github.com/ClangBuiltLinux/linux/issues/111\nSuggested-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>\nSigned-off-by: Nathan Chancellor <natechancellor@gmail.com>\n---\n drivers/net/ethernet/intel/iavf/iavf_osdep.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_osdep.h b/drivers/net/ethernet/intel/iavf/iavf_osdep.h\nindex e6e0b0328706..c90cafb526d0 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_osdep.h\n+++ b/drivers/net/ethernet/intel/iavf/iavf_osdep.h\n@@ -46,7 +46,7 @@ struct iavf_virt_mem {\n \n #define iavf_debug(h, m, s, ...) iavf_debug_d(h, m, s, ##__VA_ARGS__)\n extern void iavf_debug_d(void *hw, u32 mask, char *fmt_str, ...)\n-\t__attribute__ ((format(gnu_printf, 3, 4)));\n+\t__printf(3, 4);\n \n typedef enum iavf_status_code iavf_status;\n #endif /* _IAVF_OSDEP_H_ */\n", "prefixes": [] }