Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1022,
    "url": "http://patchwork.ozlabs.org/api/patches/1022/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.002826.111592180.davem@davemloft.net/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080923.002826.111592180.davem@davemloft.net>",
    "list_archive_url": null,
    "date": "2008-09-23T07:28:26",
    "name": ": usbatm: Use skb_queue_walk_safe() instead of by-hand implementation.",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d6d1186b2c951884cc5261184b705addf95a6b94",
    "submitter": {
        "id": 15,
        "url": "http://patchwork.ozlabs.org/api/people/15/?format=api",
        "name": "David Miller",
        "email": "davem@davemloft.net"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080923.002826.111592180.davem@davemloft.net/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1022/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1022/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id C8024DDED8\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 17:28:42 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753136AbYIWH2i (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 03:28:38 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1753227AbYIWH2i\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 03:28:38 -0400",
            "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:47893\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753040AbYIWH2h (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 23 Sep 2008 03:28:37 -0400",
            "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 57DC0C8C181\n\tfor <netdev@vger.kernel.org>; Tue, 23 Sep 2008 00:28:26 -0700 (PDT)"
        ],
        "Date": "Tue, 23 Sep 2008 00:28:26 -0700 (PDT)",
        "Message-Id": "<20080923.002826.111592180.davem@davemloft.net>",
        "To": "netdev@vger.kernel.org",
        "Subject": "[PATCH]: usbatm: Use skb_queue_walk_safe() instead of by-hand\n\timplementation.",
        "From": "David Miller <davem@davemloft.net>",
        "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)",
        "Mime-Version": "1.0",
        "Content-Type": "Text/Plain; charset=us-ascii",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "usbatm: Use skb_queue_walk_safe() instead of by-hand implementation.\n\nSigned-off-by: David S. Miller <davem@davemloft.net>\n---\n drivers/usb/atm/usbatm.c |    5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c\nindex 0722872..0da2c25 100644\n--- a/drivers/usb/atm/usbatm.c\n+++ b/drivers/usb/atm/usbatm.c\n@@ -640,14 +640,13 @@ static void usbatm_cancel_send(struct usbatm_data *instance,\n \n \tatm_dbg(instance, \"%s entered\\n\", __func__);\n \tspin_lock_irq(&instance->sndqueue.lock);\n-\tfor (skb = instance->sndqueue.next, n = skb->next;\n-\t     skb != (struct sk_buff *)&instance->sndqueue;\n-\t     skb = n, n = skb->next)\n+\tskb_queue_walk_safe(&instance->sndqueue, skb, n) {\n \t\tif (UDSL_SKB(skb)->atm.vcc == vcc) {\n \t\t\tatm_dbg(instance, \"%s: popping skb 0x%p\\n\", __func__, skb);\n \t\t\t__skb_unlink(skb, &instance->sndqueue);\n \t\t\tusbatm_pop(vcc, skb);\n \t\t}\n+\t}\n \tspin_unlock_irq(&instance->sndqueue.lock);\n \n \ttasklet_disable(&instance->tx_channel.tasklet);\n",
    "prefixes": []
}