Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1021674/?format=api
{ "id": 1021674, "url": "http://patchwork.ozlabs.org/api/patches/1021674/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190108005502.4210-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20190108005502.4210-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-01-08T00:55:02", "name": "checkpatch: don't complain about LEADING_SPACE in CPP continuations", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "a51c30c53e8f214c89dc36fc92da421858cff580", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20190108005502.4210-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 84854, "url": "http://patchwork.ozlabs.org/api/series/84854/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=84854", "date": "2019-01-08T00:55:02", "name": "checkpatch: don't complain about LEADING_SPACE in CPP continuations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/84854/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1021674/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1021674/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43YYhK0RVzz9sDT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 8 Jan 2019 11:55:11 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 76E1784F5A;\n\tTue, 8 Jan 2019 00:55:09 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vm9RvzkLRedz; Tue, 8 Jan 2019 00:55:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BFEE085BC9;\n\tTue, 8 Jan 2019 00:55:08 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id AFB0B1C3353\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Jan 2019 00:55:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A18C985BC9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Jan 2019 00:55:06 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VVWZvWkSxtag for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Jan 2019 00:55:05 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 782EC85BD6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Jan 2019 00:55:05 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Jan 2019 16:55:04 -0800", "from jekeller-desk.amr.corp.intel.com ([10.166.244.182])\n\tby fmsmga007.fm.intel.com with ESMTP; 07 Jan 2019 16:55:04 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,451,1539673200\"; d=\"scan'208\";a=\"112916282\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 7 Jan 2019 16:55:02 -0800", "Message-Id": "<20190108005502.4210-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.18.0.219.gaf81d287a9da", "Subject": "[Intel-wired-lan] [PATCH] checkpatch: don't complain about\n\tLEADING_SPACE in CPP continuations", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "If a C preprocessor macro is continued onto another line using\na backslash line continuation, checkpatch.pl will complain about leading\nspaces used to indent the multiline conditional.\n\nThis leads to warnings similar to the following\n\n WARNING: please, no spaces at the start of a line\n #107: FILE: arch/m68k/include/asm/mcfgpio.h:107:\n + defined(CONFIG_M53xx) || defined(CONFIG_M54xx) || \\$\n\n WARNING: please, no spaces at the start of a line\n #108: FILE: arch/m68k/include/asm/mcfgpio.h:108:\n + defined(CONFIG_M5441x)$\n\nTo fix these warnings, modify the test to also exclude lines which end\nin a backslach continuation, as these lines should only occur within\na multiline C Preprocessor check.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n scripts/checkpatch.pl | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl\nindex e16ce8b0c462..871bb37876b2 100755\n--- a/scripts/checkpatch.pl\n+++ b/scripts/checkpatch.pl\n@@ -3361,7 +3361,8 @@ sub process {\n # 1) within comments\n # 2) indented preprocessor commands\n # 3) hanging labels\n-\t\tif ($rawline =~ /^\\+ / && $line !~ /^\\+ *(?:$;|#|$Ident:)/) {\n+\t\tif ($rawline =~ /^\\+ / && $line !~ /^\\+ *(?:$;|#|$Ident:)/ &&\n+\t\t $prevline !~ /\\\\$/) {\n \t\t\tmy $herevet = \"$here\\n\" . cat_vet($rawline) . \"\\n\";\n \t\t\tif (WARN(\"LEADING_SPACE\",\n \t\t\t\t \"please, no spaces at the start of a line\\n\" . $herevet) &&\n", "prefixes": [] }