Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1016400/?format=api
{ "id": 1016400, "url": "http://patchwork.ozlabs.org/api/patches/1016400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181219144542.85924-5-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181219144542.85924-5-alice.michael@intel.com>", "list_archive_url": null, "date": "2018-12-19T14:45:41", "name": "[next,S1,5/6] i40e: remove debugfs tx_timeout support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fa020843cd37b587a8281a04ff5e5bc7161a71f9", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181219144542.85924-5-alice.michael@intel.com/mbox/", "series": [ { "id": 82959, "url": "http://patchwork.ozlabs.org/api/series/82959/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=82959", "date": "2018-12-19T14:45:37", "name": "[next,S1,1/6] i40e: Limiting RSS queues to CPUs.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/82959/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1016400/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1016400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43Kr193kKkz9sD4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 20 Dec 2018 09:59:09 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C5B1686425;\n\tWed, 19 Dec 2018 22:59:07 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id A8wgR0p4W-vp; Wed, 19 Dec 2018 22:59:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7987785B84;\n\tWed, 19 Dec 2018 22:59:06 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id F382C1BF311\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Dec 2018 22:59:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EE76D221F8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Dec 2018 22:59:04 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id J+WMggCcUP4V for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Dec 2018 22:59:03 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3D64B2284E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 19 Dec 2018 22:59:03 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Dec 2018 14:59:02 -0800", "from alicemic-2.jf.intel.com ([10.166.16.121])\n\tby fmsmga008.fm.intel.com with ESMTP; 19 Dec 2018 14:59:02 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,374,1539673200\"; d=\"scan'208\";a=\"110769141\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Wed, 19 Dec 2018 06:45:41 -0800", "Message-Id": "<20181219144542.85924-5-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20181219144542.85924-1-alice.michael@intel.com>", "References": "<20181219144542.85924-1-alice.michael@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH S1 5/6] i40e: remove debugfs\n\ttx_timeout support", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Lihong Yang <lihong.yang@intel.com>\n\nThe tx_timeout command from debugfs was originally intended to support\nearly silicon validation efforts. It is no longer needed. Thus remove it to\navoid misuse of triggering tx_timeout through debugfs.\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\n---\n .../net/ethernet/intel/i40e/i40e_debugfs.c | 26 +------------------\n 1 file changed, 1 insertion(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex a20d1cf058ad..c67d485d6f99 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -1642,30 +1642,7 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,\n \t\tcount = buf_tmp - i40e_dbg_netdev_ops_buf + 1;\n \t}\n \n-\tif (strncmp(i40e_dbg_netdev_ops_buf, \"tx_timeout\", 10) == 0) {\n-\t\tcnt = sscanf(&i40e_dbg_netdev_ops_buf[11], \"%i\", &vsi_seid);\n-\t\tif (cnt != 1) {\n-\t\t\tdev_info(&pf->pdev->dev, \"tx_timeout <vsi_seid>\\n\");\n-\t\t\tgoto netdev_ops_write_done;\n-\t\t}\n-\t\tvsi = i40e_dbg_find_vsi(pf, vsi_seid);\n-\t\tif (!vsi) {\n-\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"tx_timeout: VSI %d not found\\n\", vsi_seid);\n-\t\t} else if (!vsi->netdev) {\n-\t\t\tdev_info(&pf->pdev->dev, \"tx_timeout: no netdev for VSI %d\\n\",\n-\t\t\t\t vsi_seid);\n-\t\t} else if (test_bit(__I40E_VSI_DOWN, vsi->state)) {\n-\t\t\tdev_info(&pf->pdev->dev, \"tx_timeout: VSI %d not UP\\n\",\n-\t\t\t\t vsi_seid);\n-\t\t} else if (rtnl_trylock()) {\n-\t\t\tvsi->netdev->netdev_ops->ndo_tx_timeout(vsi->netdev);\n-\t\t\trtnl_unlock();\n-\t\t\tdev_info(&pf->pdev->dev, \"tx_timeout called\\n\");\n-\t\t} else {\n-\t\t\tdev_info(&pf->pdev->dev, \"Could not acquire RTNL - please try again\\n\");\n-\t\t}\n-\t} else if (strncmp(i40e_dbg_netdev_ops_buf, \"change_mtu\", 10) == 0) {\n+\tif (strncmp(i40e_dbg_netdev_ops_buf, \"change_mtu\", 10) == 0) {\n \t\tint mtu;\n \n \t\tcnt = sscanf(&i40e_dbg_netdev_ops_buf[11], \"%i %i\",\n@@ -1733,7 +1710,6 @@ static ssize_t i40e_dbg_netdev_ops_write(struct file *filp,\n \t\tdev_info(&pf->pdev->dev, \"unknown command '%s'\\n\",\n \t\t\t i40e_dbg_netdev_ops_buf);\n \t\tdev_info(&pf->pdev->dev, \"available commands\\n\");\n-\t\tdev_info(&pf->pdev->dev, \" tx_timeout <vsi_seid>\\n\");\n \t\tdev_info(&pf->pdev->dev, \" change_mtu <vsi_seid> <mtu>\\n\");\n \t\tdev_info(&pf->pdev->dev, \" set_rx_mode <vsi_seid>\\n\");\n \t\tdev_info(&pf->pdev->dev, \" napi <vsi_seid>\\n\");\n", "prefixes": [ "next", "S1", "5/6" ] }