Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1015195/?format=api
{ "id": 1015195, "url": "http://patchwork.ozlabs.org/api/patches/1015195/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181218092954.29914-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181218092954.29914-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2018-12-18T09:29:54", "name": "[1/1] igc: Fix code redundancy", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "92e16dc01c224701901078afe31a05163d5f59b7", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181218092954.29914-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 82549, "url": "http://patchwork.ozlabs.org/api/series/82549/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=82549", "date": "2018-12-18T09:29:54", "name": "[1/1] igc: Fix code redundancy", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/82549/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1015195/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1015195/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43Jt654rk0z9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 18 Dec 2018 20:30:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A95D8868AD;\n\tTue, 18 Dec 2018 09:30:01 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UbEBsZrzG93i; Tue, 18 Dec 2018 09:30:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2E6388654D;\n\tTue, 18 Dec 2018 09:30:00 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 226601C2A60\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Dec 2018 09:29:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1E30C8654D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Dec 2018 09:29:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id C3a5-EUG7Ce0 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Dec 2018 09:29:57 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 2CEA5864F3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 18 Dec 2018 09:29:57 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Dec 2018 01:29:56 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby fmsmga005.fm.intel.com with ESMTP; 18 Dec 2018 01:29:55 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,367,1539673200\"; d=\"scan'208\";a=\"304732876\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 18 Dec 2018 11:29:54 +0200", "Message-Id": "<20181218092954.29914-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH 1/1] igc: Fix code redundancy", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Remove redundant igc_check_for_link_base code and replace it with\nan igc_check_for_copper_link method.\nFix duplication of IGC_ADVTXD_PAYLEN_SHIFT mask declaration.\nRemove obsolete IGC_SCVPC register definition.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_base.c | 20 ++------------------\n drivers/net/ethernet/intel/igc/igc_base.h | 3 ---\n drivers/net/ethernet/intel/igc/igc_regs.h | 1 -\n 3 files changed, 2 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c\nindex df40af759542..19ff987922d2 100644\n--- a/drivers/net/ethernet/intel/igc/igc_base.c\n+++ b/drivers/net/ethernet/intel/igc/igc_base.c\n@@ -54,22 +54,6 @@ static s32 igc_set_pcie_completion_timeout(struct igc_hw *hw)\n }\n \n /**\n- * igc_check_for_link_base - Check for link\n- * @hw: pointer to the HW structure\n- *\n- * If sgmii is enabled, then use the pcs register to determine link, otherwise\n- * use the generic interface for determining link.\n- */\n-static s32 igc_check_for_link_base(struct igc_hw *hw)\n-{\n-\ts32 ret_val = 0;\n-\n-\tret_val = igc_check_for_copper_link(hw);\n-\n-\treturn ret_val;\n-}\n-\n-/**\n * igc_reset_hw_base - Reset hardware\n * @hw: pointer to the HW structure\n *\n@@ -265,7 +249,7 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)\n \tif (ret_val)\n \t\treturn ret_val;\n \n-\tigc_check_for_link_base(hw);\n+\tigc_check_for_copper_link(hw);\n \n \t/* Verify phy id and set remaining function pointers */\n \tswitch (phy->id) {\n@@ -512,7 +496,7 @@ void igc_rx_fifo_flush_base(struct igc_hw *hw)\n \n static struct igc_mac_operations igc_mac_ops_base = {\n \t.init_hw\t\t= igc_init_hw_base,\n-\t.check_for_link\t\t= igc_check_for_link_base,\n+\t.check_for_link\t\t= igc_check_for_copper_link,\n \t.rar_set\t\t= igc_rar_set,\n \t.read_mac_addr\t\t= igc_read_mac_addr_base,\n \t.get_speed_and_duplex\t= igc_get_link_up_info_base,\ndiff --git a/drivers/net/ethernet/intel/igc/igc_base.h b/drivers/net/ethernet/intel/igc/igc_base.h\nindex 35588fa7b8c5..a5d3f57274a8 100644\n--- a/drivers/net/ethernet/intel/igc/igc_base.h\n+++ b/drivers/net/ethernet/intel/igc/igc_base.h\n@@ -90,9 +90,6 @@ union igc_adv_rx_desc {\n \t} wb; /* writeback */\n };\n \n-/* Adv Transmit Descriptor Config Masks */\n-#define IGC_ADVTXD_PAYLEN_SHIFT\t14 /* Adv desc PAYLEN shift */\n-\n /* Additional Transmit Descriptor Control definitions */\n #define IGC_TXDCTL_QUEUE_ENABLE\t0x02000000 /* Ena specific Tx Queue */\n \ndiff --git a/drivers/net/ethernet/intel/igc/igc_regs.h b/drivers/net/ethernet/intel/igc/igc_regs.h\nindex a1bd3216c906..f8c835283377 100644\n--- a/drivers/net/ethernet/intel/igc/igc_regs.h\n+++ b/drivers/net/ethernet/intel/igc/igc_regs.h\n@@ -188,7 +188,6 @@\n #define IGC_HGOTCL\t0x04130 /* Host Good Octets Transmit Count Low */\n #define IGC_HGOTCH\t0x04134 /* Host Good Octets Transmit Count High */\n #define IGC_LENERRS\t0x04138 /* Length Errors Count */\n-#define IGC_SCVPC\t0x04228 /* SerDes/SGMII Code Violation Pkt Count */\n #define IGC_HRMPC\t0x0A018 /* Header Redirection Missed Packet Count */\n \n /* Management registers */\n", "prefixes": [ "1/1" ] }