Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1012,
    "url": "http://patchwork.ozlabs.org/api/patches/1012/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080922.221752.07789780.davem@davemloft.net/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080922.221752.07789780.davem@davemloft.net>",
    "list_archive_url": null,
    "date": "2008-09-23T05:17:52",
    "name": ": Fix bug in skb list splicing.",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "20b349d1fb34c23eefbe9befb614beab0cba9da7",
    "submitter": {
        "id": 15,
        "url": "http://patchwork.ozlabs.org/api/people/15/?format=api",
        "name": "David Miller",
        "email": "davem@davemloft.net"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080922.221752.07789780.davem@davemloft.net/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1012/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1012/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id D6543DDEFD\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 15:18:11 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751395AbYIWFSH (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 23 Sep 2008 01:18:07 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1751302AbYIWFSG\n\t(ORCPT <rfc822; netdev-outgoing>); Tue, 23 Sep 2008 01:18:06 -0400",
            "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:56853\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751005AbYIWFSE (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 23 Sep 2008 01:18:04 -0400",
            "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 5CE1AC8C181\n\tfor <netdev@vger.kernel.org>; Mon, 22 Sep 2008 22:17:52 -0700 (PDT)"
        ],
        "Date": "Mon, 22 Sep 2008 22:17:52 -0700 (PDT)",
        "Message-Id": "<20080922.221752.07789780.davem@davemloft.net>",
        "To": "netdev@vger.kernel.org",
        "Subject": "[PATCH]: Fix bug in skb list splicing.",
        "From": "David Miller <davem@davemloft.net>",
        "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)",
        "Mime-Version": "1.0",
        "Content-Type": "Text/Plain; charset=us-ascii",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "We don't update the qlen correctly when 'head' is\nnon-empty.\n\nnet: Fix bus in SKB queue splicing interfaces.\n\nHandle the case of head being non-empty, by adding list->qlen\nto head->qlen instead of using direct assignment.\n\nSigned-off-by: David S. Miller <davem@davemloft.net>\n---\n include/linux/skbuff.h |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h\nindex 027b061..4a144e8 100644\n--- a/include/linux/skbuff.h\n+++ b/include/linux/skbuff.h\n@@ -738,7 +738,7 @@ static inline void skb_queue_splice(const struct sk_buff_head *list,\n {\n \tif (!skb_queue_empty(list)) {\n \t\t__skb_queue_splice(list, (struct sk_buff *) head, head->next);\n-\t\thead->qlen = list->qlen;\n+\t\thead->qlen += list->qlen;\n \t}\n }\n \n@@ -754,7 +754,7 @@ static inline void skb_queue_splice_init(struct sk_buff_head *list,\n {\n \tif (!skb_queue_empty(list)) {\n \t\t__skb_queue_splice(list, (struct sk_buff *) head, head->next);\n-\t\thead->qlen = list->qlen;\n+\t\thead->qlen += list->qlen;\n \t\t__skb_queue_head_init(list);\n \t}\n }\n@@ -769,7 +769,7 @@ static inline void skb_queue_splice_tail(const struct sk_buff_head *list,\n {\n \tif (!skb_queue_empty(list)) {\n \t\t__skb_queue_splice(list, head->prev, (struct sk_buff *) head);\n-\t\thead->qlen = list->qlen;\n+\t\thead->qlen += list->qlen;\n \t}\n }\n \n@@ -786,7 +786,7 @@ static inline void skb_queue_splice_tail_init(struct sk_buff_head *list,\n {\n \tif (!skb_queue_empty(list)) {\n \t\t__skb_queue_splice(list, head->prev, (struct sk_buff *) head);\n-\t\thead->qlen = list->qlen;\n+\t\thead->qlen += list->qlen;\n \t\t__skb_queue_head_init(list);\n \t}\n }\n",
    "prefixes": []
}