Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1010,
    "url": "http://patchwork.ozlabs.org/api/patches/1010/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080922.201943.05384322.davem@davemloft.net/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20080922.201943.05384322.davem@davemloft.net>",
    "list_archive_url": null,
    "date": "2008-09-23T03:19:43",
    "name": ": Use skb_queue_walk_safe() in usbnet.",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ba93485a9517af6c6b9c36445e16f8e79309e91b",
    "submitter": {
        "id": 15,
        "url": "http://patchwork.ozlabs.org/api/people/15/?format=api",
        "name": "David Miller",
        "email": "davem@davemloft.net"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080922.201943.05384322.davem@davemloft.net/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/1010/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/1010/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 1CA5CDDE06\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 23 Sep 2008 13:20:00 +1000 (EST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754530AbYIWDT4 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 22 Sep 2008 23:19:56 -0400",
            "(majordomo@vger.kernel.org) by vger.kernel.org id S1754524AbYIWDT4\n\t(ORCPT <rfc822; netdev-outgoing>); Mon, 22 Sep 2008 23:19:56 -0400",
            "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:38985\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1754497AbYIWDTz (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 22 Sep 2008 23:19:55 -0400",
            "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 07D02C8C185\n\tfor <netdev@vger.kernel.org>; Mon, 22 Sep 2008 20:19:44 -0700 (PDT)"
        ],
        "Date": "Mon, 22 Sep 2008 20:19:43 -0700 (PDT)",
        "Message-Id": "<20080922.201943.05384322.davem@davemloft.net>",
        "To": "netdev@vger.kernel.org",
        "Subject": "[PATCH]: Use skb_queue_walk_safe() in usbnet.",
        "From": "David Miller <davem@davemloft.net>",
        "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)",
        "Mime-Version": "1.0",
        "Content-Type": "Text/Plain; charset=us-ascii",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "More work towards making sk_buff list_head transition easier.\n\nusbnet: Use skb_queue_walk_safe() instead of by-hand implementation.\n\nSigned-off-by: David S. Miller <davem@davemloft.net>\n---\n drivers/net/usb/usbnet.c |    3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c\nindex 8463efb..02d25c7 100644\n--- a/drivers/net/usb/usbnet.c\n+++ b/drivers/net/usb/usbnet.c\n@@ -512,14 +512,13 @@ static int unlink_urbs (struct usbnet *dev, struct sk_buff_head *q)\n \tint\t\t\tcount = 0;\n \n \tspin_lock_irqsave (&q->lock, flags);\n-\tfor (skb = q->next; skb != (struct sk_buff *) q; skb = skbnext) {\n+\tskb_queue_walk_safe(q, skb, skbnext) {\n \t\tstruct skb_data\t\t*entry;\n \t\tstruct urb\t\t*urb;\n \t\tint\t\t\tretval;\n \n \t\tentry = (struct skb_data *) skb->cb;\n \t\turb = entry->urb;\n-\t\tskbnext = skb->next;\n \n \t\t// during some PM-driven resume scenarios,\n \t\t// these (async) unlinks complete immediately\n",
    "prefixes": []
}