Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1008876/?format=api
{ "id": 1008876, "url": "http://patchwork.ozlabs.org/api/patches/1008876/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181206154955.334-3-stephend@silicom-usa.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181206154955.334-3-stephend@silicom-usa.com>", "list_archive_url": null, "date": "2018-12-06T15:50:43", "name": "[net-next,v5,2/2] ixgbe: use mii_bus to handle MII related ioctls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2e924f15588cd13e0765f928b7c0a148d75834eb", "submitter": { "id": 73588, "url": "http://patchwork.ozlabs.org/api/people/73588/?format=api", "name": "Stephen Douthit", "email": "stephend@silicom-usa.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181206154955.334-3-stephend@silicom-usa.com/mbox/", "series": [ { "id": 80189, "url": "http://patchwork.ozlabs.org/api/series/80189/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=80189", "date": "2018-12-06T15:50:39", "name": "[net-next,v5,1/2] ixgbe: register a mdiobus", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/80189/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1008876/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1008876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=silicom-usa.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=SILICOMLTD.onmicrosoft.com\n\theader.i=@SILICOMLTD.onmicrosoft.com header.b=\"kAQM1/t9\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=stephend@silicom-usa.com; " ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 439g7F1qm8z9s0t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 7 Dec 2018 02:51:04 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6B7FB8807C;\n\tThu, 6 Dec 2018 15:51:03 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zxIAQEmg7H1E; Thu, 6 Dec 2018 15:50:58 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EFC9C88048;\n\tThu, 6 Dec 2018 15:50:58 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BDD2C1BF40F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Dec 2018 15:50:57 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B9BBB87915\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Dec 2018 15:50:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yoeSC7iJ3Eir for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Dec 2018 15:50:53 +0000 (UTC)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30107.outbound.protection.outlook.com [40.107.3.107])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 1E80B878C9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 6 Dec 2018 15:50:52 +0000 (UTC)", "from VI1PR0402MB3853.eurprd04.prod.outlook.com (52.134.16.149) by\n\tVI1PR0402MB3455.eurprd04.prod.outlook.com (52.134.3.147) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1382.22; Thu, 6 Dec 2018 15:50:43 +0000", "from VI1PR0402MB3853.eurprd04.prod.outlook.com\n\t([fe80::457b:1a37:563c:a718]) by\n\tVI1PR0402MB3853.eurprd04.prod.outlook.com\n\t([fe80::457b:1a37:563c:a718%5]) with mapi id 15.20.1404.021;\n\tThu, 6 Dec 2018 15:50:43 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=SILICOMLTD.onmicrosoft.com; s=selector1-silicomusa-com01i;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=0Y7QFWce1vImFsuSWir8hvt6JT6lTQVhd9AVGy1X+sk=;\n\tb=kAQM1/t9qqJht8deLYkVzCYWjTW3HgQm9YccE4fUrOSSY7DhPlwYOIF+COFlaovKKVuOM5PxXmHXUGSln3HewziqYj/zoiosmQWo4P2m4EIvHlfkuj+6MCbvPZ6a+6uFNUd+jEU8Kw0b6t506nT8qLA5zA/55RY/oVnHxZ30goc=", "From": "Steve Douthit <stephend@silicom-usa.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Thread-Topic": "[PATCH net-next v5 2/2] ixgbe: use mii_bus to handle MII\n\trelated ioctls", "Thread-Index": "AQHUjXtyPS8uFLeWdkSlPQIHb6cYCQ==", "Date": "Thu, 6 Dec 2018 15:50:43 +0000", "Message-ID": "<20181206154955.334-3-stephend@silicom-usa.com>", "References": "<20181203163227.5107-1-stephend@silicom-usa.com>\n\t<20181206154955.334-1-stephend@silicom-usa.com>", "In-Reply-To": "<20181206154955.334-1-stephend@silicom-usa.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BL0PR02CA0037.namprd02.prod.outlook.com\n\t(2603:10b6:207:3d::14) To VI1PR0402MB3853.eurprd04.prod.outlook.com\n\t(2603:10a6:803:21::21)", "authentication-results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=silicom-usa.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=SILICOMLTD.onmicrosoft.com\n\theader.i=@SILICOMLTD.onmicrosoft.com header.b=\"kAQM1/t9\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=stephend@silicom-usa.com; " ], "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[96.82.2.57]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR0402MB3455;\n\t6:kBfNtI7l1HZTUP6xTxxxOE5g+ZgrzB0kIIFH0OLwf4JIVFW/76ZYKJc4cyRKKZfekaZcYdiALIcWmEElh2npAYXAvqDYMYhRGPkmegHuD2qto4wFjeGbKoA8FqRSo+KL8xkaEHIlnRSlLY7GNgubcEngg81zI/9n7Ljr+JAaRpvZnV3LoQUJfkdaTST1wzqT4VW5j3AFOelweJkDcivVeRrGWH74RLiiE0d4lPGPy9JtZGYGfl73IvqHLKjrbfMLk1TRYLLXvd90doEtPSbBL9O5VmATSi6wp9bddTAkWlvGa1kl+xkkkPVE+MKGRTlkmpf1OapSAbXwT2VOTmQqvJQ1URV9QiZ71g/oEFgJ1yWu2AKtYMXp6R42bgNwyzVJl6nW5bYZ2BH6lgztsta6e3VjLNxxeQXqMsLE9mYA++6KD4CKLB75FUJpQfyMgND4GVHl+kmZ9wEa1ETSUmz59Q==;\n\t5:BCD6ZZQz+RQ9Qbjq3ZpW4jIkIqF/UIBImrvhiZuYvXDIA9UoKtaLkvnOpYZnmJQwU0Kykn5WeU3o1IMKH+Uu9uhXaL+rEZVr2uF7HbPshLMZditM/V17TfI4zfXn5yiIFgU7vxA1y85zSE72tbjN3hyE6uiWry+6pwvPAxSwiRM=;\n\t7:GhW5Gz+gvZqMKzfH73JjyAAM6uGyyIVZFnlEVeUenjDip+EouoO7XJuLSpkEjkw4FxOmM7yUBN9xAXT/y5cyV9v16Z8TUPlPFUoOlSqFYIcB5ubEKnpKGUYTEXz1skKB0YDuooQP0cg/53Xi72HGUA==", "x-ms-office365-filtering-correlation-id": "a63cf2d1-c158-4341-081b-08d65b929472", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0402MB3455; ", "x-ms-traffictypediagnostic": "VI1PR0402MB3455:", "x-microsoft-antispam-prvs": "<VI1PR0402MB34552CF0DA850F7CC1BA516494A90@VI1PR0402MB3455.eurprd04.prod.outlook.com>", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231455)(999002)(944501520)(52105112)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201708071742011)(7699051)(76991095);\n\tSRVR:VI1PR0402MB3455; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB3455; ", "x-forefront-prvs": "087894CD3C", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10019020)(39850400004)(396003)(136003)(376002)(346002)(366004)(199004)(189003)(486006)(14444005)(7736002)(5660300001)(2616005)(66066001)(476003)(256004)(81156014)(8676002)(54906003)(305945005)(446003)(97736004)(81166006)(316002)(8936002)(106356001)(11346002)(68736007)(107886003)(4326008)(86362001)(99286004)(105586002)(76176011)(52116002)(3846002)(6116002)(1076002)(186003)(478600001)(102836004)(39060400002)(6506007)(26005)(36756003)(6512007)(2906002)(6486002)(14454004)(6916009)(25786009)(53936002)(386003)(71190400001)(6436002)(71200400001)(42262002);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0402MB3455;\n\tH:VI1PR0402MB3853.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: silicom-usa.com does not\n\tdesignate permitted sender hosts)", "x-microsoft-antispam-message-info": "0p+gXQnNzFSApRvEcK8qU9wEDhzqa4hQi41S2uzyVetWNf+ebqBcNQdKuVxR0NkKiln8vVf9c3kRHD3m4hBNrz3uG/FKuCglwGcprkZUqCzXxocYYOmaryWaq1H7ZaYL7fD3hqfAotWWogu6nTu5sf8yLcveMIfqZw/RyulJ8MyTEJ26Rnu58vRERgBw7J81cprNzsSkKIMnA22aea/tXl1nx4HQMWd5X73lOddBkitjBPXde2LC5VLT5tvI9dUD181bWuLcpfqWl6zFQhGGH49uKzAEt/OoYPXrJ8ZjJ/ixo62iDYtEBKrylnYCBTkqqJDJDETs6nquytQ47//v+2jmwTVLvw8zJMrnEN8fTlE=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "MIME-Version": "1.0", "X-OriginatorOrg": "silicom-usa.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "a63cf2d1-c158-4341-081b-08d65b929472", "X-MS-Exchange-CrossTenant-originalarrivaltime": "06 Dec 2018 15:50:43.5949\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0402MB3455", "Subject": "[Intel-wired-lan] [PATCH net-next v5 2/2] ixgbe: use mii_bus to\n\thandle MII related ioctls", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>,\n\t\"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Use the mii_bus callbacks to address the entire clause 22/45 address\nspace. Enables userspace to poke switch registers instead of a single\nPHY address.\n\nThe ixgbe firmware may be polling PHYs in a way that is not protected by\nthe mii_bus lock. This isn't new behavior, but as Andrew Lunn pointed\nout there are more addresses available for conflicts.\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\nReviewed-by: Andrew Lunn <andrew@lunn.ch>\nReviewed-by: Florian Fainelli <f.fainelli@gmail.com>\nTested-by: Andrew Bowers <andrewx.bowers@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex b7907674c565..caa64afdedfb 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8790,6 +8790,15 @@ ixgbe_mdio_read(struct net_device *netdev, int prtad, int devad, u16 addr)\n \tu16 value;\n \tint rc;\n \n+\tif (adapter->mii_bus) {\n+\t\tint regnum = addr;\n+\n+\t\tif (devad != MDIO_DEVAD_NONE)\n+\t\t\tregnum |= (devad << 16) | MII_ADDR_C45;\n+\n+\t\treturn mdiobus_read(adapter->mii_bus, prtad, regnum);\n+\t}\n+\n \tif (prtad != hw->phy.mdio.prtad)\n \t\treturn -EINVAL;\n \trc = hw->phy.ops.read_reg(hw, addr, devad, &value);\n@@ -8804,6 +8813,15 @@ static int ixgbe_mdio_write(struct net_device *netdev, int prtad, int devad,\n \tstruct ixgbe_adapter *adapter = netdev_priv(netdev);\n \tstruct ixgbe_hw *hw = &adapter->hw;\n \n+\tif (adapter->mii_bus) {\n+\t\tint regnum = addr;\n+\n+\t\tif (devad != MDIO_DEVAD_NONE)\n+\t\t\tregnum |= (devad << 16) | MII_ADDR_C45;\n+\n+\t\treturn mdiobus_write(adapter->mii_bus, prtad, regnum, value);\n+\t}\n+\n \tif (prtad != hw->phy.mdio.prtad)\n \t\treturn -EINVAL;\n \treturn hw->phy.ops.write_reg(hw, addr, devad, value);\n", "prefixes": [ "net-next", "v5", "2/2" ] }