Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1007660/?format=api
{ "id": 1007660, "url": "http://patchwork.ozlabs.org/api/patches/1007660/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181204141852.13893-1-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181204141852.13893-1-sassmann@kpanic.de>", "list_archive_url": null, "date": "2018-12-04T14:18:52", "name": "i40e: fix mac filter delete when setting mac address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5b4d3ee097f3924605518c9c90a36e7595fc77ac", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181204141852.13893-1-sassmann@kpanic.de/mbox/", "series": [ { "id": 79684, "url": "http://patchwork.ozlabs.org/api/series/79684/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=79684", "date": "2018-12-04T14:18:52", "name": "i40e: fix mac filter delete when setting mac address", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/79684/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1007660/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1007660/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kpanic.de" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 438PMX3TTWz9s3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 5 Dec 2018 01:27:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DA84D86475;\n\tTue, 4 Dec 2018 14:27:16 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id QqEPNRURtElT; Tue, 4 Dec 2018 14:27:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4ADDC863F2;\n\tTue, 4 Dec 2018 14:27:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 474071C2D5C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Dec 2018 14:27:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 43A1E87D0E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Dec 2018 14:27:15 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PeJ4iTRhIJvS for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Dec 2018 14:27:14 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id A845987C9F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 4 Dec 2018 14:27:14 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C538D308FB85;\n\tTue, 4 Dec 2018 14:19:06 +0000 (UTC)", "from p50.redhat.com (ovpn-117-2.ams2.redhat.com [10.36.117.2])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3F4205C21C;\n\tTue, 4 Dec 2018 14:19:04 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "delayed 00:08:07 by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.43]); Tue, 04 Dec 2018 14:19:06 +0000 (UTC)" ], "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 4 Dec 2018 15:18:52 +0100", "Message-Id": "<20181204141852.13893-1-sassmann@kpanic.de>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Subject": "[Intel-wired-lan] [PATCH] i40e: fix mac filter delete when setting\n\tmac address", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "A previous commit moved the ether_addr_copy() in i40e_set_mac() before\nthe mac filter del/add to avoid a race. However it wasn't taken into\naccount that this alters the mac address being handed to\ni40e_del_mac_filter().\n\nAlso changed i40e_add_mac_filter() to operate on netdev->dev_addr,\nhopefully that makes the code easier to read.\n\nFixes: 458867b2ca0c (\"i40e: don't remove netdev->dev_addr when syncing uc list\")\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 6d5b13f69dec..901ef799d2ad 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1546,17 +1546,17 @@ static int i40e_set_mac(struct net_device *netdev, void *p)\n \t\tnetdev_info(netdev, \"set new mac address %pM\\n\", addr->sa_data);\n \n \t/* Copy the address first, so that we avoid a possible race with\n-\t * .set_rx_mode(). If we copy after changing the address in the filter\n-\t * list, we might open ourselves to a narrow race window where\n-\t * .set_rx_mode could delete our dev_addr filter and prevent traffic\n-\t * from passing.\n+\t * .set_rx_mode().\n+\t * - Remove old address from MAC filter\n+\t * - Copy new address\n+\t * - Add new address to MAC filter\n \t */\n-\tether_addr_copy(netdev->dev_addr, addr->sa_data);\n-\n \tspin_lock_bh(&vsi->mac_filter_hash_lock);\n \ti40e_del_mac_filter(vsi, netdev->dev_addr);\n-\ti40e_add_mac_filter(vsi, addr->sa_data);\n+\tether_addr_copy(netdev->dev_addr, addr->sa_data);\n+\ti40e_add_mac_filter(vsi, netdev->dev_addr);\n \tspin_unlock_bh(&vsi->mac_filter_hash_lock);\n+\n \tif (vsi->type == I40E_VSI_MAIN) {\n \t\ti40e_status ret;\n \n", "prefixes": [] }