Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1007192/?format=api
{ "id": 1007192, "url": "http://patchwork.ozlabs.org/api/patches/1007192/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181203201432.18252-3-stephend@silicom-usa.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181203201432.18252-3-stephend@silicom-usa.com>", "list_archive_url": null, "date": "2018-12-03T20:15:24", "name": "[net-next,v4,2/2] ixgbe: use mii_bus to handle MII related ioctls", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "2e924f15588cd13e0765f928b7c0a148d75834eb", "submitter": { "id": 73588, "url": "http://patchwork.ozlabs.org/api/people/73588/?format=api", "name": "Stephen Douthit", "email": "stephend@silicom-usa.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181203201432.18252-3-stephend@silicom-usa.com/mbox/", "series": [ { "id": 79530, "url": "http://patchwork.ozlabs.org/api/series/79530/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=79530", "date": "2018-12-03T20:15:18", "name": "Add mii_bus to ixgbe driver for dsa devs", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/79530/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1007192/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1007192/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=silicom-usa.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=SILICOMLTD.onmicrosoft.com\n\theader.i=@SILICOMLTD.onmicrosoft.com header.b=\"eQUKrjuZ\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=stephend@silicom-usa.com; " ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 437xTv54hfz9sBZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 4 Dec 2018 07:31:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 54B5225D14;\n\tMon, 3 Dec 2018 20:31:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hYzV0IZV+5vw; Mon, 3 Dec 2018 20:31:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 55B0A20799;\n\tMon, 3 Dec 2018 20:31:13 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 69A481BF2A2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 20:31:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6634B85475\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 20:31:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ClTgu0J67O22 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 20:31:10 +0000 (UTC)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30129.outbound.protection.outlook.com [40.107.3.129])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id AB361852ED\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 20:31:09 +0000 (UTC)", "from VI1PR0402MB3853.eurprd04.prod.outlook.com (52.134.16.149) by\n\tVI1PR0402MB3454.eurprd04.prod.outlook.com (52.134.3.146) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1382.22; Mon, 3 Dec 2018 20:15:26 +0000", "from VI1PR0402MB3853.eurprd04.prod.outlook.com\n\t([fe80::457b:1a37:563c:a718]) by\n\tVI1PR0402MB3853.eurprd04.prod.outlook.com\n\t([fe80::457b:1a37:563c:a718%5]) with mapi id 15.20.1382.020;\n\tMon, 3 Dec 2018 20:15:26 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=SILICOMLTD.onmicrosoft.com; s=selector1-silicomusa-com01i;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=5Nd8BijEMOb9lGv89zrRqj4HV8Dg4mUwKJDU0+SFPm8=;\n\tb=eQUKrjuZ9ywH/2oXUCWtQ5v5FKCiSgNtryLZBqioZL6APAdMrS8jKUQfVgG2SkaefAs3ZNXTCuoon84PPyOR+DKIqXgBeVmK99LZse/aEjib6Bak6zGXhPmNmGi1VVLlRgBV2cwS/2+iI6rlVrDr3D0Ne4WwcLdWwAtXUzv0VXI=", "From": "Steve Douthit <stephend@silicom-usa.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Thread-Topic": "[PATCH net-next v4 2/2] ixgbe: use mii_bus to handle MII\n\trelated ioctls", "Thread-Index": "AQHUi0TsNfDr7lmJ80S6oLPWLPkjCA==", "Date": "Mon, 3 Dec 2018 20:15:24 +0000", "Message-ID": "<20181203201432.18252-3-stephend@silicom-usa.com>", "References": "<20181203163227.5107-1-stephend@silicom-usa.com>\n\t<20181203201432.18252-1-stephend@silicom-usa.com>", "In-Reply-To": "<20181203201432.18252-1-stephend@silicom-usa.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BN6PR21CA0010.namprd21.prod.outlook.com\n\t(2603:10b6:404:8e::20) To VI1PR0402MB3853.eurprd04.prod.outlook.com\n\t(2603:10a6:803:21::21)", "authentication-results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=silicom-usa.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=SILICOMLTD.onmicrosoft.com\n\theader.i=@SILICOMLTD.onmicrosoft.com header.b=\"eQUKrjuZ\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=stephend@silicom-usa.com; " ], "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[96.82.2.57]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR0402MB3454;\n\t6:2vlC1mRTiX/0uTdHTB75YOzDUdwLjPP4ZGgT86cfHorrXnfRHcjTgDDtLIHWVEdOncmRvaVlukjCMaLejOu81Mlx0fCzwGiAYpOsZ/I/oVGN81ylXsGDgBbRXWdwAHpFaoev7ML4NrNMZSsK/xMpFQVVcxYaTQmF4hVp741T8yPKSQinhOZkkDEq3F2gcLWj4KsWoi7Dxw7kgWDt/bTDzqhOoq1ETMfyRUnzL+wkQctkOCIgIxA/CiMZdwLZXW7D+0m5H5Cphc8RrI3MOJI2aFdx8TEftjvXYeP6lDYuJn0Xh2d8TeBIjuqcIe5kwaG5nW3lazirrTqkJ2poJ1jo70WJeHhLlgDeY3R8UriVYH2gX6J6cVrt+0RPTLD7wxZ5fLF4SEZZYj+nYegz0gz4x1jjC88M6CFIQvwfTr3xJ4eyyt0iOAs9AAgs+IDZKevbxR8nmcb5wLZ/rA7fgCdYPw==;\n\t5:p+piStoBR2gR5YaFrtWdMwJhGyh62hL+4838X/ZL/LndKMef5f57Sgq7hrKki71iKzOi4h3+RyTytND8hwCzJkoqGseF/QeGb1j3iXx/xdtO4vpH3B4iRUhaxo5m0CuZAZyr9MqfJVq3wQSFhGBPD/pCABid7w505uT+dZMi39g=;\n\t7:z5rRdInUfZ7NClspM7zN5hFdNBsPMQb1EkkrZFgIQMrA4QBhOmQi2KkO1KLAL4RELnUvhTmogB3KQvNAFSy9tK3BsGherBr/RPViGUPRWI9A4IvzahbxBRiQ0jo4lnbYut5xlNUk6YAcOHTyWMXcWA==", "x-ms-office365-filtering-correlation-id": "675683c9-7e38-459f-a894-08d6595c0ee6", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0402MB3454; ", "x-ms-traffictypediagnostic": "VI1PR0402MB3454:", "x-microsoft-antispam-prvs": "<VI1PR0402MB34549202D6FA057462FD0E5994AE0@VI1PR0402MB3454.eurprd04.prod.outlook.com>", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231455)(999002)(944501493)(52105112)(93006095)(93001095)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095);\n\tSRVR:VI1PR0402MB3454; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB3454; ", "x-forefront-prvs": "08756AC3C8", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10019020)(346002)(376002)(136003)(39850400004)(396003)(366004)(199004)(189003)(105586002)(71200400001)(106356001)(478600001)(14444005)(97736004)(66066001)(68736007)(14454004)(6116002)(3846002)(99286004)(1076002)(2906002)(71190400001)(8676002)(81156014)(8936002)(256004)(86362001)(6916009)(81166006)(6512007)(53936002)(76176011)(39060400002)(186003)(4326008)(26005)(107886003)(52116002)(102836004)(316002)(54906003)(446003)(7736002)(305945005)(25786009)(386003)(6506007)(6486002)(5660300001)(6436002)(486006)(11346002)(2616005)(476003)(36756003)(42262002);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0402MB3454;\n\tH:VI1PR0402MB3853.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: silicom-usa.com does not\n\tdesignate permitted sender hosts)", "x-microsoft-antispam-message-info": "2wIIaRbErc5bWeEzg1/nLpPggA8YyY0VdWjgEnvwEIMz83HnhjOWFhpChhPJdgLfDJ0x0f47prd7RWt5cZGD/6nKBaJBjZHbacSTcmDmOyasLwEwl2cha1sK3QkwK/4GjNJNEymGmBseIiqWMzBQpGpupDAO+fDqMA7Tl+eCb408fLtDQEexFzDtm7kKyTqQ5er0CVEVBSrRN5zIdk1wH4yKQnhGmi4bVUllF8xO5nFXnV3n0+jPwtZmp5O+EOz9rpLMsqcsJNGl6Py5wFqdR9i6i4+Jn0Oj7gj2lPy9ygCT8iJCI25zANJ3fiJSEQfMxD10poeTA7v58BuFe1cKI+gR0a6XPmYzuDlQkGJwUhk=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "MIME-Version": "1.0", "X-OriginatorOrg": "silicom-usa.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "675683c9-7e38-459f-a894-08d6595c0ee6", "X-MS-Exchange-CrossTenant-originalarrivaltime": "03 Dec 2018 20:15:24.3376\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0402MB3454", "Subject": "[Intel-wired-lan] [PATCH net-next v4 2/2] ixgbe: use mii_bus to\n\thandle MII related ioctls", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>,\n\t\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>,\n\t\"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Use the mii_bus callbacks to address the entire clause 22/45 address\nspace. Enables userspace to poke switch registers instead of a single\nPHY address.\n\nThe ixgbe firmware may be polling PHYs in a way that is not protected by\nthe mii_bus lock. This isn't new behavior, but as Andrew Lunn pointed\nout there are more addresses available for conflicts.\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\nReviewed-by: Andrew Lunn <andrew@lunn.ch>\nReviewed-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex b7907674c565..caa64afdedfb 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8790,6 +8790,15 @@ ixgbe_mdio_read(struct net_device *netdev, int prtad, int devad, u16 addr)\n \tu16 value;\n \tint rc;\n \n+\tif (adapter->mii_bus) {\n+\t\tint regnum = addr;\n+\n+\t\tif (devad != MDIO_DEVAD_NONE)\n+\t\t\tregnum |= (devad << 16) | MII_ADDR_C45;\n+\n+\t\treturn mdiobus_read(adapter->mii_bus, prtad, regnum);\n+\t}\n+\n \tif (prtad != hw->phy.mdio.prtad)\n \t\treturn -EINVAL;\n \trc = hw->phy.ops.read_reg(hw, addr, devad, &value);\n@@ -8804,6 +8813,15 @@ static int ixgbe_mdio_write(struct net_device *netdev, int prtad, int devad,\n \tstruct ixgbe_adapter *adapter = netdev_priv(netdev);\n \tstruct ixgbe_hw *hw = &adapter->hw;\n \n+\tif (adapter->mii_bus) {\n+\t\tint regnum = addr;\n+\n+\t\tif (devad != MDIO_DEVAD_NONE)\n+\t\t\tregnum |= (devad << 16) | MII_ADDR_C45;\n+\n+\t\treturn mdiobus_write(adapter->mii_bus, prtad, regnum, value);\n+\t}\n+\n \tif (prtad != hw->phy.mdio.prtad)\n \t\treturn -EINVAL;\n \treturn hw->phy.ops.write_reg(hw, addr, devad, value);\n", "prefixes": [ "net-next", "v4", "2/2" ] }