Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1006665/?format=api
{ "id": 1006665, "url": "http://patchwork.ozlabs.org/api/patches/1006665/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181203055438.363-1-kai.heng.feng@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181203055438.363-1-kai.heng.feng@canonical.com>", "list_archive_url": null, "date": "2018-12-03T05:54:38", "name": "igb: Fix an issue that PME is not enabled during runtime suspend", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4bc292c1c7b22cac9c0cd952233ad10697aa7f2a", "submitter": { "id": 70328, "url": "http://patchwork.ozlabs.org/api/people/70328/?format=api", "name": "Kai-Heng Feng", "email": "kai.heng.feng@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181203055438.363-1-kai.heng.feng@canonical.com/mbox/", "series": [ { "id": 79317, "url": "http://patchwork.ozlabs.org/api/series/79317/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=79317", "date": "2018-12-03T05:54:38", "name": "igb: Fix an issue that PME is not enabled during runtime suspend", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/79317/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1006665/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1006665/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 437Z2l6xyqz9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 3 Dec 2018 16:54:54 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 90CC18522E;\n\tMon, 3 Dec 2018 05:54:52 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DxGv2Iu-BfcH; Mon, 3 Dec 2018 05:54:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E3452850C5;\n\tMon, 3 Dec 2018 05:54:51 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7B4D81C1FF7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 05:54:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 77EDF86AF4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 05:54:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1BCeUjfrJRNE for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 05:54:50 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 3419686AB1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 3 Dec 2018 05:54:50 +0000 (UTC)", "from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37]\n\thelo=localhost) by youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <kai.heng.feng@canonical.com>)\n\tid 1gThBs-0004y2-Jz; Mon, 03 Dec 2018 05:54:45 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Kai-Heng Feng <kai.heng.feng@canonical.com>", "To": "jeffrey.t.kirsher@intel.com", "Date": "Mon, 3 Dec 2018 13:54:38 +0800", "Message-Id": "<20181203055438.363-1-kai.heng.feng@canonical.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[Intel-wired-lan] [PATCH] igb: Fix an issue that PME is not enabled\n\tduring runtime suspend", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Kai-Heng Feng <kai.heng.feng@canonical.com>,\n\tintel-wired-lan@lists.osuosl.org, davem@davemloft.net,\n\tlinux-kernel@vger.kernel.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "I210 ethernet card doesn't wakeup when a cable gets plugged. It's\nbecause its PME is not set.\n\nSince commit 42eca2302146 (\"PCI: Don't touch card regs after runtime\nsuspend D3\"), if the PCI state is saved, pci_pm_runtime_suspend() stops\ncalling pci_finish_runtime_suspend(), which enables the PCI PME.\n\nTo fix the issue, let's not to save PCI states when it's runtime\nsuspend, to let the PCI subsytem enables PME.\n\nFixes: 42eca2302146 (\"PCI: Don't touch card regs after runtime suspend D3\")\nSigned-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 5df88ad8ac81..93f150784cfc 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -8770,9 +8770,11 @@ static int __igb_shutdown(struct pci_dev *pdev, bool *enable_wake,\n \trtnl_unlock();\n \n #ifdef CONFIG_PM\n-\tretval = pci_save_state(pdev);\n-\tif (retval)\n-\t\treturn retval;\n+\tif (!runtime) {\n+\t\tretval = pci_save_state(pdev);\n+\t\tif (retval)\n+\t\t\treturn retval;\n+\t}\n #endif\n \n \tstatus = rd32(E1000_STATUS);\n", "prefixes": [] }