Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1005613/?format=api
{ "id": 1005613, "url": "http://patchwork.ozlabs.org/api/patches/1005613/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181129191507.12478-2-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181129191507.12478-2-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2018-11-29T19:15:07", "name": "[net-next,2/2] ixgbe: use mii_bus to handle MII related ioctls", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "af0aa6bbfe1f7eeff41c4af685e5321489b69366", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181129191507.12478-2-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 78890, "url": "http://patchwork.ozlabs.org/api/series/78890/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=78890", "date": "2018-11-29T19:15:07", "name": "[net-next,1/2] ixgbe: register a mdiobus", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/78890/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1005613/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1005613/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 435S03532jz9s8r\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 30 Nov 2018 06:15:14 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B9A0D884DE;\n\tThu, 29 Nov 2018 19:15:12 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UHDb1tat3n8k; Thu, 29 Nov 2018 19:15:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4C29D884C1;\n\tThu, 29 Nov 2018 19:15:12 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2FE271C2E33\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 19:15:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2CC5D2F8FD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 19:15:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VG71WV3VxeuX for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 19:15:10 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby silver.osuosl.org (Postfix) with ESMTPS id AD2DD2F7B4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 19:15:10 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Nov 2018 11:15:10 -0800", "from mrfrick-mobl1.amr.corp.intel.com (HELO\n\tjtkirshe-MOBL1.amr.corp.intel.com) ([10.251.13.151])\n\tby fmsmga001.fm.intel.com with ESMTP; 29 Nov 2018 11:15:10 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,295,1539673200\"; d=\"scan'208\";a=\"119039999\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 29 Nov 2018 11:15:07 -0800", "Message-Id": "<20181129191507.12478-2-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20181129191507.12478-1-jeffrey.t.kirsher@intel.com>", "References": "<20181129191507.12478-1-jeffrey.t.kirsher@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-next,\n\t2/2] ixgbe: use mii_bus to handle MII related ioctls", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Steve Douthit <stephend@silicom-usa.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Steve Douthit <stephend@silicom-usa.com>\n\nUse the mii_bus callbacks to address the entire clause 22/45 address\nspace. Enables userspace to poke switch registers instead of a single\nPHY address.\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 29 +++++++++----------\n 1 file changed, 14 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex c2141fe35685..345ecdddc749 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -8786,27 +8786,26 @@ static int\n ixgbe_mdio_read(struct net_device *netdev, int prtad, int devad, u16 addr)\n {\n \tstruct ixgbe_adapter *adapter = netdev_priv(netdev);\n-\tstruct ixgbe_hw *hw = &adapter->hw;\n-\tu16 value;\n-\tint rc;\n+\tstruct mii_bus *mii_bus = adapter->mii_bus;\n+\tint regnum = addr;\n \n-\tif (prtad != hw->phy.mdio.prtad)\n-\t\treturn -EINVAL;\n-\trc = hw->phy.ops.read_reg(hw, addr, devad, &value);\n-\tif (!rc)\n-\t\trc = value;\n-\treturn rc;\n+\tif (devad != MDIO_DEVAD_NONE)\n+\t\tregnum |= (devad << 16) | MII_ADDR_C45;\n+\n+\treturn mdiobus_read(mii_bus, prtad, regnum);\n }\n \n static int ixgbe_mdio_write(struct net_device *netdev, int prtad, int devad,\n \t\t\t u16 addr, u16 value)\n {\n \tstruct ixgbe_adapter *adapter = netdev_priv(netdev);\n-\tstruct ixgbe_hw *hw = &adapter->hw;\n+\tstruct mii_bus *mii_bus = adapter->mii_bus;\n+\tint regnum = addr;\n \n-\tif (prtad != hw->phy.mdio.prtad)\n-\t\treturn -EINVAL;\n-\treturn hw->phy.ops.write_reg(hw, addr, devad, value);\n+\tif (devad != MDIO_DEVAD_NONE)\n+\t\tregnum |= (devad << 16) | MII_ADDR_C45;\n+\n+\treturn mdiobus_write(mii_bus, prtad, regnum, value);\n }\n \n static int ixgbe_ioctl(struct net_device *netdev, struct ifreq *req, int cmd)\n@@ -8819,7 +8818,7 @@ static int ixgbe_ioctl(struct net_device *netdev, struct ifreq *req, int cmd)\n \tcase SIOCGHWTSTAMP:\n \t\treturn ixgbe_ptp_get_ts_config(adapter, req);\n \tcase SIOCGMIIPHY:\n-\t\tif (!adapter->hw.phy.ops.read_reg)\n+\t\tif (!adapter->mii_bus)\n \t\t\treturn -EOPNOTSUPP;\n \t\t/* fall through */\n \tdefault:\n@@ -10796,7 +10795,7 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t/* ixgbe_identify_phy_generic will set prtad and mmds properly */\n \thw->phy.mdio.prtad = MDIO_PRTAD_NONE;\n \thw->phy.mdio.mmds = 0;\n-\thw->phy.mdio.mode_support = MDIO_SUPPORTS_C45 | MDIO_EMULATE_C22;\n+\thw->phy.mdio.mode_support = MDIO_SUPPORTS_C45 | MDIO_SUPPORTS_C22;\n \thw->phy.mdio.dev = netdev;\n \thw->phy.mdio.mdio_read = ixgbe_mdio_read;\n \thw->phy.mdio.mdio_write = ixgbe_mdio_write;\n", "prefixes": [ "net-next", "2/2" ] }