Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1004978/?format=api
{ "id": 1004978, "url": "http://patchwork.ozlabs.org/api/patches/1004978/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/HK0PR01MB21630071FC7DAA5B3189A40EADD20@HK0PR01MB2163.apcprd01.prod.exchangelabs.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<HK0PR01MB21630071FC7DAA5B3189A40EADD20@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>", "list_archive_url": null, "date": "2018-11-29T01:54:10", "name": "intel: ice: Do not enable NAPI on q_vectors that have no rings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "72202feaf1421142dbab025ac30caaccef1b0c22", "submitter": { "id": 75435, "url": "http://patchwork.ozlabs.org/api/people/75435/?format=api", "name": "Yang Xiao", "email": "YangX92@hotmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/HK0PR01MB21630071FC7DAA5B3189A40EADD20@HK0PR01MB2163.apcprd01.prod.exchangelabs.com/mbox/", "series": [ { "id": 78684, "url": "http://patchwork.ozlabs.org/api/series/78684/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=78684", "date": "2018-11-29T01:54:10", "name": "intel: ice: Do not enable NAPI on q_vectors that have no rings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/78684/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1004978/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1004978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=hotmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=hotmail.com header.i=@hotmail.com\n\theader.b=\"rkW09LtD\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4350v20b21z9s3l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 29 Nov 2018 12:54:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1C1AC87D81;\n\tThu, 29 Nov 2018 01:54:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rZz-fl8WD91B; Thu, 29 Nov 2018 01:54:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5149987967;\n\tThu, 29 Nov 2018 01:54:18 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 981331BF32A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 01:54:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 93DEB876E1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 01:54:16 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ILHpas6vyoPP for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 01:54:15 +0000 (UTC)", "from APC01-SG2-obe.outbound.protection.outlook.com\n\t(mail-oln040092253058.outbound.protection.outlook.com [40.92.253.58])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id EB353816DE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 29 Nov 2018 01:54:14 +0000 (UTC)", "from HK2APC01FT064.eop-APC01.prod.protection.outlook.com\n\t(10.152.248.54) by\n\tHK2APC01HT090.eop-APC01.prod.protection.outlook.com\n\t(10.152.249.80) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.18;\n\tThu, 29 Nov 2018 01:54:10 +0000", "from HK0PR01MB2163.apcprd01.prod.exchangelabs.com (10.152.248.57)\n\tby HK2APC01FT064.mail.protection.outlook.com (10.152.249.108) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1382.18 via Frontend Transport; Thu, 29 Nov 2018 01:54:10 +0000", "from HK0PR01MB2163.apcprd01.prod.exchangelabs.com\n\t([fe80::198d:1315:c7f3:abdb]) by\n\tHK0PR01MB2163.apcprd01.prod.exchangelabs.com\n\t([fe80::198d:1315:c7f3:abdb%2]) with mapi id 15.20.1361.019;\n\tThu, 29 Nov 2018 01:54:10 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=msTgQyPR08TZnzMKrInAvVinIh8xpXNMak5bvCi8SxQ=;\n\tb=rkW09LtDGBhEzD6sVXtNpIltw8br3EkJh0NVPJnVxECYXU9ERN16hIWnBnHX9LN3//EfQOq1/2a8lfcHE8Jyj0yFLpuuBbV91q0WOIS3Pw20/iS08n6ACngoQq7ofYeYKvbtj+AvjP22zug9jaKMJNK/m/72MdgZMHY5eime5xuz7RLOkfbbkSWzYuwZh0ykmo3pm+0CaZkbkdEG8HEIqEHTptMytNmwjKy2xKnLdCv86J/Jhk4oxPyQ6dRlkGTT1reg9cBAhiGuN7xRez6YklIWS9kXpmO2PjhlC73tSiPJOu55Q9PlUPNClGQUVsFDV8bYpnqgzFDre2Rnf49STQ==", "From": "Yang Xiao <YangX92@hotmail.com>", "To": "\"jeffrey.t.kirsher@intel.com\" <jeffrey.t.kirsher@intel.com>,\n\t\"davem@davemloft.net\" <davem@davemloft.net>", "Thread-Topic": "[PATCH] intel: ice: Do not enable NAPI on q_vectors that have\n\tno rings", "Thread-Index": "AQHUh4ZrRZtdaAoolES4JHqgY0EqBg==", "Date": "Thu, 29 Nov 2018 01:54:10 +0000", "Message-ID": "<HK0PR01MB21630071FC7DAA5B3189A40EADD20@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HK2PR0302CA0009.apcprd03.prod.outlook.com\n\t(2603:1096:202::19) To HK0PR01MB2163.apcprd01.prod.exchangelabs.com\n\t(2603:1096:203:73::11)", "x-incomingtopheadermarker": "OriginalChecksum:E23822810BBC75CE11F6C56EB059F2EC1A31AA00C54048E558EE8005765F3C9E;\n\tUpperCasedChecksum:0CCFC4F90ED9C3E1188672869CB5094F6743F3CF9A0D1FBB7AFB8E315A946C43;\n\tSizeAsReceived:7568; Count:48", "x-ms-exchange-messagesentrepresentingtype": "1", "x-tmn": "[N17gei32/eyzQyv/kHS75B1XG8d/EldwDjQHksVxrfc=]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; HK2APC01HT090;\n\t6:c0Kqyn2llz9sEL6TgbGXM6jcDzaxvu7A2ohRJ7tbH0RTE4jw/nBKWa1JZVzlWXhb2Yt9xUmceR34bCTTyk6mEUgk9CRjX4BKEwpusui/H2q+J8Q7KX/4IWCsiCAizH6AR8Q+SHFqhmrbJFj1/VD2NXDC2MV7crRIRhPrwWg+KNT1HGKj0GaHi4AvLsN6L+5GSD2FrnmRWH1yCwuZP/ABkjNJno6M2OeBnyH2QWfM62A0uA2D0Gq1m0JRrTCQyYS8AJRh1N2eiUTnRVAUr2U6R/g08K3vZGIW/d1PYGlZxe5PYp97bR8fmBOOPLcJscdQQmDFqPS0cxdmaHPCkfchT2QzLIQAegdtKb6DjFnRjwWb5bPfS7gEv4ZKjnVjiCF3Zq75SjvCBUx9Wqw6cW+QSQo4puku1BbrH4OgY0K64CZ8Kr7U+3M+99tLuaAMaJcPMC9sCJnaAKhsutlBFOccKw==;\n\t5:C6ZwNunMVmNrJjawhwroPoNtPgsinTZvPtFhhKMUCo0DM2qARKh4xgZdFHfh59JoOniyDXucH/ua9fvg4KphNZ8V5yUF2lxcTn5q5LGNBMsduoiIMFTmgzvRaNTAI/GvKOfuwMyp/xU6rW8K7FIXHz07/0pqSE1fCxq/ZKSO7MM=;\n\t7:ne3VO5QAi8U98HJF2JCDSW+LsqbsVbWPmjw+DGeJVTTzmkGk4mdKsZr76p5LZeR8LMtz4P1OkLsPurNEan1EZ4Hnfkk3Bv2QOKZiUv2+VHYsZuzq3bA8NBDMqCLjnru8bfAObDydqQh2vacywBj5zA==", "x-incomingheadercount": "48", "x-eopattributedmessage": "0", "x-ms-exchange-slblob-mailprops": "mBRmoEB1kyKsMsSw1iF/gkRLMHgPg9MZ05UyurDPTLZinB8zFIDp8HMhQaq23pbHMh5CZoIIuGBi1yYXbQwzTx5ejlxhfi7bCQClalT9O27ybLfWP/NKyh57P2vmy6kWvDcfq0PZn9US626Q0+RGsDsTVb6QXYpzQMhoBIHN3Pq6KA79dwuba3uFycpOvnOagzME+fQk0sNVcYURgLtSmfkKf9X+JccgP3YpAdvray9rEW1TPqh2jsQvgvW6ELXC84f2NfdU3uhYgG4Sr+UlC1iTvzefQd6t8ZnKSRLVMQ8Q8tVKKqY7ZksrB4fOx+VG4x+26YwFPjbVqsxKY53W/tIJCnHROIv/cDPb5seMMuua6Mnplv57gvgPNuMSz46S3FZGUPZ/aVoMqRyhKAq9fGBC+QcyJh0CAqEstf9hmH9uK0f5mOJh+PKY/nRO/zpXkwC7w8SqUClav/87cYwP29LgNbovv0IeDF/JUGYywFkmBRvP0TMBCnjljlsJKVBgk/GBGFBIH4yE0Mk2nRptIUGFvIbm7kNn+qkPtRWFeSOvniTodCduYetvXTw/XFBdG/D/Eg+Vp89P+iAycQsBZT2zSQtoqCe5oTqq/9aT9NYBREGx4d+aL53NxKxzpaw/QTzjhf8KGTIp6n6RFkpKZFG2V1aH5UFNGu2FNoe7kbcSSXLPAnXrr9FDWPC0K4Yqr2r4h7d8jz/nIOHUYPiCb+OOgGecuntBckeM/OzM3lfV+Y03WB63MRG1sxYr/nduh9GcVLr0rMk=", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390098)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(201702181274)(2017031322404)(1603101475)(1601125500)(1701031045);\n\tSRVR:HK2APC01HT090; ", "x-ms-traffictypediagnostic": "HK2APC01HT090:", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0; RULEID:(4566010)(82015058);\n\tSRVR:HK2APC01HT090; BCL:0; PCL:0; RULEID:; SRVR:HK2APC01HT090; ", "x-microsoft-antispam-message-info": "8XoSn2E9zeq5fLXK+U9k8D94/i1O7+rkDqEyTItoKrT9+yJeP9IrQWPGFF8MDjuU", "MIME-Version": "1.0", "X-OriginatorOrg": "hotmail.com", "X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg": [ "c001924d-3e68-4f40-89c2-901a49278da7", "c001924d-3e68-4f40-89c2-901a49278da7" ], "X-MS-Exchange-CrossTenant-Network-Message-Id": "e6629740-f967-414c-9672-08d6559d8e41", "X-MS-Exchange-CrossTenant-rms-persistedconsumerorg": [ "c001924d-3e68-4f40-89c2-901a49278da7", "c001924d-3e68-4f40-89c2-901a49278da7" ], "X-MS-Exchange-CrossTenant-originalarrivaltime": "29 Nov 2018 01:54:10.7305\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Internet", "X-MS-Exchange-CrossTenant-id": "84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "HK2APC01HT090", "Subject": "[Intel-wired-lan] [PATCH] intel: ice: Do not enable NAPI on\n\tq_vectors that have no rings", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>,\n\tYang Xiao <YangX92@hotmail.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Young Xiao <YangX92@hotmail.com>\n\nIf ice driver has q_vectors w/ active NAPI that has no rings,\nthen this will result in a divide by zero error. To correct it\nI am updating the driver code so that we only support NAPI on\nq_vectors that have 1 or more rings allocated to them.\n\nSee commit 13a8cd191a2b (\"i40e: Do not enable NAPI on q_vectors\nthat have no rings\") for detail.\n\nSigned-off-by: Young Xiao <YangX92@hotmail.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 333312a..9450004 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -2563,8 +2563,12 @@ static void ice_napi_enable_all(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++)\n-\t\tnapi_enable(&vsi->q_vectors[q_idx]->napi);\n+\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++) {\n+\t\tstruct ice_q_vector *q_vector = vsi->q_vectors[q_idx];\n+\n+\t\tif (q_vector->rx.ring || q_vector->tx.ring)\n+\t\t\tnapi_enable(&q_vector->napi);\n+\t}\n }\n \n /**\n@@ -2931,8 +2935,12 @@ static void ice_napi_disable_all(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++)\n-\t\tnapi_disable(&vsi->q_vectors[q_idx]->napi);\n+\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++) {\n+\t\tstruct ice_q_vector *q_vector = vsi->q_vectors[q_idx];\n+\n+\t\tif (q_vector->rx.ring || q_vector->tx.ring)\n+\t\t\tnapi_disable(&q_vector->napi);\n+\t}\n }\n \n /**\n", "prefixes": [] }