Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1004703/?format=api
{ "id": 1004703, "url": "http://patchwork.ozlabs.org/api/patches/1004703/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/HK0PR01MB2163357339526D3645190770ADD10@HK0PR01MB2163.apcprd01.prod.exchangelabs.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<HK0PR01MB2163357339526D3645190770ADD10@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>", "list_archive_url": null, "date": "2018-11-28T12:24:17", "name": "intel: ice: Do not enable NAPI on q_vectors that have no rings", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "31515c6b8bc169dfabc9d012d65d52601dd7e6d1", "submitter": { "id": 75435, "url": "http://patchwork.ozlabs.org/api/people/75435/?format=api", "name": "Yang Xiao", "email": "YangX92@hotmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/HK0PR01MB2163357339526D3645190770ADD10@HK0PR01MB2163.apcprd01.prod.exchangelabs.com/mbox/", "series": [ { "id": 78598, "url": "http://patchwork.ozlabs.org/api/series/78598/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=78598", "date": "2018-11-28T12:24:17", "name": "intel: ice: Do not enable NAPI on q_vectors that have no rings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/78598/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1004703/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1004703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=hotmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=hotmail.com header.i=@hotmail.com\n\theader.b=\"CEPoycNI\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 434p9654Lpz9s3l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 29 Nov 2018 04:50:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7122D86918;\n\tWed, 28 Nov 2018 17:50:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PCKAupIqethW; Wed, 28 Nov 2018 17:50:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5F66086AD0;\n\tWed, 28 Nov 2018 17:50:45 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 79C1D1BF34F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 28 Nov 2018 12:24:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4275524B27\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 28 Nov 2018 12:24:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id P4-Hw5bKbprm for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 28 Nov 2018 12:24:22 +0000 (UTC)", "from APC01-HK2-obe.outbound.protection.outlook.com\n\t(mail-oln040092255044.outbound.protection.outlook.com [40.92.255.44])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B397423756\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 28 Nov 2018 12:24:21 +0000 (UTC)", "from PU1APC01FT055.eop-APC01.prod.protection.outlook.com\n\t(10.152.252.54) by\n\tPU1APC01HT035.eop-APC01.prod.protection.outlook.com\n\t(10.152.253.13) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1339.10;\n\tWed, 28 Nov 2018 12:24:17 +0000", "from HK0PR01MB2163.apcprd01.prod.exchangelabs.com (10.152.252.57)\n\tby PU1APC01FT055.mail.protection.outlook.com (10.152.253.106) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n\t15.20.1339.10 via Frontend Transport; Wed, 28 Nov 2018 12:24:17 +0000", "from HK0PR01MB2163.apcprd01.prod.exchangelabs.com\n\t([fe80::198d:1315:c7f3:abdb]) by\n\tHK0PR01MB2163.apcprd01.prod.exchangelabs.com\n\t([fe80::198d:1315:c7f3:abdb%2]) with mapi id 15.20.1361.019;\n\tWed, 28 Nov 2018 12:24:17 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=pzBtX/bq1syGvirRniuofLl6SPPDWvFWL26D3DqN9Nc=;\n\tb=CEPoycNIj7oP5NF13qGUvmtnLWNeoeSsQbj9IGKZLAuQC68vtPndbVubZgx9YNhAsHORdQ364mLL4K9FOyKy4/hCltL0dBkyyo1PloShp/cIdalrS9TcgMkxY+BrQhWrein3ZQN4MyMk6VxI5ZFsDX9V6rHoviofJlly23RiCN10/InCbnzGuQ69k4G9ZXJuJ743HViZPvnfZ2rToGLBd2CrCLFN0ioo8SgWuiZxjkozk/IJC0u4BWHRICXG7/2zezI80jay4SRI0NAZXACl5e7FY8LdOEke8DLsB1hqXuU43FHFrT3qwPU+HUKETAvAGRWs78dB7T80y+zj2X0L2g==", "From": "Yang Xiao <YangX92@hotmail.com>", "To": "\"jeffrey.t.kirsher@intel.com\" <jeffrey.t.kirsher@intel.com>,\n\t\"davem@davemloft.net\" <davem@davemloft.net>,\n\t\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>", "Thread-Topic": "[PATCH] intel: ice: Do not enable NAPI on q_vectors that have\n\tno rings", "Thread-Index": "AQHUhxVIJTVPgjbTwUGJCL15cq9/Mg==", "Date": "Wed, 28 Nov 2018 12:24:17 +0000", "Message-ID": "<HK0PR01MB2163357339526D3645190770ADD10@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HK0PR03CA0026.apcprd03.prod.outlook.com\n\t(2603:1096:203:2f::14) To\n\tHK0PR01MB2163.apcprd01.prod.exchangelabs.com\n\t(2603:1096:203:73::11)", "x-incomingtopheadermarker": "OriginalChecksum:46F0C4A7F1A01CBFED8EAF4E315869D0C2F246DC3F7438F01917FDB5AA50B84B;\n\tUpperCasedChecksum:17A705DF68AF14280AF6B7183E90527FBBEE1019309FD270906DA9532D6C3621;\n\tSizeAsReceived:7550; Count:48", "x-ms-exchange-messagesentrepresentingtype": "1", "x-tmn": "[P2ob/6Td7Ufiz/QwsW/zle4KRSTnW518g9TRpuxZB6w=]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; PU1APC01HT035;\n\t6:7EAHyPQuGIT1GTOpHUgLAmxTBsyVtJ8n1njy1Xxq3NdqnJvI2sEAkHTtCpoh1Ew+mU7af6811Mr3o8VSda/Zl/Lksd7wttJ31krHa7RYU/1QlecEKY7nhYIaXezhm5qI6f8QGDwcjoJHNGVpfAy0dSmkxYlKrB+Ri4SDfoD3YG/PqIBelAr/T7/Qe/FlLf2AsGh+MEkgfELxUpgwPgt7niFEoTRFrMnpiTjSR+BZ+wZmeJVBrVhK4sIEOQb4axc9t44FPnDCF/XdaAW1pKdeOabEStTTWLUGaaLTFDJSc/pQJFG1wNEMa0+6koRMpuyV6q1vNVzPIs63UWn19zt7WGCZF1jiNhM8OU3lbmLFQtCSMZiGZpEbGmP6hU9ZNIut7duv3nVe7QzmVSGT6b/EQ+3c2mztaML8cII4Ej5qcPVQddv9wycqdCUzp7DlhsAm66W3tZSjNOjOgecSxFNkUA==;\n\t5:nuDKMkHR4oYtK4GlOYhtMyMeBxCwgVBLqvdSJ07U5YZ5j6e17P4m5Nd8vyBbUtj+2gG1T4lHfINn3kgGf6vBDth3WEQhv/N6yaEolEQ3TFsFWQe8WzxyppNBQhId1gkZk6dCR3clP9FDuJ9h9YwrU6zFszIgG5WYQQzKB/FHtdA=;\n\t7:MGD0ReCCx8A9fSORD6BRVKa0QGK2jwqPZ+LytJpXQyxAjjQwKcPs0kYRXedjZz1CFZVlr6xYLrzsTiGthFKnvyeqMEmzFvpJj8wIhjRVcCeko51BNLiQ/iJkOa/fxP00bqarMZE8S2KTOiSIx8xGTA==", "x-incomingheadercount": "48", "x-eopattributedmessage": "0", "x-ms-exchange-slblob-mailprops": "mBRmoEB1kyKsMsSw1iF/glKwsFGAw1JGt04QWVUf4SJtkGevIXTU71neUeDFkwEoqRKtM0wxBhyWuCtoZ2OA+Mp0Aa0WG3e7x8U8xsKuyt9G2X/vULOyItdv5240eOBApWTHiZZi5zO44F2gFMmJqS53h3067ZeeBUe0S0eFqhaIm5H9LxAa56EIphrcO+0OzuEIIlB9U15B3ux43tkGdkPaVApr47DLez5XDqjWQes8VeoaFQzYz7WxWxM/4X0i42tXDMQ49DuCOwGBQnWB+fb7HUsQc0mvaujXBxxLjRYJAnK82DfV1MDW8D298VFRV2TY4+n1xj5B0DCdAcUjtl7WpcYfdE0j6lgsazrQlSZUNPvJ1twDg8B1N88JnXV2uHKO/PNbblF4xATi6PhpSaPXiwXHTvXP+IrMjCzQHzCiIFD39PlOvFlnBNw8bJApwQpbYVkUiPYlrVpLLotM2sLLrKJv5cOIEDsvH14RU5KNDq32+6kyvfDJOkzeHezIN9UYXXCkBVkRLNndgON+EfBz2rGzMQTwSNi2Jceag9wLg6pnyzhJVaUn8zuAwwtoF1iMcLDcIh25qgTIZ8hx2ktHyJW1PmGwXzCtc/O53diuf36oXTJ4rPDmdMqpdUBRU/Sv0QrU3OhIWS3p3owt99gfbI5KK0N4CgzZf6RHM8iPzlRWSi9xYptE60Tfdyxe7zo4F+kDhBbwzE0Ig+5zAw9cpEZCX4qJU9TtdTYfkPjzYSLFQABs1yZoLfr1gDdUDWiyI5E3MF8=", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390098)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(201702181274)(2017031322404)(1603101475)(1601125500)(1701031045);\n\tSRVR:PU1APC01HT035; ", "x-ms-traffictypediagnostic": "PU1APC01HT035:", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0; RULEID:(4566010)(82015058);\n\tSRVR:PU1APC01HT035; BCL:0; PCL:0; RULEID:; SRVR:PU1APC01HT035; ", "x-microsoft-antispam-message-info": "V/FWbPS4DOT/YKBh6cN5d8POprtxGgTYMgQaE7tNXtLfUnXcMShznpvILzFqHdNP", "MIME-Version": "1.0", "X-OriginatorOrg": "hotmail.com", "X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg": [ "c001924d-3e68-4f40-89c2-901a49278da7", "c001924d-3e68-4f40-89c2-901a49278da7" ], "X-MS-Exchange-CrossTenant-Network-Message-Id": "f3e87023-65ec-4095-9d6b-08d6552c6a2b", "X-MS-Exchange-CrossTenant-rms-persistedconsumerorg": [ "c001924d-3e68-4f40-89c2-901a49278da7", "c001924d-3e68-4f40-89c2-901a49278da7" ], "X-MS-Exchange-CrossTenant-originalarrivaltime": "28 Nov 2018 12:24:17.6815\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Internet", "X-MS-Exchange-CrossTenant-id": "84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PU1APC01HT035", "X-Mailman-Approved-At": "Wed, 28 Nov 2018 17:50:45 +0000", "Subject": "[Intel-wired-lan] [PATCH] intel: ice: Do not enable NAPI on\n\tq_vectors that have no rings", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Yang Xiao <YangX92@hotmail.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Young Xiao <YangX92@hotmail.com>\n\nIf ice driver has q_vectors w/ active NAPI that has no rings,\nthen this will result in a divide by zero error. To correct it\nI am updating the driver code so that we only support NAPI on\nq_vectors that have 1 or more rings allocated to them.\n\nSee commit 13a8cd191a2b (\"i40e: Do not enable NAPI on q_vectors\nthat have no rings\") for detail.\n\nSigned-off-by: Young Xiao <YangX92@hotmail.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 333312a..9cc988a 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -2563,8 +2563,12 @@ static void ice_napi_enable_all(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++)\n-\t\tnapi_enable(&vsi->q_vectors[q_idx]->napi);\n+\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++) {\n+\t\tstruct ice_q_vector *q_vector = vsi->q_vectors[q_idx];\n+\n+\t\tif (q_vector->rx.ring || q_vector->tx.ring)\n+\t\t\tnapi_enable(&q_vector->napi);\n+\t}\n }\n \n /**\n@@ -2931,8 +2935,12 @@ static void ice_napi_disable_all(struct ice_vsi *vsi)\n \tif (!vsi->netdev)\n \t\treturn;\n \n-\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++)\n-\t\tnapi_disable(&vsi->q_vectors[q_idx]->napi);\n+\tfor (q_idx = 0; q_idx < vsi->num_q_vectors; q_idx++) {\n+\t\tstruct ice_q_vector *q_vector = vsi->q_vectors[q_idx];\n+\n+\t\tif (q_vector->rx.ring || q_vector->tx.ring)\n+\t\t\tnapi_enable(&q_vector->napi);\n+\t}\n }\n \n /**\n", "prefixes": [] }