Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1003352/?format=api
{ "id": 1003352, "url": "http://patchwork.ozlabs.org/api/patches/1003352/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181123161028.22633-2-khorenko@virtuozzo.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181123161028.22633-2-khorenko@virtuozzo.com>", "list_archive_url": null, "date": "2018-11-23T16:10:28", "name": "[1/1] drivers/net/i40e: define proper net_device::neigh_priv_len", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "76eea1599fadbd05fa5809652d13ffbd5e41ffa0", "submitter": { "id": 74595, "url": "http://patchwork.ozlabs.org/api/people/74595/?format=api", "name": "Konstantin Khorenko", "email": "khorenko@virtuozzo.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20181123161028.22633-2-khorenko@virtuozzo.com/mbox/", "series": [ { "id": 78072, "url": "http://patchwork.ozlabs.org/api/series/78072/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=78072", "date": "2018-11-23T16:10:27", "name": "drivers/i40iw: out of bound access in i40iw_net_event()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/78072/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1003352/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1003352/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=virtuozzo.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 433Yyx3KkQz9ryk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 27 Nov 2018 04:37:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0DC84874A5;\n\tMon, 26 Nov 2018 17:37:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MdmxilBlJhty; Mon, 26 Nov 2018 17:37:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 060AF873F8;\n\tMon, 26 Nov 2018 17:37:42 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 73AC21BF3AA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Nov 2018 16:50:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7014B228AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Nov 2018 16:50:39 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id abytozr37ouN for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Nov 2018 16:50:38 +0000 (UTC)", "from relay.sw.ru (relay.sw.ru [185.231.240.75])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 009D122834\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 23 Nov 2018 16:50:37 +0000 (UTC)", "from [10.94.4.83] (helo=finist-ce7.sw.ru)\n\tby relay.sw.ru with esmtp (Exim 4.91)\n\t(envelope-from <khorenko@virtuozzo.com>)\n\tid 1gQE2I-0003fC-Kq; Fri, 23 Nov 2018 19:10:30 +0300" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:39:55 by SQLgrey-1.7.6", "From": "Konstantin Khorenko <khorenko@virtuozzo.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Fri, 23 Nov 2018 19:10:28 +0300", "Message-Id": "<20181123161028.22633-2-khorenko@virtuozzo.com>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20181123161028.22633-1-khorenko@virtuozzo.com>", "References": "<20181123161028.22633-1-khorenko@virtuozzo.com>", "X-Mailman-Approved-At": "Mon, 26 Nov 2018 17:37:41 +0000", "Subject": "[Intel-wired-lan] [PATCH 1/1] drivers/net/i40e: define proper\n\tnet_device::neigh_priv_len", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org,\n\tKonstantin Khorenko <khorenko@virtuozzo.com>, \n\t\"David S . Miller\" <davem@davemloft.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Out of bound read reported by KASan.\n\ni40iw_net_event() reads unconditionally 16 bytes from\nneigh->primary_key while the memory allocated for\n\"neighbour\" struct is evaluated in neigh_alloc() as\n\n tbl->entry_size + dev->neigh_priv_len\n\nwhere \"dev\" is a net_device.\n\nBut the driver does not setup dev->neigh_priv_len and\nwe read beyond the neigh entry allocated memory,\nso the patch in the next mail fixes this.\n\nSigned-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 21c2688d6308..539b8f3738e6 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -12334,6 +12334,9 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)\n \tether_addr_copy(netdev->dev_addr, mac_addr);\n \tether_addr_copy(netdev->perm_addr, mac_addr);\n \n+\t/* i40iw_net_event() reads 16 bytes from neigh->primary_key */\n+\tnetdev->neigh_priv_len = sizeof(u32) * 4;\n+\n \tnetdev->priv_flags |= IFF_UNICAST_FLT;\n \tnetdev->priv_flags |= IFF_SUPP_NOFCS;\n \t/* Setup netdev TC information */\n", "prefixes": [ "1/1" ] }