Cover Letter Detail
Show a cover letter.
GET /api/covers/985218/?format=api
{ "id": 985218, "url": "http://patchwork.ozlabs.org/api/covers/985218/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20181017082702.5581-1-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181017082702.5581-1-armbru@redhat.com>", "list_archive_url": null, "date": "2018-10-17T08:26:24", "name": "[v4,00/38] Replace some unwise uses of error_report() & friends", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20181017082702.5581-1-armbru@redhat.com/mbox/", "series": [ { "id": 71196, "url": "http://patchwork.ozlabs.org/api/series/71196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=71196", "date": "2018-10-17T08:26:36", "name": "Replace some unwise uses of error_report() & friends", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/71196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/985218/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42ZlpX0TQKz9s9J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 17 Oct 2018 19:34:28 +1100 (AEDT)", "from localhost ([::1]:34531 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gChHd-0005kz-3w\n\tfor incoming@patchwork.ozlabs.org; Wed, 17 Oct 2018 04:34:25 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51037)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAb-00085C-Kb\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:11 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1gChAY-0000zb-6M\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:09 -0400", "from mx1.redhat.com ([209.132.183.28]:52500)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1gChAX-0000wM-Q9\n\tfor qemu-devel@nongnu.org; Wed, 17 Oct 2018 04:27:06 -0400", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E224E3081D9B\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:03 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com\n\t[10.36.116.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 83C781057057\n\tfor <qemu-devel@nongnu.org>; Wed, 17 Oct 2018 08:27:03 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 16FC011384D8; Wed, 17 Oct 2018 10:27:02 +0200 (CEST)" ], "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 17 Oct 2018 10:26:24 +0200", "Message-Id": "<20181017082702.5581-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.43]);\n\tWed, 17 Oct 2018 08:27:03 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v4 00/38] Replace some unwise uses of\n\terror_report() & friends", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Calling error_report() or similar in a function that takes an Error **\nargument is suspicious. Fix a number of instances that are actually\nwrong. Clean up a few more that are merely fragile / bad examples.\n\nv4:\n* PATCH 36-37: Unbreak qemu-iotests [Eric]\n\nv3:\n* PATCH 27: Drop useless error message prefix [Gerd]\n* PATCH 36-38: New\n\nv2:\n* PATCH 01: New\n* PATCH 02: Commit hash corrected in commit message [Eric]\n* PATCH 13: Error messages tidied up [Marc-André]\n* PATCH 15: Commit message tidied up [Eduardo H.]\n* PATCH 16: Unwanted string split fixed [Marc-André, Eduardo O.]\n* PATCH 20: Commit message corrected [Marc-André]\n* PATCH 25-26: New\n* PATCH 27: Rebased, commit message corrected\n* PATCH 30: Commit message tidied up [Eric]\n* PATCH 32: Less confusing commit message, help fixed [Max]\n* PATCH 34: New\n\nFei Li (1):\n ui: Convert vnc_display_init(), init_keyboard_layout() to Error\n\nMarkus Armbruster (37):\n error: Fix use of error_prepend() with &error_fatal, &error_abort\n Use error_fatal to simplify obvious fatal errors (again)\n block: Use warn_report() & friends to report warnings\n cpus hw target: Use warn_report() & friends to report warnings\n vfio: Use warn_report() & friends to report warnings\n vfio: Clean up error reporting after previous commit\n char: Use error_printf() to print help and such\n 9pfs: Fix CLI parsing crash on error\n pc: Fix machine property nvdimm-persistence error handling\n ioapic: Fix error handling in realize()\n smbios: Clean up error handling in smbios_add()\n migration: Fix !replay_can_snapshot() error handling\n l2tpv3: Improve -netdev/netdev_add/-net/... error reporting\n net/socket: Fix invalid socket type error handling\n numa: Fix QMP command set-numa-node error handling\n xen/pt: Fix incomplete conversion to realize()\n seccomp: Clean up error reporting in parse_sandbox()\n vl: Clean up error reporting in parse_add_fd()\n qom: Clean up error reporting in user_creatable_add_opts_foreach()\n vl: Clean up error reporting in chardev_init_func()\n vl: Clean up error reporting in machine_set_property()\n vl: Clean up error reporting in mon_init_func()\n vl: Clean up error reporting in parse_fw_cfg()\n vl: Clean up error reporting in device_init_func()\n ui/keymaps: Fix handling of erroneous include files\n vnc: Clean up error reporting in vnc_init_func()\n numa: Clean up error reporting in parse_numa()\n tpm: Clean up error reporting in tpm_init_tpmdev()\n spice: Clean up error reporting in add_channel()\n fsdev: Clean up error reporting in qemu_fsdev_add()\n vl: Assert drive_new() does not fail in default_drive()\n blockdev: Convert drive_new() to Error\n vl: Fix exit status for -drive format=help\n vl: Simplify call of parse_name()\n block: Clean up bdrv_img_create()'s error reporting\n raw: Convert a warning to warn_report()\n vpc: Fail open on bad header checksum\n\n block.c | 9 +-\n block/bochs.c | 8 +-\n block/cloop.c | 8 +-\n block/dmg.c | 8 +-\n block/iscsi.c | 2 +-\n block/qcow2.c | 4 +-\n block/qed.c | 4 +-\n block/raw-format.c | 17 +--\n block/rbd.c | 12 +-\n block/sheepdog.c | 2 +-\n block/vpc.c | 8 +-\n block/vvfat.c | 8 +-\n blockdev.c | 27 ++---\n chardev/char-pty.c | 2 +-\n chardev/char.c | 2 +-\n cpus.c | 8 +-\n device-hotplug.c | 5 +-\n fsdev/qemu-fsdev-dummy.c | 2 +-\n fsdev/qemu-fsdev.c | 12 +-\n fsdev/qemu-fsdev.h | 2 +-\n hw/9pfs/9p-handle.c | 6 +-\n hw/9pfs/9p-local.c | 4 +-\n hw/9pfs/xen-9p-backend.c | 7 +-\n hw/display/cg3.c | 2 +-\n hw/display/tcx.c | 2 +-\n hw/i386/pc.c | 5 +-\n hw/intc/ioapic.c | 8 +-\n hw/intc/xics.c | 15 ++-\n hw/intc/xics_kvm.c | 7 +-\n hw/misc/ivshmem.c | 4 +-\n hw/net/virtio-net.c | 8 +-\n hw/ppc/pnv_core.c | 4 +-\n hw/ppc/spapr_pci.c | 7 +-\n hw/smbios/smbios.c | 90 ++++++++++-----\n hw/timer/aspeed_timer.c | 3 +-\n hw/usb/bus.c | 5 +-\n hw/vfio/pci-quirks.c | 4 +-\n hw/vfio/pci.c | 25 ++--\n hw/vfio/platform.c | 6 +-\n hw/virtio/virtio-pci.c | 4 +-\n hw/xen/xen_pt.c | 2 +-\n include/hw/vfio/vfio-common.h | 3 +-\n include/qapi/error.h | 14 +++\n include/sysemu/blockdev.h | 3 +-\n include/sysemu/numa.h | 1 -\n include/sysemu/tpm.h | 2 +-\n include/ui/console.h | 2 +-\n migration/migration.c | 12 +-\n migration/savevm.c | 8 +-\n net/l2tpv3.c | 25 ++--\n net/socket.c | 4 +-\n numa.c | 21 ++--\n qemu-io.c | 8 +-\n qemu-nbd.c | 14 +--\n qemu-seccomp.c | 18 +--\n qom/object_interfaces.c | 4 +-\n scripts/coccinelle/use-error_fatal.cocci | 20 ++++\n stubs/tpm.c | 3 +-\n target/i386/cpu.c | 17 +--\n target/ppc/translate_init.inc.c | 4 +-\n tests/qemu-iotests/049.out | 12 +-\n tests/qemu-iotests/099 | 3 +-\n tests/qemu-iotests/109.out | 55 +++++----\n tpm.c | 22 ++--\n ui/curses.c | 6 +-\n ui/keymaps.c | 40 ++++---\n ui/keymaps.h | 2 +-\n ui/sdl.c | 6 +-\n ui/spice-core.c | 13 ++-\n ui/vnc.c | 19 ++--\n util/error.c | 13 +++\n vl.c | 139 +++++++++--------------\n 72 files changed, 474 insertions(+), 407 deletions(-)\n create mode 100644 scripts/coccinelle/use-error_fatal.cocci" }