Cover Letter Detail
Show a cover letter.
GET /api/covers/977668/?format=api
{ "id": 977668, "url": "http://patchwork.ozlabs.org/api/covers/977668/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20181002080034.11754-1-bjorn.topel@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20181002080034.11754-1-bjorn.topel@gmail.com>", "list_archive_url": null, "date": "2018-10-02T08:00:29", "name": "[v2,0/5] Introducing ixgbe AF_XDP ZC support", "submitter": { "id": 70569, "url": "http://patchwork.ozlabs.org/api/people/70569/?format=api", "name": "Björn Töpel", "email": "bjorn.topel@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20181002080034.11754-1-bjorn.topel@gmail.com/mbox/", "series": [ { "id": 68583, "url": "http://patchwork.ozlabs.org/api/series/68583/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=68583", "date": "2018-10-02T08:00:30", "name": "Introducing ixgbe AF_XDP ZC support", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/68583/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/977668/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 42PWnM18Fbz9sj1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 2 Oct 2018 18:01:26 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 727A41FE41;\n\tTue, 2 Oct 2018 08:01:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rUNRqncTO5L9; Tue, 2 Oct 2018 08:01:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 518FB2366F;\n\tTue, 2 Oct 2018 08:01:25 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BAE131BF479\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B6F7F87DC7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:17 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UDzRhJT7ECGH for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:08 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 9A48787DE4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Oct 2018 08:01:08 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Oct 2018 01:01:08 -0700", "from pvenkata-mobl.amr.corp.intel.com (HELO\n\tbtopel-mobl1.ger.corp.intel.com) ([10.252.35.165])\n\tby orsmga003.jf.intel.com with ESMTP; 02 Oct 2018 01:01:03 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,331,1534834800\"; d=\"scan'208\";a=\"88439227\"", "From": "=?utf-8?b?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>", "To": "jeffrey.t.kirsher@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 2 Oct 2018 10:00:29 +0200", "Message-Id": "<20181002080034.11754-1-bjorn.topel@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2 0/5] Introducing ixgbe AF_XDP ZC support", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.24", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "jakub.kicinski@netronome.com, daniel@iogearbox.net,\n\tnetdev@vger.kernel.org, ast@kernel.org, tuc@vmware.com,\n\tu9012063@gmail.com, brouer@redhat.com, =?utf-8?b?QmrDtnJuIFTDtnBlbA==?=\n\t<bjorn.topel@intel.com>, magnus.karlsson@gmail.com,\n\tmagnus.karlsson@intel.com", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Björn Töpel <bjorn.topel@intel.com>\n\nJeff: Please remove the v1 patches from your dev-queue!\n\nThis patch set introduces zero-copy AF_XDP support for Intel's ixgbe\ndriver.\n\nThe ixgbe zero-copy code is located in its own file ixgbe_xsk.[ch],\nanalogous to the i40e ZC support. Again, as in i40e, code paths have\nbeen copied from the XDP path to the zero-copy path. Going forward we\nwill try to generalize more code between the AF_XDP ZC drivers, and\nalso reduce the heavy C&P.\n\nWe have run some benchmarks on a dual socket system with two Broadwell\nE5 2660 @ 2.0 GHz with hyperthreading turned off. Each socket has 14\ncores which gives a total of 28, but only two cores are used in these\nexperiments. One for TR/RX and one for the user space application. The\nmemory is DDR4 @ 2133 MT/s (1067 MHz) and the size of each DIMM is\n8192MB and with 8 of those DIMMs in the system we have 64 GB of total\nmemory. The compiler used is GCC 7.3.0. The NIC is Intel\n82599ES/X520-2 10Gbit/s using the ixgbe driver.\n\nBelow are the results in Mpps of the 82599ES/X520-2 NIC benchmark runs\nfor 64B and 1500B packets, generated by a commercial packet generator\nHW blasting packets at full 10Gbit/s line rate. The results are with\nretpoline and all other spectre and meltdown fixes.\n\nAF_XDP performance 64B packets:\nBenchmark XDP_DRV with zerocopy\nrxdrop 14.7\ntxpush 14.6\nl2fwd 11.1\n\nAF_XDP performance 1500B packets:\nBenchmark XDP_DRV with zerocopy\nrxdrop 0.8\nl2fwd 0.8\n\nXDP performance on our system as a base line.\n\n64B packets:\nXDP stats CPU Mpps issue-pps\nXDP-RX CPU 16 14.7 0\n\n1500B packets:\nXDP stats CPU Mpps issue-pps\nXDP-RX CPU 16 0.8 0\n\nThe structure of the patch set is as follows:\n\nPatch 1: Introduce Rx/Tx ring enable/disable functionality\nPatch 2: Preparatory patche to ixgbe driver code for RX\nPatch 3: ixgbe zero-copy support for RX\nPatch 4: Preparatory patch to ixgbe driver code for TX\nPatch 5: ixgbe zero-copy support for TX\n\nChanges since v1:\n\n* Removed redundant AF_XDP precondition checks, pointed out by\n Jakub. Now, the preconditions are only checked at XDP enable time.\n* Fixed a crash in the egress path, due to incorrect usage of\n ixgbe_ring queue_index member. In v2 a ring_idx back reference is\n introduced, and used in favor of queue_index. William reported the\n crash, and helped me smoke out the issue. Kudos!\n* In ixgbe_xsk_async_xmit, validate qid against num_xdp_queues,\n instead of num_rx_queues.\n\nCheers!\nBjörn\n\nBjörn Töpel (5):\n ixgbe: added Rx/Tx ring disable/enable functions\n ixgbe: move common Rx functions to ixgbe_txrx_common.h\n ixgbe: add AF_XDP zero-copy Rx support\n ixgbe: move common Tx functions to ixgbe_txrx_common.h\n ixgbe: add AF_XDP zero-copy Tx support\n\n drivers/net/ethernet/intel/ixgbe/Makefile | 3 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 28 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 17 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 291 ++++++-\n .../ethernet/intel/ixgbe/ixgbe_txrx_common.h | 50 ++\n drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 803 ++++++++++++++++++\n 6 files changed, 1146 insertions(+), 46 deletions(-)\n create mode 100644 drivers/net/ethernet/intel/ixgbe/ixgbe_txrx_common.h\n create mode 100644 drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c" }