Cover Letter Detail
Show a cover letter.
GET /api/covers/818787/?format=api
{ "id": 818787, "url": "http://patchwork.ozlabs.org/api/covers/818787/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/cover/20170926192142.42308-1-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170926192142.42308-1-sjg@chromium.org>", "list_archive_url": null, "date": "2017-09-26T19:21:28", "name": "[U-Boot,v2,00/14] log: Add a new logging feature", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/cover/20170926192142.42308-1-sjg@chromium.org/mbox/", "series": [ { "id": 5217, "url": "http://patchwork.ozlabs.org/api/series/5217/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=5217", "date": "2017-09-26T19:21:28", "name": "log: Add a new logging feature", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/5217/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/818787/comments/", "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"lov4KAlo\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1rRt2mjlz9t5l\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 05:21:59 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid CFBE3C21DE7; Tue, 26 Sep 2017 19:21:56 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E14ECC21DE7;\n\tTue, 26 Sep 2017 19:21:53 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 3B49DC21E08; Tue, 26 Sep 2017 19:21:52 +0000 (UTC)", "from mail-oi0-f46.google.com (mail-oi0-f46.google.com\n\t[209.85.218.46])\n\tby lists.denx.de (Postfix) with ESMTPS id 90BF1C21DE7\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 19:21:51 +0000 (UTC)", "by mail-oi0-f46.google.com with SMTP id x85so13488947oix.12\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 12:21:51 -0700 (PDT)", "from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\th63sm1478111otb.59.2017.09.26.12.21.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 12:21:48 -0700 (PDT)", "by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 49BF8140573; Tue, 26 Sep 2017 13:21:47 -0600 (MDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; h=sender:from:to:cc:subject:date:message-id;\n\tbh=PV5T8OxEz/czJx0+h6ENeShZr5Fl54JCZXMTY66I2MM=;\n\tb=lov4KAlo/nAzQm7BwpsKDjpT+bKQ3qHxFEtJb01sfxRxWWwgw6e59MmroHaoCn1est\n\tjDqh1jE2OuOOuMeiI09HXaJO1KfZ60RAfHrM4wz0NaNflHFoR0W1qmeGLUAtpSHRIr0+\n\trlNf6i4dFJoNg6zouopjoYi10utfaxHd33whMwtiJSoJZsYUTcgwKM8gt5CSABzRuytq\n\tGbh4XD1mPiIbFvlvJaUZxUHvNtC5FXJuIPMIzIQCtCDhBdKz9dS6MMP2zAdc4CQx6dt8\n\thgPMrF8vIq/ePqOhxISZx1BoH2DNvAVW6HsMiAU85+nnioKODKzBBirdw22zIplXWo1O\n\tZusQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=PV5T8OxEz/czJx0+h6ENeShZr5Fl54JCZXMTY66I2MM=;\n\tb=N1kBnwpn/UKGZLGY97JOmjiy1l6uJZxHeGqHgPVosgpB3nsGBfelJ++juwNZ7/xRuh\n\tKuEHrQcU42K9iq+ZYRKsKU436AKefAU6t9Mkp5HXfc6GzEMxmATCyawfBkINnzzfVcBU\n\tyjgh2CPbzpHFt8h3QniV09Os23PsxOh0zIiMPP7M73/fWr/lusHIdo2L+tDzuH+SVMzn\n\tZvLDTX1baqewA9j1+oBx0XEvurYaaRiRU4icriyr0bsPdbax029fTq1SiimiyaRscw3k\n\tQr9TGOuz3VZcGt/sOCwMBFTXSLrEfwUPkkle0qCND4ZUsbbtSaEHJBI+b/IbtS2F3685\n\tJVEQ==", "X-Gm-Message-State": "AHPjjUgR3HKYcO3F2nqnwBub6WWM6kwnDb/05cS8gq19TfE2k0bb0i4X\n\teN5jZcLPr8fqY02LBchJf9TmUQ==", "X-Google-Smtp-Source": "AOwi7QCAJ4p875vYIPgTg04psPpj7gmcpYHsyT+ZPmT8edAcAyrfte5fg0rzuVYk4sZNjwYvQxA6Jw==", "X-Received": "by 10.202.81.21 with SMTP id f21mr1156120oib.433.1506453709810; \n\tTue, 26 Sep 2017 12:21:49 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Tue, 26 Sep 2017 13:21:28 -0600", "Message-Id": "<20170926192142.42308-1-sjg@chromium.org>", "X-Mailer": "git-send-email 2.14.1.992.g2c7b836f3a-goog", "Cc": "Tom Rini <trini@konsulko.com>", "Subject": "[U-Boot] [PATCH v2 00/14] log: Add a new logging feature", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "U-Boot currently has fairly rudimentary logging features. A basic printf()\nprovides console output and debug() provides debug output which is\nactivated if DEBUG is defined in the file containing the debug()\nstatements.\n\nIt would be useful to have a few more features:\n\n- control of debug output at runtime, so problems can potentially be\ndebugged without recompiling U-Boot\n- control of which subsystems output debug information, so that (for\nexample) it is possible to enable debugging for MMC or SATA at runtime\n- indication of severity with each message, so that the user can control\nwhether just errors are displayed, warnings, or all debug messages\n- sending logging information to different destinations, such as console,\nmemory, linux, etc,\n\nAt present U-Boot has a logbuffer feature which records output in a memory\nbuffer for later display or storage. This is useful but is not at present\nenabled for any board.\n\nThis series introduced a new logging system which supports:\n- various log levels from panic to debug\n- log categories including all uclasses and a few others\n- log drivers to which all log records can be sent\n- log filters which control which log records make it to which drivers\n\nEnabling logging with the default options does not add much to code size.\nBy default the maximum recorded log level is LOGL_INFO, meaning that debug\nmessages (and above) are discarded a build-time. Increasing this level\nprovides more run-time flexibility to enable/disable logging at the cost\nof increased code size.\n\nThis feature is by no means finished. The README provides a long list of\nfeatures and clean-ups that could be done. But hopefully this is a\nstarting point for improving this important area in U-Boot.\n\nThe series is available at u-boot-dm/log-working\n\nChanges in v2:\n- Add a comment as to why CONFIG_LOG_MAX_LEVEL is not defined\n- Change log levels to match new header\n- Change sandbox log level to 6\n- Drop MAINTAINERS entries for files not added by this patch\n- Drop the special log() functions from the README\n- Drop the use of 'continue' in the macro\n- Fix LOG_SPL_MAX_LEVEL typo (should be SPL_LOG_MAX_LEVEL)\n- Fix function called when test command is selected\n- Fix help output for 'log test'\n- Fix up bad use of #if CONFIG_VAL() - use #ifdef instead\n- Line up log levels with Linux\n- Only execute log tests if CONFIG_LOG is enabled\n- Rename LOGL_WARN to LOGL_WARNING\n- Split pre-console address change into a separate patch\n- Update commit message to explain that this is not just for serial output\n\nSimon Glass (14):\n Revert \"sandbox: remove os_putc() and os_puts()\"\n sandbox: Adjust pre-console address to avoid conflict\n Revert \"sandbox: Drop special case console code for sandbox\"\n Move debug and logging support to a separate header\n mtdparts: Correct use of debug()\n Drop the log buffer\n log: Add an implemention of logging\n log: Add a console driver\n log: Add a 'log level' command\n log: Add a test command\n log: Plumb logging into the init sequence\n log: sandbox: Enable logging\n log: test: Add a pytest for logging\n log: Add documentation\n\n MAINTAINERS | 9 ++\n arch/sandbox/cpu/os.c | 11 ++\n cmd/Kconfig | 8 +\n cmd/Makefile | 2 +-\n cmd/log.c | 326 +++++---------------------------------\n cmd/mtdparts.c | 3 -\n common/Kconfig | 86 ++++++++++\n common/Makefile | 2 +\n common/board_f.c | 23 +--\n common/board_r.c | 27 +---\n common/console.c | 7 +\n common/image.c | 9 --\n common/log.c | 245 ++++++++++++++++++++++++++++\n common/log_console.c | 23 +++\n common/stdio.c | 6 -\n configs/sandbox_defconfig | 5 +-\n doc/README.log | 214 +++++++++++++++++++++++++\n include/asm-generic/global_data.h | 8 +-\n include/common.h | 64 +-------\n include/log.h | 316 ++++++++++++++++++++++++++++++++++++\n include/logbuff.h | 49 ------\n include/os.h | 20 +++\n include/post.h | 4 +-\n post/post.c | 9 --\n post/tests.c | 4 -\n scripts/config_whitelist.txt | 1 -\n test/Makefile | 1 +\n test/log/Makefile | 7 +\n test/log/log_test.c | 204 ++++++++++++++++++++++++\n test/py/tests/test_log.py | 107 +++++++++++++\n 30 files changed, 1320 insertions(+), 480 deletions(-)\n create mode 100644 common/log.c\n create mode 100644 common/log_console.c\n create mode 100644 doc/README.log\n create mode 100644 include/log.h\n delete mode 100644 include/logbuff.h\n create mode 100644 test/log/Makefile\n create mode 100644 test/log/log_test.c\n create mode 100644 test/py/tests/test_log.py" }