Cover Letter Detail
Show a cover letter.
GET /api/covers/815648/?format=api
{ "id": 815648, "url": "http://patchwork.ozlabs.org/api/covers/815648/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/cover/CFF8EF42F1132E4CBE2BF0AB6C21C58D78813F02@ESESSMB107.ericsson.se/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<CFF8EF42F1132E4CBE2BF0AB6C21C58D78813F02@ESESSMB107.ericsson.se>", "list_archive_url": null, "date": "2017-09-19T16:29:52", "name": "[ovs-dev,0/3] : dpif-netdev: Detailed PMD performance metrics and supervision", "submitter": { "id": 68449, "url": "http://patchwork.ozlabs.org/api/people/68449/?format=api", "name": "Jan Scheurich", "email": "jan.scheurich@ericsson.com" }, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/cover/CFF8EF42F1132E4CBE2BF0AB6C21C58D78813F02@ESESSMB107.ericsson.se/mbox/", "series": [ { "id": 3922, "url": "http://patchwork.ozlabs.org/api/series/3922/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=3922", "date": "2017-09-19T16:29:52", "name": ": dpif-netdev: Detailed PMD performance metrics and supervision", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3922/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/815648/comments/", "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ovs-dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxSyb3Stnz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 02:29:59 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id DA503AE0;\n\tTue, 19 Sep 2017 16:29:56 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 9DFB092F\n\tfor <ovs-dev@openvswitch.org>; Tue, 19 Sep 2017 16:29:55 +0000 (UTC)", "from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8B64648B\n\tfor <ovs-dev@openvswitch.org>; Tue, 19 Sep 2017 16:29:54 +0000 (UTC)", "from ESESSHC017.ericsson.se (Unknown_Domain [153.88.183.69])\n\tby sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id\n\tC4.A9.21299.00641C95; Tue, 19 Sep 2017 18:29:52 +0200 (CEST)", "from ESESSMB107.ericsson.se ([169.254.7.166]) by\n\tESESSHC017.ericsson.se ([153.88.183.69]) with mapi id 14.03.0352.000; \n\tTue, 19 Sep 2017 18:29:52 +0200" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-AuditID": "c1b4fb25-94fff70000005333-48-59c14600af93", "From": "Jan Scheurich <jan.scheurich@ericsson.com>", "To": "\"ovs-dev@openvswitch.org\" <ovs-dev@openvswitch.org>", "Thread-Topic": "[PATCH 0/3]: dpif-netdev: Detailed PMD performance metrics and\n\tsupervision", "Thread-Index": "AdMxW9Kfs/kvnhuNRpGoEAahHxKywA==", "Date": "Tue, 19 Sep 2017 16:29:52 +0000", "Message-ID": "<CFF8EF42F1132E4CBE2BF0AB6C21C58D78813F02@ESESSMB107.ericsson.se>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[153.88.183.17]", "MIME-Version": "1.0", "X-Brightmail-Tracker": "H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsUyM2K7qy6D28FIg2vvDC3mfnrO6MDo8ezm\n\tf8YAxigum5TUnMyy1CJ9uwSujEs35rMVtAtWPHveyNTA+Ii3i5GTQ0LARKL16wpmEFtI4Aij\n\txPa7pV2MXED2EkaJV6uesHQxcnCwCRhIzN7tAFIjImAuceLDOXYQW1ggVOL2/XuMEPEoia3/\n\tDrJD2HoS638vYQKxWQRUJVY+ughm8wr4SrSuv8wCYjMKiEl8P7UGLM4sIC5x68l8Joh7BCSW\n\t7DnPDGGLSrx8/I8V5AQJAUWJ5f1yEOU6Egt2f2KDsLUlli18zQwxXlDi5MwnLBMYhWYhmToL\n\tScssJC2zkLQsYGRZxShanFqclJtuZKyXWpSZXFycn6eXl1qyiREYxge3/FbdwXj5jeMhRgEO\n\tRiUeXk2dg5FCrIllxZW5hxglOJiVRHhfOwGFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8zruuxAh\n\tJJCeWJKanZpakFoEk2Xi4JRqYMxu+by+gje5qG2zXEHgLjFdjvVTHtn2RL26U5XH/2nt5ryf\n\tlesXB4c3lZ1Pnxi4oO/SQetsBm6JytOCAQWly0Qmyxp9qVNckz5fOsbSZbm+QON1W9ep/8T3\n\tGuz2ic/2Luxatoxl+uLwvZGb/6moqL5mXR9S1vDE8WsK47xrO9PZH5ktcjrLpcRSnJFoqMVc\n\tVJwIAPC7evBfAgAA", "X-Spam-Status": "No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH 0/3]: dpif-netdev: Detailed PMD performance\n\tmetrics and supervision", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "The run-time performance of PMDs is often difficult to understand and trouble-shoot. The existing PMD statistics counters only provide a coarse grained average picture. At packet rates of several Mpps sporadic drops of packet bursts happen at sub-millisecond time scales and are impossible to capture and analyze with existing tools.\n\nThis patch set refactors the existing PMD statistics into a dedicated submodule and collects a large number of important PMD performance metrics per PMD iteration, maintaining histograms and circular histories for iteration metrics and millisecond averages. To capture sporadic drop events, the patch set can be configured to monitor iterations for suspicious metrics and to log the neighborhood of such iterations for off-line analysis.\n\nThe extra cost for the performance metric collection and the supervision has been measured to be in the order of 1% compared to the base commit in a phy-to-phy setup with VXLAN tunnels (two datapath passes per packet). We believe this is fast enough to not warrant a build- or run-time configuration option to disable this.\n\nThe patch set is based on commit 3e90f7d7 (Sep 6) on branch dpdk_merge in Darrel's OVS repo. The first patch in the series fully includes the changes proposed in Darrel's earlier \"[patch_v5 0/3] dpif-netdev: Fix and refactor pmd stats\" https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337686.html.\n\n\nJan Scheurich (3)\n\tRefactor PMD performance into dpif-netdev-perf\n\tDetailed performance stats for PMDs\n\tDetection and logging of suspicious PMD iterations\n\n\nlib/automake.mk | 2 +\n lib/dp-packet.h | 2 +\n lib/dpif-netdev-perf.c | 512 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n lib/dpif-netdev-perf.h | 317 ++++++++++++++++++++++++++++++++++++++\n lib/dpif-netdev.c | 438 +++++++++++++++++++++++++++++-----------------------\n lib/netdev-dpdk.c | 28 +++-\n lib/netdev-dpdk.h | 14 ++\n lib/ovs-atomic.h | 1 +\n ofproto/ofproto-dpif.c | 3 +-\n tests/pmd.at | 22 ++-\n 10 files changed, 1133 insertions(+), 206 deletions(-)" }