Cover Letter Detail
Show a cover letter.
GET /api/covers/814562/?format=api
{ "id": 814562, "url": "http://patchwork.ozlabs.org/api/covers/814562/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/cover/20170916212331.170463-1-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170916212331.170463-1-sjg@chromium.org>", "list_archive_url": null, "date": "2017-09-16T21:23:13", "name": "[U-Boot,00/13] log: Add a new logging feature", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/cover/20170916212331.170463-1-sjg@chromium.org/mbox/", "series": [ { "id": 3473, "url": "http://patchwork.ozlabs.org/api/series/3473/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=3473", "date": "2017-09-16T21:23:14", "name": "log: Add a new logging feature", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/3473/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/814562/comments/", "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"iCYnD+Te\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvlvq6jG5z9ryT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 07:36:39 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid A28F5C21DE7; Sat, 16 Sep 2017 21:36:35 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id CAE30C21DA1;\n\tSat, 16 Sep 2017 21:31:44 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 2EF8BC21C39; Sat, 16 Sep 2017 21:23:42 +0000 (UTC)", "from mail-oi0-f53.google.com (mail-oi0-f53.google.com\n\t[209.85.218.53])\n\tby lists.denx.de (Postfix) with ESMTPS id 758F6C21C26\n\tfor <u-boot@lists.denx.de>; Sat, 16 Sep 2017 21:23:41 +0000 (UTC)", "by mail-oi0-f53.google.com with SMTP id y195so2372767oia.13\n\tfor <u-boot@lists.denx.de>; Sat, 16 Sep 2017 14:23:41 -0700 (PDT)", "from kiwi.bld.corp.google.com ([2620:0:10f2:0:b470:b7b0:9c28:669e])\n\tby smtp.gmail.com with ESMTPSA id\n\t204sm4453832oib.1.2017.09.16.14.23.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 16 Sep 2017 14:23:38 -0700 (PDT)", "by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 02DC9140A54; Sat, 16 Sep 2017 15:23:36 -0600 (MDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.0 required=5.0 tests=KHOP_BIG_TO_CC,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; h=sender:from:to:cc:subject:date:message-id;\n\tbh=orkXuk6G8bU71sotHH7V3DTwYLl2tj9chhTU8Wm91GA=;\n\tb=iCYnD+TehLKTcRokh6vOuiEeTIW7LGZd5AgmfSSJAg0oHel0fcsZYXUl8GvKQNiRME\n\tPXUzy+8eH2FW8PSJE0LZ1ychC6ZpWs3WIE5832OBvpHlZiYuFWW2KW7xWxZlQc/2q/JV\n\tx0jKRZcVXwySAgtu7xA6ILLs1oE1wCmCehx6hJBR7y96PySRhf9L77YhoeECwUZxi6gx\n\t5scrGj/7ESG3x28V+Bz/jgpjKB94C97TTfDJw+t6VLbMJXvDKVvUMW8lflUGwWJes38j\n\tJarHAK8wWeV7rcBSW+rL2h/CCEYSlhLBmIOwiPehXg6/uMT5R81GKVL1O7u22BGHbi6r\n\tnI0w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=orkXuk6G8bU71sotHH7V3DTwYLl2tj9chhTU8Wm91GA=;\n\tb=M0HBrMLNMulyxXif6Mp+mNSGyXrBCBw3bGgPqoN0sTdprWycUQFK8I/izUYiViMDaR\n\tZM7TzRcuXBieT1eXsItSh/Q1xPQHEkaFSU+yFOuc6YeSCmzMIiMFBAYyqQfdJSBK8YF6\n\tDWRgrOZx90q50xubbcdo2Tgj4jRK+RtOSPBsstXbywvWg/BW4iP8mpEWWqRxUceNHFmZ\n\ty89XXbSFpJI15g8OGnMvrHFFmMINzfYm0fDn/xtHIVXPVhHnjZm5B1kyylCWDOwsNM9+\n\tSJUh++Lx+xOA7e9cuyu0OdvR9nRYtzhQ04ikb3x9I12EIetHU0TkG8kF2+JQMCvGXoft\n\tcCwQ==", "X-Gm-Message-State": "AHPjjUibt5nJMMO7O62RNgIE2hAYdwO7mYX8q+tfeLxnoE5YxQHfwgad\n\tZlWrnGcgBoOzhq5p", "X-Google-Smtp-Source": "AOwi7QBPhEwLUWkbhW2k6f22+qSpT9+hcfRqY4FO9fo1kisE2RcgRnngMEc03hxNLcgpHBHceQ7QHQ==", "X-Received": "by 10.202.228.147 with SMTP id\n\tb141mr33512343oih.180.1505597019406; \n\tSat, 16 Sep 2017 14:23:39 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Sat, 16 Sep 2017 15:23:13 -0600", "Message-Id": "<20170916212331.170463-1-sjg@chromium.org>", "X-Mailer": "git-send-email 2.14.1.690.gbb1197296e-goog", "X-Mailman-Approved-At": "Sat, 16 Sep 2017 21:31:43 +0000", "Cc": "Jan Kiszka <jan.kiszka@siemens.com>, Jagan Teki <jteki@openedev.com>,\n\tChris Packham <judge.packham@gmail.com>, Franklin <fcooper@ti.com>, \n\tMarek Vasut <marex@denx.de>, Tom Rini <trini@konsulko.com>, \n\t\"xypron.glpk@gmx.de\" <xypron.glpk@gmx.de>, \"Andreas J. Reichel\"\n\t<Andreas.Reichel@tngtech.com>, Michal Simek <michal.simek@xilinx.com>,\n\tWilson Lee <wilson.lee@ni.com>, Stefan Roese <sr@denx.de>,\n\tThomas Petazzoni <thomas.petazzoni@free-electrons.com>, \n\t=?utf-8?q?=C5=81ukasz_Majewski?= <l.majewski@samsung.com>,\n\tAndre Przywara <andre.przywara@arm.com>, Andy Shevchenko\n\t<andriy.shevchenko@linux.intel.com>, Jagan Teki <jagan@openedev.com>,\n\tRick Altherr <raltherr@google.com>, Andy Yan <andy.yan@rock-chips.com>, \n\tMaxime Ripard <maxime.ripard@free-electrons.com>, \n\t=?utf-8?q?Stefan_Br=C3=BCns?= <stefan.bruens@rwth-aachen.de>", "Subject": "[U-Boot] [PATCH 00/13] log: Add a new logging feature", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "U-Boot currently has fairly rudimentary logging features. A basic printf()\nprovides console output and debug() provides debug output which is\nactivated if DEBUG is defined in the file containing the debug()\nstatements.\n\nIt would be useful to have a few more features:\n\n- control of debug output at runtime, so problems can potentially be\ndebugged without recompiling U-Boot\n- control of which subsystems output debug information, so that (for\nexample) it is possible to enable debugging for MMC or SATA at runtime\n- indication of severity with each message, so that the user can control\nwhether just errors are displayed, warnings, or all debug messages\n- sending logging information to different destinations, such as console,\nmemory, linux, etc,\n\nAt present U-Boot has a logbuffer feature which records output in a memory\nbuffer for later display or storage. This is useful but is not at present\nenabled for any board.\n\nThis series introduced a new logging system which supports:\n- various log levels from panic to debug\n- log categories including all uclasses and a few others\n- log drivers to which all log records can be sent\n- log filters which control which log records make it to which drivers\n\nEnabling logging with the default options does not add much to code size.\nBy default the maximum recorded log level is LOGL_INFO, meaning that debug\nmessages (and above) are discarded a build-time. Increasing this level\nprovides more run-time flexibility to enable/disable logging at the cost\nof increased code size.\n\nThis feature is by no means finished. The README provides a long list of\nfeatures and clean-ups that could be done. But hopefully this is a\nstarting point for improving this important area in U-Boot.\n\nThe series is available at u-boot-dm/log-working\n\n\nSimon Glass (13):\n Revert \"sandbox: remove os_putc() and os_puts()\"\n Revert \"sandbox: Drop special case console code for sandbox\"\n Move debug and logging support to a separate header\n mtdparts: Correct use of debug()\n Drop the log buffer\n log: Add an implemention of logging\n log: Add a console driver\n log: Add a 'log level' command\n log: Add a test command\n log: Plumb logging into the init sequence\n log: sandbox: Enable logging\n log: test: Add a pytest for logging\n log: Add documentation\n\n MAINTAINERS | 9 ++\n arch/sandbox/cpu/os.c | 11 ++\n cmd/Kconfig | 8 +\n cmd/Makefile | 2 +-\n cmd/log.c | 326 +++++---------------------------------\n cmd/mtdparts.c | 3 -\n common/Kconfig | 86 ++++++++++\n common/Makefile | 2 +\n common/board_f.c | 23 +--\n common/board_r.c | 27 +---\n common/console.c | 7 +\n common/image.c | 9 --\n common/log.c | 247 +++++++++++++++++++++++++++++\n common/log_console.c | 23 +++\n common/stdio.c | 6 -\n configs/sandbox_defconfig | 5 +-\n doc/README.log | 220 +++++++++++++++++++++++++\n include/asm-generic/global_data.h | 8 +-\n include/common.h | 64 +-------\n include/log.h | 311 ++++++++++++++++++++++++++++++++++++\n include/logbuff.h | 49 ------\n include/os.h | 20 +++\n include/post.h | 4 +-\n post/post.c | 9 --\n post/tests.c | 4 -\n scripts/config_whitelist.txt | 1 -\n test/Makefile | 1 +\n test/log/Makefile | 7 +\n test/log/log_test.c | 204 ++++++++++++++++++++++++\n test/py/tests/test_log.py | 106 +++++++++++++\n 30 files changed, 1322 insertions(+), 480 deletions(-)\n create mode 100644 common/log.c\n create mode 100644 common/log_console.c\n create mode 100644 doc/README.log\n create mode 100644 include/log.h\n delete mode 100644 include/logbuff.h\n create mode 100644 test/log/Makefile\n create mode 100644 test/log/log_test.c\n create mode 100644 test/py/tests/test_log.py" }