Cover Letter Detail
Show a cover letter.
GET /api/covers/813483/?format=api
{ "id": 813483, "url": "http://patchwork.ozlabs.org/api/covers/813483/?format=api", "web_url": "http://patchwork.ozlabs.org/project/devicetree-bindings/cover/cover.1505140980.git.dave.stevenson@raspberrypi.org/", "project": { "id": 37, "url": "http://patchwork.ozlabs.org/api/projects/37/?format=api", "name": "Devicetree Bindings", "link_name": "devicetree-bindings", "list_id": "devicetree.vger.kernel.org", "list_email": "devicetree@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<cover.1505140980.git.dave.stevenson@raspberrypi.org>", "list_archive_url": null, "date": "2017-09-13T15:07:45", "name": "[v2,0/4] BCM283x Camera Receiver driver", "submitter": { "id": 72357, "url": "http://patchwork.ozlabs.org/api/people/72357/?format=api", "name": "Dave Stevenson", "email": "dave.stevenson@raspberrypi.org" }, "mbox": "http://patchwork.ozlabs.org/project/devicetree-bindings/cover/cover.1505140980.git.dave.stevenson@raspberrypi.org/mbox/", "series": [ { "id": 2936, "url": "http://patchwork.ozlabs.org/api/series/2936/?format=api", "web_url": "http://patchwork.ozlabs.org/project/devicetree-bindings/list/?series=2936", "date": "2017-09-13T15:07:47", "name": "BCM283x Camera Receiver driver", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/2936/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/813483/comments/", "headers": { "Return-Path": "<devicetree-owner@vger.kernel.org>", "X-Original-To": "incoming-dt@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming-dt@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=raspberrypi.org header.i=@raspberrypi.org\n\theader.b=\"MD2G7ds+\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi-org.20150623.gappssmtp.com\n\theader.i=@raspberrypi-org.20150623.gappssmtp.com header.b=\"MMnO1Mo+\"; \n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xslZl3S0Hz9sPk\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 01:14:55 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752412AbdIMPOw (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 11:14:52 -0400", "from mx07-00252a01.pphosted.com ([62.209.51.214]:56008 \"EHLO\n\tmx07-00252a01.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752222AbdIMPOk (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Wed, 13 Sep 2017 11:14:40 -0400", "from pps.filterd (m0102628.ppops.net [127.0.0.1])\n\tby mx07-00252a01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8DF5vci023934\n\tfor <devicetree@vger.kernel.org>; Wed, 13 Sep 2017 16:08:42 +0100", "from mail-wm0-f71.google.com (mail-wm0-f71.google.com\n\t[74.125.82.71])\n\tby mx07-00252a01.pphosted.com with ESMTP id 2cv5pysxk8-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128\n\tverify=OK)\n\tfor <devicetree@vger.kernel.org>; Wed, 13 Sep 2017 16:08:41 +0100", "by mail-wm0-f71.google.com with SMTP id m127so1058072wmm.3\n\tfor <devicetree@vger.kernel.org>;\n\tWed, 13 Sep 2017 08:08:41 -0700 (PDT)", "from dave-VirtualBox.pitowers.org ([217.33.127.173])\n\tby smtp.googlemail.com with ESMTPSA id\n\tn71sm1127985wmg.20.2017.09.13.08.08.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 13 Sep 2017 08:08:39 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.org;\n\th=from : to : cc : subject : date : message-id; s=pp;\n\tbh=LxrFSlG8njOM7M4q2myqXn5ng+LmkaFhcZl47QIq9yM=;\n\tb=MD2G7ds+lRwFPfNdkuZcPwcTvqTzzCzzW2G+5uiSqekMOMYjoCNw7YwtC9qF9KaomhjM\n\tItpAHHoMDT0FBjq5DLLRit6kEW0jLZNbH+qVxqRFuno8QDDSncDL7ItRiOYbWKElsDtq\n\trhINNJ4mZruNUTdWf1svAahdbIIleBOWbJHrWe2qnz+fuvq4oWLLfr0L7vhCqncJdHdz\n\tb8iPfLx8lkFONUuC7JFpzaH2FxZ6FNg36La8aeVPf9+g6f+JCCP8svOQdsAZQ+pZsv+H\n\tjXh1mGuf0cjmBrp3c9s/3ciR2otsbA3C9gOdrNrW3ZRFT2g2BkEsaeXqFSpY/9gDHluu\n\tIw== ", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=LxrFSlG8njOM7M4q2myqXn5ng+LmkaFhcZl47QIq9yM=;\n\tb=MMnO1Mo+cvLaTJJV8WGk/WoNLGudfgiFwY9OfIYl62ju2kv+Rk+3YG4fLHH07m0YwN\n\tRI88hWXnalo+/YNpAkNGNQ5Anh8dlyBnUzu0SY+07NXzlP2Cu2U9tAqcUD866oAPG8dt\n\t6HBrNNu2ilQn4ioSXMyOYVcpaQDjiJ8OMkW0+fVw6B/IBBiMA2PI7RtVuef+kH40NwLd\n\tSmGxEaqcl1eocPBIiKP7ybb6oOYNFlknSo1FEF9Kfk9FAWGCNB8ugNyfai2Z1WtPHRrV\n\t0SjgUlSkXW//YGBWEpuvEGoqhdeOHthCZPNOrHBSKEcHRh/BZttM3NQBQnmyytHHdwTW\n\tFTpQ==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=LxrFSlG8njOM7M4q2myqXn5ng+LmkaFhcZl47QIq9yM=;\n\tb=f2MRmMA6LwcNXf6/ZMsEK1sj3n+hNht5QYk5W5vijVGGGFzfxg9YcCOiErYI1S6qSo\n\tHBcZjHT9KkMfpgGKpVO8+lUxabfi9ZjU5T+yJNbSWEiGSG/opitvdFmo57cGq28/rdTW\n\tIenhfz6gaQvPMyLN5Ni8egd6Aid3HpyCWKhv0KMdyhzT8l1iPeK/e4T51uQc9Mf0rmAs\n\t7VhHl4DuwGDF4JcD9zG/wKjz47Q4gbs0S/7UdVPcjT2Rzhl4U26Nmf8lF1Mn2MnuKSZl\n\tiA9mximbpoK0KY2oU6auCDnLThYd07NyTQMocUjvBaSHIItpJW2o4NRNwpm1cerm44rG\n\tMOMw==", "X-Gm-Message-State": "AHPjjUjwA1OkQ8+BGl1h4oEA5ftM6CoLLC+TLuwLtadkx/QN7zYkOzJw\n\tzqhYvVeRgxr81NMQYxWsDZTP7sqR+iH428GHZFJuauzqJVPDHvqQXc1jUYpUNTK3KnRFCIiuAt+\n\tRgxi75/Pu0PWY", "X-Received": [ "by 10.28.92.136 with SMTP id q130mr2742183wmb.35.1505315321058; \n\tWed, 13 Sep 2017 08:08:41 -0700 (PDT)", "by 10.28.92.136 with SMTP id q130mr2742167wmb.35.1505315320785; \n\tWed, 13 Sep 2017 08:08:40 -0700 (PDT)" ], "X-Google-Smtp-Source": "AOwi7QAOqWsjW/RUdRhd7Ewe1fiYV3WT9gtc/RrP2iDO3719zJRLssAgUGTqIKNzn/qPX7VSnXVJ2A==", "From": "Dave Stevenson <dave.stevenson@raspberrypi.org>", "To": "Mauro Carvalho Chehab <mchehab@kernel.org>,\n\tRob Herring <robh+dt@kernel.org>, Hans Verkuil <hans.verkuil@cisco.com>, \n\tEric Anholt <eric@anholt.net>, Stefan Wahren <stefan.wahren@i2se.com>,\n\tSakari Ailus <sakari.ailus@iki.fi>,\n\tlinux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,\n\tdevicetree@vger.kernel.org", "Cc": "Dave Stevenson <dave.stevenson@raspberrypi.org>", "Subject": "[PATCH v2 0/4] BCM283x Camera Receiver driver", "Date": "Wed, 13 Sep 2017 16:07:45 +0100", "Message-Id": "<cover.1505140980.git.dave.stevenson@raspberrypi.org>", "X-Mailer": "git-send-email 2.7.4", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-13_04:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_spam_notspam policy=outbound_spam\n\tscore=0 priorityscore=1501\n\tmalwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1709130236", "Sender": "devicetree-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<devicetree.vger.kernel.org>", "X-Mailing-List": "devicetree@vger.kernel.org" }, "content": "Hi All.\n\nThis is v2 for adding a V4L2 subdevice driver for the CSI2/CCP2 camera\nreceiver peripheral on BCM283x, as used on Raspberry Pi.\nSorry for the delay since v1 - other tasks assigned, got sucked\ninto investigating why some devices were misbehaving, and\npicking up on new features that had been added to the tree (eg CCP2).\n\nv4l2-compliance results depend on the sensor subdevice connected to.\nI have results for TC358743, ADV7282M, and OV5647 that I'll\nsend them as a follow up email.\n\nOV647 and ADV7282M are now working with this driver, as well as TC358743.\nv1 of the driver only supported continuous clock mode which Unicam was\nfailing to lock on to correctly.\nThe driver now checks the clock mode and adjusts termination accordingly.\nSomething is still a little off for OV5647, but I'll investigate that\nlater.\n\nAs per the v1 discussion with Hans, I have added text describing the\ndifferences between this driver and the one in staging/vc04_service.\nAddressing some of the issues in the bcm2835-camera driver is on my to-do\nlist, and I'll add similar text there when I'm dealing with that.\n\nFor those wanting to see the driver in context,\nhttps://github.com/6by9/upstream-linux/tree/unicam is the linux-media\ntree with my mods on top. It also includes a couple of TC358743 and\nOV5647 driver updates that I'll send to the list in the next few days.\n\nThanks in advance.\n Dave\n\nChanges from v1 to v2:\n- Broken out a new helper function v4l2_fourcc2s as requested by Hans.\n- Documented difference between this driver and the bcm2835-camera driver\n in staging/vc04_services.\n- Corrected handling of s_dv_timings and s_std to update the current format\n but only if not streaming. This refactored some of the s_fmt code to\n remove duplication.\n- Updated handling of sizeimage to include vertical padding. (Not updated\n the bytesperline calcs as the app can override).\n- Added support for continuous clock mode (requires changes to lane\n termination configuration).\n- Add support for CCP2 as Sakari's patches to support it have now been merged.\n I don't have a suitable sensor to test it with at present, but all settings\n have been taken from a known working configuration. If people would prefer\n I remove this until it has been proved against hardware then I'm happy to\n do so.\n- Updated DT bindings to use <data-lanes> on the Unicam node to set the\n maximum number of lanes present instead of a having a custom property.\n Documents the mandatory endpoint properties.\n- Removed RAW16 from the list of input formats as it isn't defined in the\n CSI-2 spec. The peripheral can still unpack the other Bayer formats to\n a 16 bit/pixel packing though.\n- Added a log-status handler to get the status from the sensor.\n- Automatically switch away from any interlaced formats reported via g_fmt,\n or that are attempted to be set via try/s_fmt.\n- Addressed other more minor code review comments from v1.\n\nDave Stevenson (4):\n [media] v4l2-common: Add helper function for fourcc to string\n [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver\n [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface\n MAINTAINERS: Add entry for BCM2835 camera driver\n\n .../devicetree/bindings/media/bcm2835-unicam.txt | 107 +\n MAINTAINERS | 7 +\n drivers/media/platform/Kconfig | 1 +\n drivers/media/platform/Makefile | 1 +\n drivers/media/platform/bcm2835/Kconfig | 14 +\n drivers/media/platform/bcm2835/Makefile | 3 +\n drivers/media/platform/bcm2835/bcm2835-unicam.c | 2192 ++++++++++++++++++++\n drivers/media/platform/bcm2835/vc4-regs-unicam.h | 264 +++\n drivers/media/v4l2-core/v4l2-common.c | 18 +\n include/media/v4l2-common.h | 3 +\n 10 files changed, 2610 insertions(+)\n create mode 100644 Documentation/devicetree/bindings/media/bcm2835-unicam.txt\n create mode 100644 drivers/media/platform/bcm2835/Kconfig\n create mode 100644 drivers/media/platform/bcm2835/Makefile\n create mode 100644 drivers/media/platform/bcm2835/bcm2835-unicam.c\n create mode 100644 drivers/media/platform/bcm2835/vc4-regs-unicam.h" }