Cover Letter Detail
Show a cover letter.
GET /api/covers/812187/?format=api
{ "id": 812187, "url": "http://patchwork.ozlabs.org/api/covers/812187/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-imx/cover/20170910214424.14945-1-linus.walleij@linaro.org/", "project": { "id": 19, "url": "http://patchwork.ozlabs.org/api/projects/19/?format=api", "name": "Linux IMX development", "link_name": "linux-imx", "list_id": "linux-imx-kernel.lists.patchwork.ozlabs.org", "list_email": "linux-imx-kernel@lists.patchwork.ozlabs.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170910214424.14945-1-linus.walleij@linaro.org>", "list_archive_url": null, "date": "2017-09-10T21:44:19", "name": "[0/5] I2C GPIO to use gpiolibs open drain", "submitter": { "id": 7055, "url": "http://patchwork.ozlabs.org/api/people/7055/?format=api", "name": "Linus Walleij", "email": "linus.walleij@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/linux-imx/cover/20170910214424.14945-1-linus.walleij@linaro.org/mbox/", "series": [ { "id": 2420, "url": "http://patchwork.ozlabs.org/api/series/2420/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-imx/list/?series=2420", "date": "2017-09-10T21:44:19", "name": "I2C GPIO to use gpiolibs open drain", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2420/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/812187/comments/", "headers": { "Return-Path": "<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming-imx@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming-imx@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"oZ0gJvB2\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"jp/3LAPv\"; dkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xr4NW2qDCz9s4s\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 07:45:12 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drA2M-0007eA-2f; Sun, 10 Sep 2017 21:45:06 +0000", "from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drA2H-0007Cp-AO for linux-arm-kernel@lists.infradead.org;\n\tSun, 10 Sep 2017 21:45:03 +0000", "by mail-lf0-x236.google.com with SMTP id l196so14429502lfl.1\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tSun, 10 Sep 2017 14:44:39 -0700 (PDT)", "from fabina.bredbandsbolaget.se\n\t(c-2209e055.014-348-6c756e10.cust.bredbandsbolaget.se. [85.224.9.34])\n\tby smtp.gmail.com with ESMTPSA id\n\tc69sm1461546ljd.42.2017.09.10.14.44.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 10 Sep 2017 14:44:37 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:\n\tSubject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:\n\tReferences:List-Owner; bh=ki8PmXmOolwzUrHV8VUPSCNSG7hcaVKwL6mKVTOjPVU=;\n\tb=oZ0\n\tgJvB2u55sg9cU93GlcZZh3W6UJtaCOqZ+cmvWGYXf2PwKmN1wJiXlb7KVIDuvsYyc8FjWepcpahAU\n\t30WT1NXk0hxV4Sq30nOS3E+Wao0j9hLg2TPXHQ0C4Q/+ZPO1C1S8mfTGJb78p70J+NCHVOphGEV0C\n\tXgs9d5dHByXsr8tGYngbv/EZGs9XFeSy3aixSPoe0excxNvcQL4Hbzqz3FuDGxNq35GrTSub04NvS\n\t+el9/wZNOkuDX/gb/QmW9B6RcasF/ZNT9IkSzDlYZykty3oxulRnjCyy0hCICwlNNer3yVeEfAOo1\n\tbuVLHTATLVHrZfSRPvEtidsRTUvpgew==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=NPJnt6DBOZyDbXy7i482J3lzooUWfFSBp/M/l+4Dbh8=;\n\tb=jp/3LAPvQbClEMWTE4P//+aiHN4qx7JriZyGZlDNdASSRyBpG1h0K6VCkHz9bD9BqL\n\t/sanxFrPHfr29NvfePBvOj3K5UmUNZRS1npTmLLZG0hxqO68pzNyUcboQtp54yLTHR+z\n\tkjr4AgGp60dX5P4ZsGXNKaC0FcEwPJ5AgjFbE=" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=NPJnt6DBOZyDbXy7i482J3lzooUWfFSBp/M/l+4Dbh8=;\n\tb=prU30j/WtBlhxRT/anE1+NnC9kxBEyViGPL12GKNuQMu0lPNiMWNzOPgNisFtQRC2P\n\t7rhqdCcHDeAW8ZUglCvq1w9crFJoHcTX6Jag9vldxN6HqsbMUJdkAHbDc8kmQGSXTd2M\n\tdp8TDMkgxFLzIWMD/gj/y5hc3F8IwLNTG70GOkBAduuE3OcuVAss0blTNrJfgL4OlImj\n\tQ5BeNgzA7uT6nrronH2yKgFwAxjBRHsVOov4KL+WhkYxKXRgJjV8Inc0SUF2Em0D6fXB\n\txkyazT8cXgauTM9UNeYjxF9nPkYl/0TmhoiXCEK6KqYM3SHpyuWZJ0dtyA4gbJhX+jo/\n\t3CmQ==", "X-Gm-Message-State": "AHPjjUh3g+ybsB4yh9Sj/wTVR0xd2VfNy6bfyynrdsoSn7PWcYE+hXny\n\tqZU7CJDvSVn35+lZ", "X-Google-Smtp-Source": "AOwi7QDyf/JwYlqFfcj+Cx0MR/HOs43sn7Dc5+qe1OA9/UQt+4gsPNeuGp6qeFpkPUbZsNcE21Bp/Q==", "X-Received": "by 10.25.155.71 with SMTP id d68mr2481468lfe.181.1505079877815; \n\tSun, 10 Sep 2017 14:44:37 -0700 (PDT)", "From": "Linus Walleij <linus.walleij@linaro.org>", "To": "Wolfram Sang <wsa@the-dreams.de>,\n\tlinux-i2c@vger.kernel.org", "Subject": "[PATCH 0/5] I2C GPIO to use gpiolibs open drain", "Date": "Sun, 10 Sep 2017 23:44:19 +0200", "Message-Id": "<20170910214424.14945-1-linus.walleij@linaro.org>", "X-Mailer": "git-send-email 2.13.5", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170910_144501_797169_E2A9703B ", "X-CRM114-Status": "GOOD ( 12.79 )", "X-Spam-Score": "-0.2 (/)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a00:1450:4010:c07:0:0:0:236 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t2.5 SUSPICIOUS_RECIPS Similar addresses in recipient list\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "X-BeenThere": "linux-arm-kernel@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-arm-kernel/>", "List-Post": "<mailto:linux-arm-kernel@lists.infradead.org>", "List-Help": "<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>", "Cc": "linux-mips@linux-mips.org, Linus Walleij <linus.walleij@linaro.org>,\n\tadi-buildroot-devel@lists.sourceforge.net,\n\tlinux-arm-kernel@lists.infradead.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>", "Errors-To": "linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org", "List-Id": "linux-imx-kernel.lists.patchwork.ozlabs.org" }, "content": "I recently looked at this driver when testing the I2C GPIO\non the Gemini platform.\n\nIt's one of the archectypical places in the kernel where we\nhave open coded open drain emulation, also without much\nexplanation. So I went in and fixed it.\n\nThe fix is pretty brutal changing all boards and one MFD\ndevice using this, but I like the end result, making the\ncode much more readable and skipping the intermediate step\nof looping through the old GPIO API.\n\nIt would be nice to get some testing and ACKs on this if\npeople agree.\n\nI imagine Wolfram would use the whole thing into the I2C\ntree but I could also carry a branch in GPIO to be merged\nthrough the GPIO tree if it is preferred (like e.g. Wolfram\nwant me to get the heat for any regressions, hehe).\n\nLinus Walleij (5):\n i2c: gpio: Convert to use descriptors\n gpio: Make it possible for consumers to enforce open drain\n i2c: gpio: Enforce open drain through gpiolib\n i2c: gpio: Augment all boardfiles to use open drain\n i2c: gpio: Local vars in probe\n\n arch/arm/mach-ep93xx/core.c | 41 +++---\n arch/arm/mach-ep93xx/edb93xx.c | 15 +--\n arch/arm/mach-ep93xx/include/mach/platform.h | 4 +-\n arch/arm/mach-ep93xx/simone.c | 12 +-\n arch/arm/mach-ep93xx/snappercl15.c | 12 +-\n arch/arm/mach-ep93xx/vision_ep9307.c | 7 +-\n arch/arm/mach-ixp4xx/avila-setup.c | 17 ++-\n arch/arm/mach-ixp4xx/dsmg600-setup.c | 16 ++-\n arch/arm/mach-ixp4xx/fsg-setup.c | 16 ++-\n arch/arm/mach-ixp4xx/goramo_mlr.c | 24 +---\n arch/arm/mach-ixp4xx/ixdp425-setup.c | 16 ++-\n arch/arm/mach-ixp4xx/nas100d-setup.c | 16 ++-\n arch/arm/mach-ixp4xx/nslu2-setup.c | 16 ++-\n arch/arm/mach-ks8695/board-acs5k.c | 15 ++-\n arch/arm/mach-pxa/palmz72.c | 14 +-\n arch/arm/mach-pxa/viper.c | 27 +++-\n arch/arm/mach-sa1100/simpad.c | 14 +-\n arch/blackfin/mach-bf533/boards/blackstamp.c | 19 ++-\n arch/blackfin/mach-bf533/boards/ezkit.c | 18 ++-\n arch/blackfin/mach-bf533/boards/stamp.c | 18 ++-\n arch/blackfin/mach-bf561/boards/ezkit.c | 18 ++-\n arch/mips/alchemy/board-gpr.c | 23 +++-\n arch/mips/ath79/mach-pb44.c | 16 ++-\n drivers/gpio/gpiolib.c | 13 ++\n drivers/i2c/busses/i2c-gpio.c | 184 +++++++++++----------------\n drivers/mfd/sm501.c | 49 +++----\n include/linux/gpio/consumer.h | 6 +\n include/linux/i2c-gpio.h | 4 -\n 28 files changed, 372 insertions(+), 278 deletions(-)" }