Cover Letter Detail
Show a cover letter.
GET /api/covers/811310/?format=api
{ "id": 811310, "url": "http://patchwork.ozlabs.org/api/covers/811310/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/cover/20170908043919.6924-1-andrew@aj.id.au/", "project": { "id": 56, "url": "http://patchwork.ozlabs.org/api/projects/56/?format=api", "name": "OpenBMC development", "link_name": "openbmc", "list_id": "openbmc.lists.ozlabs.org", "list_email": "openbmc@lists.ozlabs.org", "web_url": "http://github.com/openbmc/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908043919.6924-1-andrew@aj.id.au>", "list_archive_url": null, "date": "2017-09-08T04:39:16", "name": "[v3,0/3] pmbus: Expand fan support and add MAX31785 driver", "submitter": { "id": 68332, "url": "http://patchwork.ozlabs.org/api/people/68332/?format=api", "name": "Andrew Jeffery", "email": "andrew@aj.id.au" }, "mbox": "http://patchwork.ozlabs.org/project/openbmc/cover/20170908043919.6924-1-andrew@aj.id.au/mbox/", "series": [ { "id": 2097, "url": "http://patchwork.ozlabs.org/api/series/2097/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openbmc/list/?series=2097", "date": "2017-09-08T04:39:16", "name": "pmbus: Expand fan support and add MAX31785 driver", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2097/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/811310/comments/", "headers": { "Return-Path": "<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "openbmc@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpPkY0MF2z9sCZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 14:40:05 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpPkX4Gq0zDrZC\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 14:40:04 +1000 (AEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpPkP050mzDrYl\n\tfor <openbmc@lists.ozlabs.org>; Fri, 8 Sep 2017 14:39:56 +1000 (AEST)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 403BA20C2E;\n\tFri, 8 Sep 2017 00:39:54 -0400 (EDT)", "from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Fri, 08 Sep 2017 00:39:54 -0400", "from keelia.ozlabs.ibm.com (unknown [122.99.82.10])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id A5F1C7E426;\n\tFri, 8 Sep 2017 00:39:50 -0400 (EDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"cPgoLtmN\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"f/FROIU3\"; \n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"cPgoLtmN\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"f/FROIU3\"; \n\tdkim-atps=neutral", "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=aj.id.au\n\t(client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com;\n\tenvelope-from=andrew@aj.id.au; receiver=<UNKNOWN>)", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"cPgoLtmN\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"f/FROIU3\"; dkim-atps=neutral" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:date:from:message-id:subject:to:x-me-sender:x-me-sender\n\t:x-sasl-enc:x-sasl-enc; s=fm1; bh=XurISloHHBKEtVN9t2FNQkOwHyFacX\n\t0qGn86AEQ0HIY=; b=cPgoLtmNsymSu8V0KrXkB1KqyKTpLQTGozqTylxK57kyl5\n\tePhKq21gw5HrO+BYDyS/vXgUhOgBvuVqq9FUh0HiSPcxhWi2XjGvyqplok9EIGqw\n\ti5TGs5Rn8Ydi1cYjU+oS4Wo+0v/FDmSJ1d5ljZpHOFmrZ10wYg4xFZTLZl5RwdGN\n\tlcSFxNR0jvgajPdXX+Ayz5GeveokD0Ou3AzsvQdDgw3u/vrPCY4XhylaS83AnmiQ\n\tbarjwejfhk09zyaTQqTkuf09FAOYCIhQYAATM95X0aNX6+Bad0/MR1ROW4dCadb7\n\t3pTch2U+WHPFopfXQzjUamRRV4UH/fUKlU2Yk8HA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=XurISl\n\toHHBKEtVN9t2FNQkOwHyFacX0qGn86AEQ0HIY=; b=f/FROIU3pgZX0Tt9+Cfpve\n\tz5cpug8pB53vhcjRQlPl8TNvyVxZmgCj4bbcsvASRcLzwmgx9rTceX/lnhGJL/R3\n\tNSdK3K4eXTGRZ4PkiLebcFigj6KLJrXcwxGJ6vCavBWyYbNVLuR+IICMhtPdjGVy\n\tl6GAhsMlds3KDu4vuNIiXqdzWd6iZltUv/ZCmVmWP65psE+xVvWfp3HTrOiPLZa9\n\tMgetyZZAexcwwfqL5pylH8maEcXnsycJbD9g1PgvTN/rObgoZMMjJCHWVATy6MWc\n\tKYWXkJlLgiY85G/0lv6NxoA4ZstbRr1E4MKwkYGmjEvBYSjWy7bFBLHKSv3o5s3w\n\t==" ], "X-ME-Sender": "<xms:Gh-yWRa8iuvRQ8bkaPitRF6V7ajLBo4-wEp2xi5RQFk0qBwd95RVIA>", "X-Sasl-enc": "ZXipFXAmx48z5H5pREC+/6apuDIAKeob2ne2zVomVQnk 1504845593", "From": "Andrew Jeffery <andrew@aj.id.au>", "To": "linux@roeck-us.net,\n\tlinux-hwmon@vger.kernel.org", "Subject": "[PATCH v3 0/3] pmbus: Expand fan support and add MAX31785 driver", "Date": "Fri, 8 Sep 2017 14:39:16 +1000", "Message-Id": "<20170908043919.6924-1-andrew@aj.id.au>", "X-Mailer": "git-send-email 2.11.0", "X-BeenThere": "openbmc@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Development list for OpenBMC <openbmc.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/openbmc/>", "List-Post": "<mailto:openbmc@lists.ozlabs.org>", "List-Help": "<mailto:openbmc-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>", "Cc": "mark.rutland@arm.com, devicetree@vger.kernel.org, jdelvare@suse.com,\n\tAndrew Jeffery <andrew@aj.id.au>, openbmc@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org, robh+dt@kernel.org", "Errors-To": "openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Hello,\n\nThese three patches lay the ground work for fan control in the pmbus core and\nintroduce a driver for the MAX31785 Intelligent Fan Controller that makes use\nof the new control features.\n\nSince v2[1] I've addressed Rob's comments on the bindings, integrating the thermal\nsupport and cleaning up some warts. One of the warts was regarding the\nmaxim,tmp-fans property which was switched to use a list of fan phandles rather\nthan indexes. A corresponding change is made in the driver. I also did a\ncomparison with the Aspeed PWM/Tach bindings but I'm not convinced there's much\nto take away from it other than those bindings are somewhat broken.\n\nIn v3 I've dropped patch 4 from v2, which was a bunch of work-arounds for bad\nbehaviour I observed in testing. At this stage the bad behaviour appears to be\na product of the larger hardware design, not necessarily a problem with the\nMaxim chip. Guenter has performed some quick testing of a cut-down v2 driver\nagainst the MAX31785 evaluation board and couldn't reproduce the results I was\nseeing[2][3], which increases the likelyhood that it's not the Maxim chip and\nthe work-around patch is inappropriate.\n\nPlease review!\n\nAndrew\n\n[1] https://lkml.org/lkml/2017/8/2/88\n[2] https://lkml.org/lkml/2017/9/7/669\n[3] https://lkml.org/lkml/2017/9/5/53\n\nAndrew Jeffery (3):\n dt-bindings: hwmon: pmbus: Add Maxim MAX31785 documentation\n hwmon: pmbus: Add fan control support\n pmbus: Add driver for Maxim MAX31785 Intelligent Fan Controller\n\n .../devicetree/bindings/hwmon/pmbus/max31785.txt | 158 +++++\n drivers/hwmon/pmbus/Kconfig | 10 +\n drivers/hwmon/pmbus/Makefile | 1 +\n drivers/hwmon/pmbus/max31785.c | 673 +++++++++++++++++++++\n drivers/hwmon/pmbus/pmbus.h | 29 +\n drivers/hwmon/pmbus/pmbus_core.c | 224 ++++++-\n 6 files changed, 1080 insertions(+), 15 deletions(-)\n create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/max31785.txt\n create mode 100644 drivers/hwmon/pmbus/max31785.c" }