Cover Letter Detail
Show a cover letter.
GET /api/covers/809357/?format=api
{ "id": 809357, "url": "http://patchwork.ozlabs.org/api/covers/809357/?format=api", "web_url": "http://patchwork.ozlabs.org/project/devicetree-bindings/cover/20170903213829.6589-1-martin.blumenstingl@googlemail.com/", "project": { "id": 37, "url": "http://patchwork.ozlabs.org/api/projects/37/?format=api", "name": "Devicetree Bindings", "link_name": "devicetree-bindings", "list_id": "devicetree.vger.kernel.org", "list_email": "devicetree@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903213829.6589-1-martin.blumenstingl@googlemail.com>", "list_archive_url": null, "date": "2017-09-03T21:38:26", "name": "[v4,0/3] initialize (multiple) PHYs in xhci-plat", "submitter": { "id": 66366, "url": "http://patchwork.ozlabs.org/api/people/66366/?format=api", "name": "Martin Blumenstingl", "email": "martin.blumenstingl@googlemail.com" }, "mbox": "http://patchwork.ozlabs.org/project/devicetree-bindings/cover/20170903213829.6589-1-martin.blumenstingl@googlemail.com/mbox/", "series": [ { "id": 1276, "url": "http://patchwork.ozlabs.org/api/series/1276/?format=api", "web_url": "http://patchwork.ozlabs.org/project/devicetree-bindings/list/?series=1276", "date": "2017-09-03T21:38:26", "name": "initialize (multiple) PHYs in xhci-plat", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/1276/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/809357/comments/", "headers": { "Return-Path": "<devicetree-owner@vger.kernel.org>", "X-Original-To": "incoming-dt@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming-dt@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"nBx75PJ9\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlmZT6VLBz9sRm\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tMon, 4 Sep 2017 07:38:57 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752974AbdICViz (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tSun, 3 Sep 2017 17:38:55 -0400", "from mail-wm0-f67.google.com ([74.125.82.67]:35430 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752130AbdICViy (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Sun, 3 Sep 2017 17:38:54 -0400", "by mail-wm0-f67.google.com with SMTP id e204so4854865wma.2;\n\tSun, 03 Sep 2017 14:38:54 -0700 (PDT)", "from blackbox.darklights.net\n\t(p200300DCD3D58204A0117FABC96C39BD.dip0.t-ipconnect.de.\n\t[2003:dc:d3d5:8204:a011:7fab:c96c:39bd])\n\tby smtp.googlemail.com with ESMTPSA id\n\te8sm17786198wmf.37.2017.09.03.14.38.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 03 Sep 2017 14:38:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=euYOFOnzG3PA0FdAY1YlJzjDIj4J8i7RNt6PO2XZ33w=;\n\tb=nBx75PJ9g+vqG8ey6WlSnVi9XiKxG9DyNuv7ljOhjdKIws8UpzS/sY0lhdib828JA+\n\tbqapgN+okRyY5GBydyDHNU9Nt7jp+zxEG1XOXB5d7j2TmrKQ0nhc8spu81F17Etti1hk\n\t643vHRvZFGucolMs4KM4U+9VeuhB9hgYxfLU10MFzCGn5iIHTWwDmQfpJ8yQsCCURbet\n\twBK96gXL7Z0Ppns8klppuYpomENduSaNAfRNto1Qg1zOD0egjnxuGJuUjglOpwqpFyzx\n\teprznSG1fvEVg0AhHsH+PFNgHuocyuuMbRPIr6+Et5A9h9ZaXsLKPlHGGcfwLhIp3qGO\n\tSlUg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=euYOFOnzG3PA0FdAY1YlJzjDIj4J8i7RNt6PO2XZ33w=;\n\tb=KJJU5vEXsXr0At6G5bNFimSB8Gokc4NyDTJzR3eGV0ATJGyu6qeAbOdRL0fElHW40S\n\ts9D8cYGqfsn+lWEwVHiiXzlOPRJYhioanztwETxsdUmLWAuvHjloqIybOPVgmR5FZXxR\n\t/S0RBz9KDEeQ8Zs6s4vDpxGPZWqemi3hQVlNCVQ4Ii057Bcx0glQ+nq5WIyEJ6ppKO9s\n\tCIYMLLHrj+wJlKR+htwyw6eoX0dIMV3/YEpi3Q+nz2FWCgNh6dTOlg0AW7JWEQ8Ey0Yi\n\tg7jm/p7RpT1cqyCiCzp9T90+4tJJg5Tj1l7v94cb66FzzYfKD6Mtqr+YIi9bS1Elj+xI\n\tEEoA==", "X-Gm-Message-State": "AHPjjUjPG6+Bd2YpLAOmaelRP/SrBg/O3DjbfFdNw0Xu2ZWiGeVUm9xr\n\t+7MPmXMhjyNW9q6MyD8=", "X-Google-Smtp-Source": "ADKCNb7wpt89E/kHcLfJUnuPW+ULGxSncWXJGAsCAUtvUV8ejytK9kilrgpyjBNWNW6jXijs90hWBg==", "X-Received": "by 10.28.51.78 with SMTP id z75mr2745902wmz.160.1504474732911;\n\tSun, 03 Sep 2017 14:38:52 -0700 (PDT)", "From": "Martin Blumenstingl <martin.blumenstingl@googlemail.com>", "To": "linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,\n\tfelipe.balbi@linux.intel.com, mathias.nyman@intel.com", "Cc": "robh+dt@kernel.org, devicetree@vger.kernel.org,\n\tmark.rutland@arm.com, arnd@arndb.de,\n\tlinux-amlogic@lists.infradead.org, chunfeng.yun@mediatek.com,\n\tMartin Blumenstingl <martin.blumenstingl@googlemail.com>", "Subject": "[PATCH v4 0/3] initialize (multiple) PHYs in xhci-plat", "Date": "Sun, 3 Sep 2017 23:38:26 +0200", "Message-Id": "<20170903213829.6589-1-martin.blumenstingl@googlemail.com>", "X-Mailer": "git-send-email 2.14.1", "Sender": "devicetree-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<devicetree.vger.kernel.org>", "X-Mailing-List": "devicetree@vger.kernel.org" }, "content": "This series is the outcome of a discussion with Felipe Balbi,\nsee [0] and [1].\nThe quick-summary of this is:\n- dwc3 already takes one USB2 and one USB3 PHY and initializes these\n correct\n- some other HCI platform drivers (like ehci-platform.c, xhci-mtk.c and\n ohci-platform.c) do not have a limitation on the number of PHYs - they\n support one PHY per actual host port\n- Amlogic Meson GXL and GXM SoCs come with a dwc3 IP block which has two\n or three USB2 ports enabled on the internal root-hub. The SoCs also\n provide separate USB2 PHYs, one per port. All USB2 PHYs (which are\n internally \"connected\" to the dwc3 roothub) need to be powered on,\n otherwise USB devices cannot be enumerated (even if just one PHY is\n disabled and if the device is plugged into another, enabled port)\n\nIn my first attempt to get USB supported on the GXL and GXM SoCs I tried\nto work-around the problem that I could not pass multiple PHYs to the\ndwc3 controller.\nThis was rejected by Rob Herring (which was definitely the thing to do in\nmy opinion), see [2]\n\nThis series adds a new \"platform-roothub\". This can be configured through\ndevicetree by passing a child-node with \"reg = <0>\" to the USB\ncontroller. Additionally there has to be a child-node for each port on\nthe root-hub. Each of the child-nodes takes a \"phys\" and \"phy-names\"\nproperty. This allows modeling the root-hub in devicetree similar to the\nUSB device binding (documented in devicetree/bindings/usb/usb-device.txt)\nThis avoids and backwards-compatibility problems (which was a concern\nregardless of the solution, see [3]) since the binding for the root-hub\nwas previously not specified (and we're not using the \"phys\" property of\nthe controller, which might have served different purposes before,\ndepending on the drivers).\n\nAdditionally this integrates the new platform-roothub into xhci-plat.c\nwhich automatically enables it for the dwc3 driver (in host-mode).\n\n\nChanges since RFCv3 at [6]:\n- moved the DT binding change from patch #3 to patch #1 as suggested\n by Rob Herring (and slightly adjusted the commit message to account\n for that)\n- added Tested-by from Chunfeng Yun (who confirmed that the whole\n concept and implementation works fine on Mediatek SoCs - many thanks\n again!) to patch #2\n- added Rob Herring's ACK to patches 1 and 3\n- dropped RFC status (RFCv3 -> PATCH v4)\n\nChanges since RFCv2 at [5]:\n- split phy_{init,exit} and phy_power_{on,off} handling. up until RFCv2\n I called phy_init plus phy_power_on in platform_roothub_power_on and\n phy_power_off plus phy_exit in platform_roothub_power_off. However,\n Chunfeng Yun (a Mediatek SoC developer - many thanks for testing my\n series and providing great feedback) reported that only using\n phy_power_off (and omitting phy_exit) during system suspend fixes an\n issue where USB devices would be re-enumerated when resuming. His\n original problem description: \"In order to keep link state on mt8173,\n we just power off all phys(not exit) when system enter suspend, then\n power on them again (needn't init, otherwise device will be\n disconnected) when system resume, this can avoid re-enumerating\n device.\". This fix affects patch #2 and #3 as we now have\n platform_roothub_init (which calls phy_init internally),\n platform_roothub_power_on (which calls phy_power_on internally),\n platform_roothub_power_off (which calls phy_power_off internally) and\n platform_roothub_exit (which calls phy_exit internally). suspend and\n resume only call platform_roothub_power_{on,off} to prevent the issue\n described by Chunfeng Yun (unfortunately I cannot test this because\n the Amlogic platform currently does not support system suspend).\n- dropped two struct forward declarations from platform-roothub.h which\n are not used in the header file (thanks to Chunfeng Yun for spotting\n this)\n\nChanges since RFCv1 at [4]:\n- split the usb-xhci dt-binding documentation into a separate patch\n- fixed a typo (\"usb-phy\" -> \"phys\" in the dt-binding example)\n- rebased to apply against latest usb-next\n\n\n[0] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/001945.html\n[1] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/001947.html\n[2] http://lists.infradead.org/pipermail/linux-amlogic/2016-November/001818.html\n[3] http://lists.infradead.org/pipermail/linux-amlogic/2017-January/001948.html\n[4] http://marc.info/?l=linux-usb&m=148414866303604&w=2\n[5] https://www.spinics.net/lists/linux-usb/msg158967.html\n[6] https://www.spinics.net/lists/devicetree/msg190426.html\n\nMartin Blumenstingl (3):\n dt-bindings: usb: add the documentation for USB root-hub\n usb: host: add a generic platform USB roothub driver\n usb: host: xhci: plat: integrate the platform-roothub\n\n .../devicetree/bindings/usb/usb-roothub.txt | 46 ++++++\n Documentation/devicetree/bindings/usb/usb-xhci.txt | 7 +\n drivers/usb/host/Kconfig | 4 +\n drivers/usb/host/Makefile | 2 +\n drivers/usb/host/platform-roothub.c | 180 +++++++++++++++++++++\n drivers/usb/host/platform-roothub.h | 12 ++\n drivers/usb/host/xhci-plat.c | 35 +++-\n drivers/usb/host/xhci.h | 2 +\n 8 files changed, 286 insertions(+), 2 deletions(-)\n create mode 100644 Documentation/devicetree/bindings/usb/usb-roothub.txt\n create mode 100644 drivers/usb/host/platform-roothub.c\n create mode 100644 drivers/usb/host/platform-roothub.h" }