Cover Letter Detail
Show a cover letter.
GET /api/covers/808916/?format=api
{ "id": 808916, "url": "http://patchwork.ozlabs.org/api/covers/808916/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20170901180340.30009-1-eblake@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901180340.30009-1-eblake@redhat.com>", "list_archive_url": null, "date": "2017-09-01T18:03:11", "name": "[v6,00/29] Preliminary libqtest cleanups", "submitter": { "id": 6591, "url": "http://patchwork.ozlabs.org/api/people/6591/?format=api", "name": "Eric Blake", "email": "eblake@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20170901180340.30009-1-eblake@redhat.com/mbox/", "series": [ { "id": 1089, "url": "http://patchwork.ozlabs.org/api/series/1089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1089", "date": "2017-09-01T18:03:12", "name": "Preliminary libqtest cleanups", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/1089/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/808916/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkS2j543jz9sPt\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 04:10:18 +1000 (AEST)", "from localhost ([::1]:53110 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnqOW-0003xi-Dw\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 14:10:16 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:55595)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dnqII-0006yd-QH\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:52 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dnqIF-0001RB-Lv\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:50 -0400", "from mx1.redhat.com ([209.132.183.28]:50600)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>) id 1dnqIF-0001Qb-Ck\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:47 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AA18FC056784\n\tfor <qemu-devel@nongnu.org>; Fri, 1 Sep 2017 18:03:45 +0000 (UTC)", "from red.redhat.com (ovpn-121-149.rdu2.redhat.com [10.10.121.149])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 10AF6627DE;\n\tFri, 1 Sep 2017 18:03:44 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com AA18FC056784", "From": "Eric Blake <eblake@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 1 Sep 2017 13:03:11 -0500", "Message-Id": "<20170901180340.30009-1-eblake@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 01 Sep 2017 18:03:45 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v6 00/29] Preliminary libqtest cleanups", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "pbonzini@redhat.com, armbru@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Markus gave some good advice on my 'v4: Clean up around qmp() and hmp()'\nseries [1], but Paolo made the suggestion on v5 [2] that we are probably\nbetter off avoiding dependence on a magic global variable, rather than\nmaking such dependence even more prominent. So, this round of patches\nstarts to head in the direction of more explicit use of a QTestState\nobject - particularly in all tests that have more than one test state\nactive at a given time. There is still more work to do (patch 28 shows\nhow many tests still depend on global_qtest), and I'd still like to do\neven more renaming (for example, rather than having qtest_inb(s, addr)\nand inb(addr), I'd rather have a single inb(s, addr) once I get rid of\nall dependence on global_qtest, but this series was getting long\nenough that I want to get review started on the earlier parts that\nmight as well go in the tree now rather than waiting for the whole\nconversion series to be complete. (Or, by posting this alternative\nthat goes the opposite direction from v5, we may decide that depending\non global_qtest is not so bad after all, and just go with v5 instead\nof this version.)\n\nThere's still more libqtest cleanups in my queue, in particular all\nthe work around making qmp(\"...\") friendlier to use and compatible\nwith gcc -Wformat checking, but we'll take it one step at a time.\n\n[1] https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00595.html\n[2] https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg03589.html\n\nSince v5:\n001/29:[down] 'tests: Improve .gitignore for tests/multiboot'\n002/29:[down] 'tests: Sort .gitignore'\n003/29:[----] [--] 'test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code'\n004/29:[----] [--] 'qtest: Don't perform side effects inside assertion'\n005/29:[----] [--] 'numa-test: Use hmp()'\n006/29:[----] [-C] 'tests: Clean up wait for event'\n007/29:[----] [--] 'libqtest: Remove dead qtest_instances variable'\n008/29:[----] [--] 'libqtest: Let socket_send() compute length'\n009/29:[----] [--] 'libqtest: Use qemu_strtoul()'\n010/29:[----] [--] 'libqtest: Topologically sort functions'\n011/29:[----] [--] 'libqtest: Inline qtest_query_target_endianness()'\n012/29:[down] 'libqos: Track QTestState with QPCIBus'\n013/29:[down] 'libqos: Use explicit QTestState for pci operations'\n014/29:[down] 'libqos: Use explicit QTestState for fw_cfg operations'\n015/29:[down] 'libqos: Use explicit QTestState for rtas operations'\n016/29:[down] 'libqos: Use explicit QTestState for virtio operations'\n017/29:[down] 'ahci-test: Drop dependence on global_qtest'\n018/29:[down] 'ivshmem-test: Drop dependence on global_qtest'\n019/29:[down] 'postcopy-test: Drop dependence on global_qtest'\n020/29:[down] 'vhost-user-test: Drop dependence on global_qtest'\n021/29:[down] 'qmp-test: Drop dependence on global_qtest'\n022/29:[down] 'tests/boot-sector: Drop dependence on global_qtest'\n023/29:[down] 'tests/acpi-utils: Drop dependence on global_qtest'\n024/29:[down] 'bios-tables-test: Drop dependence on global_qtest'\n025/29:[down] 'wdt_ib700-test: Drop dependence on global_qtest'\n026/29:[down] 'fw_cfg-test: Drop dependence on global_qtest'\n027/29:[down] 'libqtest: Make qtest_init() accept format string'\n028/29:[down] 'libqtest: Remove qtest_start() and qtest_end() shortcuts'\n029/29:[down] 'libqtest: Rename qtest_init() to qtest_start()'\n\nEric Blake (28):\n tests: Improve .gitignore for tests/multiboot\n tests: Sort .gitignore\n test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code\n qtest: Don't perform side effects inside assertion\n numa-test: Use hmp()\n libqtest: Remove dead qtest_instances variable\n libqtest: Let socket_send() compute length\n libqtest: Use qemu_strtoul()\n libqtest: Topologically sort functions\n libqtest: Inline qtest_query_target_endianness()\n libqos: Track QTestState with QPCIBus\n libqos: Use explicit QTestState for pci operations\n libqos: Use explicit QTestState for fw_cfg operations\n libqos: Use explicit QTestState for rtas operations\n libqos: Use explicit QTestState for virtio operations\n ahci-test: Drop dependence on global_qtest\n ivshmem-test: Drop dependence on global_qtest\n postcopy-test: Drop dependence on global_qtest\n vhost-user-test: Drop dependence on global_qtest\n qmp-test: Drop dependence on global_qtest\n tests/boot-sector: Drop dependence on global_qtest\n tests/acpi-utils: Drop dependence on global_qtest\n bios-tables-test: Drop dependence on global_qtest\n wdt_ib700-test: Drop dependence on global_qtest\n fw_cfg-test: Drop dependence on global_qtest\n libqtest: Make qtest_init() accept format string\n libqtest: Remove qtest_start() and qtest_end() shortcuts\n libqtest: Rename qtest_init() to qtest_start()\n\nMarkus Armbruster (1):\n tests: Clean up wait for event\n\n tests/libqtest.h | 37 +-----\n tests/acpi-utils.h | 65 ++++-----\n tests/boot-sector.h | 6 +-\n tests/libqos/ahci.h | 2 +-\n tests/libqos/fw_cfg.h | 10 +-\n tests/libqos/libqos.h | 5 +-\n tests/libqos/malloc-pc.h | 4 +-\n tests/libqos/malloc-spapr.h | 2 +-\n tests/libqos/malloc.h | 1 +\n tests/libqos/pci-pc.h | 2 +-\n tests/libqos/pci-spapr.h | 2 +-\n tests/libqos/pci.h | 1 +\n tests/libqos/rtas.h | 9 +-\n tests/libqos/virtio-mmio.h | 3 +-\n tests/libqos/virtio.h | 5 +-\n tests/libqtest.c | 293 +++++++++++++++++++++--------------------\n qtest.c | 80 +++++++----\n tests/ac97-test.c | 4 +-\n tests/acpi-utils.c | 19 +--\n tests/ahci-test.c | 85 ++++++------\n tests/bios-tables-test.c | 198 ++++++++++++++--------------\n tests/boot-order-test.c | 19 ++-\n tests/boot-sector.c | 8 +-\n tests/boot-serial-test.c | 12 +-\n tests/device-introspect-test.c | 24 ++--\n tests/display-vga-test.c | 18 +--\n tests/drive_del-test.c | 17 +--\n tests/ds1338-test.c | 2 +-\n tests/e1000-test.c | 10 +-\n tests/e1000e-test.c | 24 ++--\n tests/eepro100-test.c | 11 +-\n tests/endianness-test.c | 33 ++---\n tests/es1370-test.c | 4 +-\n tests/fdc-test.c | 4 +-\n tests/fw_cfg-test.c | 13 +-\n tests/hd-geo-test.c | 16 +--\n tests/i440fx-test.c | 16 +--\n tests/i82801b11-test.c | 5 +-\n tests/ide-test.c | 8 +-\n tests/intel-hda-test.c | 11 +-\n tests/ioh3420-test.c | 7 +-\n tests/ipmi-bt-test.c | 11 +-\n tests/ipmi-kcs-test.c | 7 +-\n tests/ipoctal232-test.c | 5 +-\n tests/ivshmem-test.c | 22 +---\n tests/libqos/ahci.c | 49 +++----\n tests/libqos/fw_cfg.c | 14 +-\n tests/libqos/libqos-pc.c | 2 +-\n tests/libqos/libqos.c | 45 ++-----\n tests/libqos/malloc-pc.c | 8 +-\n tests/libqos/malloc-spapr.c | 4 +-\n tests/libqos/pci-pc.c | 58 ++++----\n tests/libqos/pci-spapr.c | 44 ++++---\n tests/libqos/rtas.c | 21 +--\n tests/libqos/virtio-mmio.c | 54 ++++----\n tests/libqos/virtio-pci.c | 3 +\n tests/libqos/virtio.c | 77 ++++++-----\n tests/m25p80-test.c | 9 +-\n tests/m48t59-test.c | 2 +-\n tests/ne2000-test.c | 4 +-\n tests/numa-test.c | 49 +++----\n tests/nvme-test.c | 7 +-\n tests/pc-cpu-test.c | 26 ++--\n tests/pcnet-test.c | 4 +-\n tests/pnv-xscom-test.c | 14 +-\n tests/postcopy-test.c | 86 ++++++------\n tests/prom-env-test.c | 13 +-\n tests/pvpanic-test.c | 4 +-\n tests/pxe-test.c | 16 +--\n tests/q35-test.c | 12 +-\n tests/qmp-test.c | 35 ++---\n tests/qom-test.c | 7 +-\n tests/rtas-test.c | 2 +-\n tests/rtc-test.c | 2 +-\n tests/rtl8139-test.c | 7 +-\n tests/spapr-phb-test.c | 5 +-\n tests/tco-test.c | 17 +--\n tests/test-arm-mptimer.c | 4 +-\n tests/test-filter-mirror.c | 16 +--\n tests/test-filter-redirector.c | 60 ++++-----\n tests/test-hmp.c | 7 +-\n tests/test-netfilter.c | 9 +-\n tests/test-qga.c | 90 -------------\n tests/test-x86-cpuid-compat.c | 13 +-\n tests/tmp105-test.c | 7 +-\n tests/tpci200-test.c | 4 +-\n tests/usb-hcd-ehci-test.c | 27 ++--\n tests/usb-hcd-ohci-test.c | 4 +-\n tests/usb-hcd-uhci-test.c | 6 +-\n tests/usb-hcd-xhci-test.c | 19 +--\n tests/vhost-user-test.c | 105 ++++++---------\n tests/virtio-balloon-test.c | 4 +-\n tests/virtio-blk-test.c | 16 +--\n tests/virtio-console-test.c | 12 +-\n tests/virtio-net-test.c | 4 +-\n tests/virtio-rng-test.c | 4 +-\n tests/virtio-serial-test.c | 4 +-\n tests/vmgenid-test.c | 49 +++----\n tests/vmxnet3-test.c | 4 +-\n tests/wdt_ib700-test.c | 84 ++++++------\n tests/.gitignore | 30 +++--\n 101 files changed, 1092 insertions(+), 1330 deletions(-)" }