Cover Letter Detail
Show a cover letter.
GET /api/covers/808763/?format=api
{ "id": 808763, "url": "http://patchwork.ozlabs.org/api/covers/808763/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/cover/cover.1504277892.git.g.nault@alphalink.fr/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<cover.1504277892.git.g.nault@alphalink.fr>", "list_archive_url": null, "date": "2017-09-01T15:58:45", "name": "[net,0/2] l2tp: session creation fixes", "submitter": { "id": 22975, "url": "http://patchwork.ozlabs.org/api/people/22975/?format=api", "name": "Guillaume Nault", "email": "g.nault@alphalink.fr" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/cover/cover.1504277892.git.g.nault@alphalink.fr/mbox/", "series": [ { "id": 1055, "url": "http://patchwork.ozlabs.org/api/series/1055/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1055", "date": "2017-09-01T15:58:48", "name": "l2tp: session creation fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1055/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/808763/comments/", "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkP754JfLz9t3P\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 2 Sep 2017 01:58:57 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752144AbdIAP6y (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 1 Sep 2017 11:58:54 -0400", "from zimbra.alphalink.fr ([217.15.80.77]:46012 \"EHLO\n\tzimbra.alphalink.fr\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752091AbdIAP6x (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 1 Sep 2017 11:58:53 -0400", "from localhost (localhost [127.0.0.1])\n\tby mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id\n\t4D64A2B52120; Fri, 1 Sep 2017 17:58:52 +0200 (CEST)", "from zimbra.alphalink.fr ([127.0.0.1])\n\tby localhost (mail-2-cbv2.admin.alphalink.fr [127.0.0.1])\n\t(amavisd-new, port 10032)\n\twith ESMTP id dzbHocpCCHkE; Fri, 1 Sep 2017 17:58:46 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n\tby mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id\n\t271D82B520A8; Fri, 1 Sep 2017 17:58:46 +0200 (CEST)", "from zimbra.alphalink.fr ([127.0.0.1])\n\tby localhost (mail-2-cbv2.admin.alphalink.fr [127.0.0.1])\n\t(amavisd-new, port 10026)\n\twith ESMTP id LQbv60lTFe2D; Fri, 1 Sep 2017 17:58:46 +0200 (CEST)", "from c-dev-0.admin.alphalink.fr (94-84-15-217.reverse.alphalink.fr\n\t[217.15.84.94])\n\tby mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id\n\t0085D2B52068; Fri, 1 Sep 2017 17:58:45 +0200 (CEST)", "by c-dev-0.admin.alphalink.fr (Postfix, from userid 1000)\n\tid B1F4A60141; Fri, 1 Sep 2017 17:58:45 +0200 (CEST)" ], "X-Virus-Scanned": "amavisd-new at mail-2-cbv2.admin.alphalink.fr", "Date": "Fri, 1 Sep 2017 17:58:45 +0200", "From": "Guillaume Nault <g.nault@alphalink.fr>", "To": "netdev@vger.kernel.org", "Cc": "James Chapman <jchapman@katalix.com>", "Subject": "[PATCH net 0/2] l2tp: session creation fixes", "Message-ID": "<cover.1504277892.git.g.nault@alphalink.fr>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-Mutt-Fcc": "=Sent", "User-Agent": "NeoMutt/20170609 (1.8.3)", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The session creation process has a few issues wrt. concurrent tunnel\ndeletion.\n\nPatch #1 avoids creating sessions in tunnels that are getting removed.\nThis prevents races where sessions could try to take tunnel resources\nthat were already released.\n\nPatch #2 removes some racy l2tp_tunnel_find() calls in session creation\ncallbacks. Together with path #1 it ensures that sessions can only\naccess tunnel resources that are guaranteed to remain valid during the\nsession creation process.\n\n\nThere are other problems with how sessions are created: pseudo-wire\nspecific data are set after the session is added to the tunnel. So\nthe session can be used, or deleted, before it has been completely\ninitialised. Separating session allocation from session registration\nwould be necessary, but we'd still have circular dependencies\npreventing race-free registration. I'll consider this issue in future\nseries.\n\n\nGuillaume Nault (2):\n l2tp: prevent creation of sessions on terminated tunnels\n l2tp: pass tunnel pointer to ->session_create()\n\n net/l2tp/l2tp_core.c | 41 ++++++++++++++++++++++++++++-------------\n net/l2tp/l2tp_core.h | 8 +++++++-\n net/l2tp/l2tp_eth.c | 11 +++--------\n net/l2tp/l2tp_netlink.c | 8 ++++----\n net/l2tp/l2tp_ppp.c | 19 +++++++------------\n 5 files changed, 49 insertions(+), 38 deletions(-)" }