Cover Letter Detail
Show a cover letter.
GET /api/covers/807103/?format=api
{ "id": 807103, "url": "http://patchwork.ozlabs.org/api/covers/807103/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>", "list_archive_url": null, "date": "2017-08-29T14:23:01", "name": "[v8,0/6] fsdev: qmp interface for io throttling", "submitter": { "id": 69852, "url": "http://patchwork.ozlabs.org/api/people/69852/?format=api", "name": "Pradeep Jagadeesh", "email": "pradeepkiruvale@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com/mbox/", "series": [ { "id": 377, "url": "http://patchwork.ozlabs.org/api/series/377/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=377", "date": "2017-08-29T14:23:01", "name": "fsdev: qmp interface for io throttling", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/377/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/807103/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rocZIt4t\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhW9n68nDz9t3V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 00:24:45 +1000 (AEST)", "from localhost ([::1]:45209 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmhRb-0001hT-Kv\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 10:24:43 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:53685)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pradeepkiruvale@gmail.com>) id 1dmhQx-0001g2-JK\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:24:04 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pradeepkiruvale@gmail.com>) id 1dmhQu-0004DL-Ee\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:24:03 -0400", "from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35423)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <pradeepkiruvale@gmail.com>)\n\tid 1dmhQu-0004CZ-7u\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 10:24:00 -0400", "by mail-wm0-x244.google.com with SMTP id e204so1188040wma.2\n\tfor <qemu-devel@nongnu.org>; Tue, 29 Aug 2017 07:23:58 -0700 (PDT)", "from localhost.localdomain.localdomain ([217.110.131.66])\n\tby smtp.gmail.com with ESMTPSA id\n\t15sm2540487wmv.45.2017.08.29.07.23.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 07:23:57 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=dFWTIHBeYUVu8f1znMA7XKhXw2I2IIqmC6cCqCwOGSA=;\n\tb=rocZIt4toEj0ogq57yAEkYMslySat2tKVMir6Zrsm4OwTQDqilcWvGipHuFOCqLJyS\n\tB6Gny7PTxbI3mfobBi1Vor8G4hvVj3tgu82p7POgY58+qJKWzNO7mFQNC+aFdrUkrz4B\n\tMdoWld5KKciL5U9Hnjp5nWXflzZrTckpV10bKWybC5OHeh7AFZ2IX4ezR3c7H3hdZ6tc\n\tfUZbbR28ZjYoBBCy5jfZr22KyUZUypf51CNEHtFdY9N/GruMR7ApdOEn6QeTJwsKDeFi\n\tNB6eu9S+H0kUnYPuquMTTp4akpYeMXR276FfTyzu4s1Vi9MT7x33IVu5tmS7eSYR0U6/\n\ty/yQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=dFWTIHBeYUVu8f1znMA7XKhXw2I2IIqmC6cCqCwOGSA=;\n\tb=cpdGuXDMc6fL8zIy2Da7aHM3KdlCS1WKq8N9u/Z9TBaG/P3lGtH9EaytjLh7a9/mEr\n\t6WdyvreRK5TMNYuXcI5wwGlFL4PR2y2ZloZb8j9tqSin/uf2lg7+XkBsb0KpW5foTIjP\n\tqCP5WA8PusPeL71tdOWDnCFEnpel6lnV14GBVNLGREqLTReCmvAqO11oTj8RHsS10AEN\n\tS/Li0apQVhqnyA5f3a77ypzOJyKtu1jhQJh+IJMt39jSmH4aJxO3kpkkas/Ksnu2+u2q\n\tnjjbfh+/7r1TAlibWiEkiyet09gW7GAjtQsX/httC7H5lbGMioFAFIQR3nmRGIQnsV2Y\n\tCf2g==", "X-Gm-Message-State": "AHYfb5hDFsw3r4euxgO/tekxbOl8Rj12EAllPzKSke/Yk/Nt/vww4RoU\n\tLPiT7jNd6sSk2Q==", "X-Received": "by 10.28.6.208 with SMTP id 199mr1684111wmg.55.1504016637770;\n\tTue, 29 Aug 2017 07:23:57 -0700 (PDT)", "From": "Pradeep Jagadeesh <pradeepkiruvale@gmail.com>", "X-Google-Original-From": "Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>", "To": "\"eric blake\" <eblake@redhat.com>,\n\t\"greg kurz\" <groug@kaod.org>", "Date": "Tue, 29 Aug 2017 10:23:01 -0400", "Message-Id": "<1504016587-39779-1-git-send-email-pradeep.jagadeesh@huawei.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2a00:1450:400c:c09::244", "Subject": "[Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alberto garcia <berto@igalia.com>, Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org, \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>,\n\tPradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,\n\tjani kokkonen <jani.kokkonen@huawei.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "These patches provide the qmp interface, to query the io throttle \nstatus of the all fsdev devices that are present in a vm.\nalso, it provides an interface to set the io throttle parameters of a\nfsdev to a required value. some of the patches also remove the duplicate\ncode that was present in block and fsdev files. \n\nPradeep Jagadeesh (6):\n throttle: factor out duplicate code\n qmp: Create IOThrottle structure\n throttle: move out function to reuse the code\n hmp: create a throttle initialization function for code reusability\n fsdev: hmp interface for throttling\n fsdev: QMP interface for throttling\n\n Makefile | 4 ++\n blockdev.c | 97 ++------------------------------\n fsdev/qemu-fsdev-dummy.c | 11 ++++\n fsdev/qemu-fsdev-throttle.c | 120 ++++++++++++++++++++++++++--------------\n fsdev/qemu-fsdev-throttle.h | 8 ++-\n fsdev/qemu-fsdev.c | 38 +++++++++++++\n hmp-commands-info.hx | 18 ++++++\n hmp-commands.hx | 19 +++++++\n hmp.c | 81 +++++++++++++++++++++++++--\n hmp.h | 4 ++\n include/qemu/throttle-options.h | 7 +++\n include/qemu/throttle.h | 4 +-\n include/qemu/typedefs.h | 1 +\n monitor.c | 5 ++\n qapi-schema.json | 3 +\n qapi/block-core.json | 34 +++++++++---\n qapi/fsdev.json | 81 +++++++++++++++++++++++++++\n qmp.c | 14 +++++\n util/throttle.c | 110 ++++++++++++++++++++++++++++++++++++\n 19 files changed, 505 insertions(+), 154 deletions(-)\n create mode 100644 qapi/fsdev.json\n\nv0 -> v1:\n Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange\n Mainly renaming the functions and removing the redundant code.\n\nv1 -> v2:\n Addressed comments from Eric Blake and Greg Kurz.\n As per the suggestion I split the patches into smaller patches.\n Removed some more duplicate code.\n\nv2 -> v3:\n Addresssed comments from Alberto Garcia.\n Changed the comment from block to iothrottle in the iothrottle.json \n Added the dummy functions in qemu-fsdev-dummy.c to address the compilation\n issues that were observed.\n\nv3 -> v4:\n Addressed comments from Eric Blake and Greg Kurz\n Re-ordered the patches\n Added the dummy functions in qmp.c to address the cross compilation issues\n\nv4 -> v5:\n Addressed comments from Eric Blake and Greg Kurz\n Split the fsdev qmp patch into hmp and qmp related patches\n Moved the common functionalities to throttle.c instead of creating\n a new file\n\nv5 -> v6:\n Addressed comments from Greg Kurz and Markus Armbruster\n Split the commits to specific to hmp and throttle as suggested by Greg\n Moved ThrottleConfig typedef to qemu/typedefs.h\n Addressed compilation issue on FreeBSD by adding flags in qmp.c\n\nv6 -> v7:\n Addressed comments from Albert Garcia and Dr. David Alan Gilbert\n Fixed the hmp-commands-info.hx and hmp-commands.hx as per Dr. David's\n comments.\n Fixed the bug with the hmp fsdev_set_io_throttle and info fsdev_iothrottle \n\nv7 -> v8:\n Addressed comments from Markus Armbruster and Eric Blake\n Removed the iothrottle.json and pushed the iothrottle struct to\n block-core.json" }