Cover Letter Detail
Show a cover letter.
GET /api/covers/2237917/?format=api
{ "id": 2237917, "url": "http://patchwork.ozlabs.org/api/covers/2237917/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/cover/20260513151359.1075403-6-cassel@kernel.org/", "project": { "id": 13, "url": "http://patchwork.ozlabs.org/api/projects/13/?format=api", "name": "Linux IDE development", "link_name": "linux-ide", "list_id": "linux-ide.vger.kernel.org", "list_email": "linux-ide@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260513151359.1075403-6-cassel@kernel.org>", "list_archive_url": null, "date": "2026-05-13T15:13:59", "name": "[v4,0/4] ata: fix deferred QC handling for port multipliers", "submitter": { "id": 87751, "url": "http://patchwork.ozlabs.org/api/people/87751/?format=api", "name": "Niklas Cassel", "email": "cassel@kernel.org" }, "mbox": "http://patchwork.ozlabs.org/project/linux-ide/cover/20260513151359.1075403-6-cassel@kernel.org/mbox/", "series": [ { "id": 504179, "url": "http://patchwork.ozlabs.org/api/series/504179/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ide/list/?series=504179", "date": "2026-05-13T15:13:59", "name": "ata: fix deferred QC handling for port multipliers", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/504179/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2237917/comments/", "headers": { "Return-Path": "\n <linux-ide+bounces-5739-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ide@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=A0MwL8wO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ide+bounces-5739-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"A0MwL8wO\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gFy7t1cPlz1yKH\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 14 May 2026 01:30:02 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id BEA7430471D7\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 13 May 2026 15:18:04 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 09DAF4963CA;\n\tWed, 13 May 2026 15:14:09 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D67B647DD6C\n\tfor <linux-ide@vger.kernel.org>; Wed, 13 May 2026 15:14:08 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id E0A1AC19425;\n\tWed, 13 May 2026 15:14:06 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778685248; cv=none;\n b=F0qmiP5y2S7s55kZz+CByVl5Y+AlRy7rbdy/5wI4kIvqOegWmJPAQYECjwuuLVNR0OWn4uHHzo3dZcH8PXpl78+3uqOwbnykMB9RkuDQ+fimcLExk+nziEkk4jgDJMz2Ok+fmAu7G/uDYPsNVeiVL4tSNHF8uQpv6fHzSevgY44=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778685248; c=relaxed/simple;\n\tbh=z8EC+0OMMpKNhWCnLhzdFMqBpubOUN1ATs/CWHbs7e4=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=kJgalxSzxZyj/FZRahWIudGxSkeyjE+FXcfjsAH8OHfAVRjV7bsDg3QhRv6gHQEl/EdOBBQNjjupPhys8zZKfzuUUfVhy0tdRnNSzmSu/eBMWM83IAG5CtTaBzO/S1VKjOgwEfQrTMhRh4zOP/h73dxm3I4p36qaECf64hlF8+I=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=A0MwL8wO; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778685248;\n\tbh=z8EC+0OMMpKNhWCnLhzdFMqBpubOUN1ATs/CWHbs7e4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=A0MwL8wOZAZteeAs2FD0vem14M8MUiCm4jm5/ehWTMpUCEGKhacqh5RtSVVLO6qkf\n\t GcV0sgTGPd2hyP/vjqsL6oRPutA47osA949IfyLlEVxUHv1BCDXrl3mfEL+KUNv0pf\n\t odZmPUYdMvxp9gToxv4Wf93kLAWnZ3aO1XMFy6L53HE196ywGie7U8A9Bc88d5SGRq\n\t hEPzGueZUGIpbVDDjYVA3WiZuzIadYCQL0kJJrjYkDcRXindmEu4b3J1qSp3ipZwm2\n\t Jdh/L4fWJS3sR/au9Oum0sVM+e3lXnm75J4ITNjoANnBSfIswCjtR6clvwEoT1QX5i\n\t B1SYfXaLpkNAg==", "From": "Niklas Cassel <cassel@kernel.org>", "To": "Tommy Kelly <linux@tkel.ly>,\n\tDamien Le Moal <dlemoal@kernel.org>,\n\tNiklas Cassel <cassel@kernel.org>,\n\tJohn Garry <john.g.garry@oracle.com>,\n\t\"Martin K. Petersen\" <martin.petersen@oracle.com>", "Cc": "linux-ide@vger.kernel.org", "Subject": "[PATCH v4 0/4] ata: fix deferred QC handling for port multipliers", "Date": "Wed, 13 May 2026 17:13:59 +0200", "Message-ID": "<20260513151359.1075403-6-cassel@kernel.org>", "X-Mailer": "git-send-email 2.54.0", "Precedence": "bulk", "X-Mailing-List": "linux-ide@vger.kernel.org", "List-Id": "<linux-ide.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ide+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ide+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1846; i=cassel@kernel.org;\n h=from:subject; bh=z8EC+0OMMpKNhWCnLhzdFMqBpubOUN1ATs/CWHbs7e4=;\n b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGLJYpppvPW0rdv4044X+LUYzSniucJlvKb3qvKThzIOk7\n 29vPZoR3VHKwiDGxSArpsji+8Nlf3G3+5TjindsYOawMoEMYeDiFICJuPxhZPjj3+p2oyuHa3tI\n Y6Itu/K6N7wxlYuzuh7t97OemjuXfwXD/xoBveygE33BV7mWa/9OqPoyqdauY8/fx8tyVwZaqR4\n 5zAwA", "X-Developer-Key": "i=cassel@kernel.org; a=openpgp;\n fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA", "Content-Transfer-Encoding": "8bit" }, "content": "Hello all,\n\nTommy Kelly reported a regression with PMP that use CBS:\nhttps://lore.kernel.org/linux-ide/ce09cc21-a8e9-4845-b205-35411e22fba9@tkel.ly/\n\nIt turns out that the ap->excl_link logic used for PMP that use CBS is\nincompatible with the deferred qc issuing via a workqueue.\nThis is fixed in patch 3/4.\n\nWhile looking at the code, it turns out that the deferred qc issuing via\nworkqueue is misdesigned. It assumed that we can't mix NCQ and non-NCQ\ncommands on the same port. The limitation is that you can not mix NCQ and\nnon-NCQ commands on the same drive. However, with a PMP with FBS, you can\nissue (mixed NCQ and non-NCQ commands) to the different drives. Thus, move\nthe saved deferred QC from struct ata_port to struct ata_link. This is\nfixed in patch 4/4.\n\n\nChanges since v3:\n-Use iter_mode PMP_FIRST rather than EDGE in ata_for_each_link(), such that\n the slave_link is included.\n-Add patch 1/4 that is a cleanup patch.\n-Add patch 2/4 that changes so that the deferred QC is only used for\n ATA_DEFER_LINK (i.e. not used for ATA_DEFER_PORT).\n-Renamed ATA_DEFER_LINK_CBS to ATA_DEFER_LINK_EXCL.\n\n\nNiklas Cassel (4):\n ata: libata-scsi: improve readability of ata_scsi_qc_issue()\n ata: libata-scsi: do not use the deferred QC feature for\n ATA_DEFER_PORT\n ata: libata-scsi: do not use the deferred QC feature on PMPs with CBS\n ata: libata-scsi: do not needlessly defer commands when using PMP with\n FBS\n\n drivers/ata/libata-core.c | 9 ++--\n drivers/ata/libata-eh.c | 8 ++--\n drivers/ata/libata-pmp.c | 18 +++++++-\n drivers/ata/libata-scsi.c | 89 +++++++++++++++++++++++----------------\n drivers/ata/sata_sil24.c | 6 ++-\n include/linux/libata.h | 7 +--\n 6 files changed, 87 insertions(+), 50 deletions(-)\n\n\nbase-commit: 79b6e4dd96ec663ef51bb52b00e0bbbdf0ec9009" }