Cover Letter Detail
Show a cover letter.
GET /api/covers/2232205/?format=api
{ "id": 2232205, "url": "http://patchwork.ozlabs.org/api/covers/2232205/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/cover/20260503204936.3151124-1-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260503204936.3151124-1-sjg@chromium.org>", "list_archive_url": null, "date": "2026-05-03T20:49:18", "name": "[0/6] test: Quote variables in 'test -n' expressions across boards", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/cover/20260503204936.3151124-1-sjg@chromium.org/mbox/", "series": [ { "id": 502588, "url": "http://patchwork.ozlabs.org/api/series/502588/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=502588", "date": "2026-05-03T20:49:18", "name": "test: Quote variables in 'test -n' expressions across boards", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/502588/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2232205/comments/", "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=ZYiGuuLx;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"ZYiGuuLx\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g7xjm5NTfz1yJ0\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 04 May 2026 06:50:04 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2745783FEC;\n\tSun, 3 May 2026 22:49:56 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 3B4BD84198; Sun, 3 May 2026 22:49:54 +0200 (CEST)", "from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com\n [IPv6:2607:f8b0:4864:20::c2c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 52C4283EF9\n for <u-boot@lists.denx.de>; Sun, 3 May 2026 22:49:51 +0200 (CEST)", "by mail-oo1-xc2c.google.com with SMTP id\n 006d021491bc7-6966d16b978so1235962eaf.3\n for <u-boot@lists.denx.de>; Sun, 03 May 2026 13:49:51 -0700 (PDT)", "from chromium.org ([174.51.25.52]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-696aacbb5bbsm1142940eaf.15.2026.05.03.13.49.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 03 May 2026 13:49:48 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777841389; x=1778446189; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=z0nlokKnLCj+yZaZKHoGJmX/VPrJf957nzaTBny243U=;\n b=ZYiGuuLx5ASIMZYEfRZDbTP/SMuJqWIvfR1hVlqizUFCXWljGKBtp2QAeJ7w83XdnX\n J6r048UhX52WN64t3c2jn1lhheZpLCzsG4ktaO4fsKEGYEU+HOz79kWJoXfNCHejsRyl\n rs4fAqNgVsTjhjwAKsQn2qQ4Mo9NyXFieYV/I=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777841389; x=1778446189;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=z0nlokKnLCj+yZaZKHoGJmX/VPrJf957nzaTBny243U=;\n b=SVW/bC82sCeuDL0TTi1yWf8RCm5PIVrE8F+JIc3bHQXosRda055BX4ajeBNHkzSUEQ\n 1QwLoTGgTTjfKMq3kSCXnH9uQK2wRR7SbHTPAGT7RFAAHrk/ZnSViywQ4vio2KuTej/u\n EpamsS17s5IBjmU5tHEHLHtIBsvm6eebitWKur3xtRsRSBMuWcWCL1JawD8VrMv/8I0V\n W9voI59oTBdKGVAO1dDob7uIUTEG8j+Fbkqi1Rqzn5PpTC9SQYdvXQtufOVUeWS8V+7A\n e1Va3p0/jLjsRLJFPdNxVK2CMC+daSR8mpeGZ9i3OC+1pLBhsx4odsYs3DEzBQPDhyMx\n noiQ==", "X-Gm-Message-State": "AOJu0Yx4eBX7EnflM60Ppr98aLCo1EjetGoBjRSVPSv+IrXEDb2APATB\n 7aQ8Sd9fFwOMYmkUeicZJM8Dfk7CYYExQ4aS3sjr81IzpqPgND+eQX7VbaNncR3c7qZj87BscYo\n zsofSyw==", "X-Gm-Gg": "AeBDies4uN4uiWN2L6r70eXR6vqfxBQiH+7Ye3Z2cic5CgrlA4uSoaM+fpcViMPBUTg\n CVr1WFmcoZfOZMsvEaBD6Tr+hlahoTNc2AJlVpmCzMFU+NQmFmdMC5fA2SBIBYn+etjyfUeSfd4\n W109MWu2AnTB98KpdNK7z8qxs7pgZVcYBp0fyDrDmH0S+NkKM0A8DXQ1zjKsryXRIGpQLQy40JB\n 1hfFQT9cow7F8WADlH9ELRP5NA/jllTbm0875gvF9BtpgXMLCb/CIbVSAnVgLclWN6Hei8mMcoP\n PIYB7wV0jJmqINLSf10j1LS3pfsoERcBMb9ejusWovaX6oFVHp/gtZRbTaOiHdpUtOG9heBHKwB\n Xnl1z7K5YkBf34phlf+dGGWSKi2WuwjM7cH40kc7VfA4CxfaDKOwt5XYVTRswH1Sa/Bt4xwaDnk\n DCIPcDkstZFXlhtj/yrbdvUPEGVb8X", "X-Received": "by 2002:a05:6820:906:b0:696:1a25:fdc9 with SMTP id\n 006d021491bc7-69697c6545fmr3174703eaf.28.1777841389320;\n Sun, 03 May 2026 13:49:49 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "u-boot@lists.denx.de", "Cc": "Simon Glass <sjg@chromium.org>, Alice Guo <alice.guo@nxp.com>,\n Andrew Davis <afd@ti.com>, Anshul Dalal <anshuld@ti.com>,\n Bryan Brattlof <bb@ti.com>, Cyril Jean <cyril.jean@microchip.com>,\n Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,\n Enrico Leto <enrico.leto@siemens.com>,\n Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,\n Fabio Estevam <festevam@gmail.com>,\n Francesco Dolcini <francesco.dolcini@toradex.com>,\n Franz Schnyder <franz.schnyder@toradex.com>,\n Heiko Schocher <hs@nabladev.com>, Hiago De Franco <hiago.franco@toradex.com>,\n Jaehoon Chung <jh80.chung@samsung.com>,\n Jamie Gibbons <jamie.gibbons@microchip.com>,\n Leo Yu-Chi Liang <ycliang@andestech.com>, Lukasz Majewski <lukma@denx.de>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Max Krummenacher <max.krummenacher@toradex.com>,\n Parth Pancholi <parth.pancholi@toradex.com>, Peng Fan <peng.fan@nxp.com>,\n Rasmus Villemoes <ravi@prevas.dk>,\n Sam Protsenko <semen.protsenko@linaro.org>,\n Siddharth Vadapalli <s-vadapalli@ti.com>, Tom Rini <trini@konsulko.com>,\n Udit Kumar <u-kumar1@ti.com>,\n =?utf-8?q?=C5=81ukasz_Majewski?= <lukma@nabladev.com>", "Subject": "[PATCH 0/6] test: Quote variables in 'test -n' expressions across\n boards", "Date": "Sun, 3 May 2026 14:49:18 -0600", "Message-ID": "<20260503204936.3151124-1-sjg@chromium.org>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Several boards use 'test -n ${var}' (unquoted) in env scripts to\ndetect an empty variable and trigger a fallback or skip a hook. That\nworks only because of a U-Boot 'test' quirk where calls with argc <\n3 returned false; an empty variable made the expression 'test -n'\n(one operand) and hit that path.\n\n8b0619579b22 (\"cmd: test: fix handling of single-argument form of\ntest\") aligned 'test' with POSIX so those expressions flipped to\ntrue. f7e7c55e53e8 (\"cmd: test: add bug-compatibility special case\nfor 'test -n'\") restored the old behaviour for the exact 'test -n'\n(one arg) case, so the boards are not broken at runtime today, but\nthe reliance on a bug-compat path isn't great.\n\nThis series updates various boards to quote each affected variable so\nthe emptiness check is explicit and does not depend on the\nspecial-case path.\n\nEach commit carries a Fixes: tag pointing at 8b0619579b22\n\n\nSimon Glass (6):\n toradex: Quote fdtfile in preboot test\n ti: Quote board_init in ti_common.env\n siemens: Quote A/B flags in env tests\n beaglev_fire: Quote no_of_overlays in design test\n mccmon6: Quote recovery_status in bootcmd test\n aristainetos2: Quote rescue_reason in rescueboot test\n\n configs/apalis-imx8_defconfig | 2 +-\n configs/apalis_imx6_defconfig | 2 +-\n configs/colibri-imx6ull-emmc_defconfig | 2 +-\n configs/colibri-imx6ull_defconfig | 2 +-\n configs/colibri-imx8x_defconfig | 2 +-\n configs/colibri_imx6_defconfig | 2 +-\n configs/colibri_imx7_defconfig | 2 +-\n configs/colibri_imx7_emmc_defconfig | 2 +-\n configs/colibri_vf_defconfig | 2 +-\n configs/toradex-smarc-imx8mp_defconfig | 2 +-\n configs/toradex-smarc-imx95_defconfig | 2 +-\n configs/verdin-am62_a53_defconfig | 2 +-\n configs/verdin-am62p_a53_defconfig | 2 +-\n configs/verdin-imx8mm_defconfig | 2 +-\n configs/verdin-imx8mp_defconfig | 2 +-\n include/configs/aristainetos2.h | 2 +-\n include/configs/beaglev_fire.h | 2 +-\n include/configs/draco-etamin.h | 4 ++--\n include/configs/mccmon6.h | 2 +-\n include/configs/siemens-am33x-common.h | 12 ++++++------\n include/configs/siemens-env-common.h | 8 ++++----\n include/env/ti/ti_common.env | 2 +-\n 22 files changed, 31 insertions(+), 31 deletions(-)\n\n---\nbase-commit: bb0f3eebb3c196d9b6efbbd1e5aa9b16abbb9ad6\nbranch: env-test-us" }