Cover Letter Detail
Show a cover letter.
GET /api/covers/2231615/?format=api
{ "id": 2231615, "url": "http://patchwork.ozlabs.org/api/covers/2231615/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/cover/20260430233848.440994-1-i.maximets@ovn.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260430233848.440994-1-i.maximets@ovn.org>", "list_archive_url": null, "date": "2026-04-30T23:38:36", "name": "[ovs-dev,net,v2,0/2] openvswitch: fix self-deadlock on release of tunnel vports", "submitter": { "id": 76798, "url": "http://patchwork.ozlabs.org/api/people/76798/?format=api", "name": "Ilya Maximets", "email": "i.maximets@ovn.org" }, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/cover/20260430233848.440994-1-i.maximets@ovn.org/mbox/", "series": [ { "id": 502405, "url": "http://patchwork.ozlabs.org/api/series/502405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=502405", "date": "2026-04-30T23:38:37", "name": "openvswitch: fix self-deadlock on release of tunnel vports", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/502405/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2231615/comments/", "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)", "smtp3.osuosl.org;\n dmarc=none (p=none dis=none) header.from=ovn.org" ], "Received": [ "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g69cK4cMgz1yJv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 01 May 2026 09:39:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id B1F3240F54;\n\tThu, 30 Apr 2026 23:39:04 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id gXImc1BwwUOk; Thu, 30 Apr 2026 23:39:03 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id B09D44006E;\n\tThu, 30 Apr 2026 23:39:03 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 89CEAC04E8;\n\tThu, 30 Apr 2026 23:39:03 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id F2763C04E7\n for <dev@openvswitch.org>; Thu, 30 Apr 2026 23:39:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id D48916F6F7\n for <dev@openvswitch.org>; Thu, 30 Apr 2026 23:39:00 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id D6UPL2SwBa8u for <dev@openvswitch.org>;\n Thu, 30 Apr 2026 23:39:00 +0000 (UTC)", "from mail-qt1-f194.google.com (mail-qt1-f194.google.com\n [209.85.160.194])\n by smtp3.osuosl.org (Postfix) with ESMTPS id ECE126F6F5\n for <dev@openvswitch.org>; Thu, 30 Apr 2026 23:38:59 +0000 (UTC)", "by mail-qt1-f194.google.com with SMTP id\n d75a77b69052e-50fb1ad3734so21528561cf.1\n for <dev@openvswitch.org>; Thu, 30 Apr 2026 16:38:59 -0700 (PDT)", "from im-t490s.redhat.com (89-24-32-159.nat.epc.tmcz.cz.\n [89.24.32.159]) by smtp.gmail.com with ESMTPSA id\n d75a77b69052e-51040934199sm221cf.13.2026.04.30.16.38.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 30 Apr 2026 16:38:58 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp2.osuosl.org B09D44006E", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org ECE126F6F5" ], "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=209.85.160.194;\n helo=mail-qt1-f194.google.com; envelope-from=i.maximets.ovn@gmail.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org ECE126F6F5", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777592338; x=1778197138;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XI5s/gjPC8JmnFz7SoHnBZF2JdcqfzQbMV/kK5cvcdo=;\n b=rBFLV1ltAaUG4j5l6pIg8n/BV2DecdzDbDHJYOxIdUHyl1gSm4yKiVpaum2/c34jkk\n mzxIfNa7adh5rlCBWfdp+fF9S+Fwj9CowrCDm6LRMuWXmDovu/psbkDSdg8ndyWkljmE\n bDBkrbJmE1x5D7vFy6B78sptAZcVbRsWHim6CAd2duGcicTDyF6zTQ3t0g/CC0BsWlAW\n 2mBkoNJnf/n6MfTol49r0wB0TD3ee7Ii/Eqk3pFTtthmTntHFi12rfQstU5KqFqpZiT4\n ksjJjeLowiTenPcZme8FOz1nCv5n3afr07T3U7fxY10Xo+e431RlibMzpHAq3id1Wgam\n NinA==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ/fUsoXip7MOcwtJ88eCetsgXgzG1Oq79q2N3AJqwcXInHWRQ01eu5sKVrjZI7BG4TOZCw=@openvswitch.org", "X-Gm-Message-State": "AOJu0YwFa3zAwhZHJaVksc7MfQEpPkYriFxC+GAiIa/sk/c2kJtU0csr\n 0F1UH7vKLEEzgg3qvz3mnumkH+KdkDtEByTew0Xi6MiBpDf3HOS24oSL", "X-Gm-Gg": "AeBDieuJQ/4lN3aTWda+UVNGUn8DcCeWvsC1bmlghUr8Ucg9YlLhHRkhVBibFdi0Gm5\n sb63fReM/3PHNc51SP8UG/AvZvcVuL2WsrQJlr7MCqKSrCGUFJ7oF8Xzb9fE46zIHYVWf+1AFyl\n SBTpubrkuHME6x2x/frR18Izid35SuZF8sa7ub6jV+FnAw7Po4s18dwuzXHduwg34Lgo3wYJfc4\n Qf+WAhxEOkUNEccdLO3047PZdH/8+WVDH6Yp/Oone+i+p34zAd/89WID3+itOe9/D+6iIjM3wGQ\n XE361BJjw1QR5czhHianyEgGxLlHH7lxYgID+anGRNguO3oLCoOhmF0TEph6XiV9Hv3qYV6vpev\n fhhq72MCNc/5jTFrXXKTXZB328fZ9ZONyG4n8gKAy4Xmdm0//Mb9Y2hgCsxA1bM6nXeegNEW3vC\n HN4S0FSxlOI3BRoEP34rWY8zr+v5n7oAfnLwGwtrS4qrp5iK87OMcbYf+rZEipOiLZx+qM3xAFn\n GoM29CO", "X-Received": "by 2002:a05:622a:248d:b0:50f:bd19:657b with SMTP id\n d75a77b69052e-5102d13e8ddmr62263561cf.10.1777592338555;\n Thu, 30 Apr 2026 16:38:58 -0700 (PDT)", "From": "Ilya Maximets <i.maximets@ovn.org>", "To": "netdev@vger.kernel.org", "Date": "Fri, 1 May 2026 01:38:36 +0200", "Message-ID": "<20260430233848.440994-1-i.maximets@ovn.org>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Subject": "[ovs-dev] [PATCH net v2 0/2] openvswitch: fix self-deadlock on\n release of tunnel vports", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Cc": "dev@openvswitch.org, linux-kselftest@vger.kernel.org,\n Yuan Tan <tanyuan98@outlook.com>, linux-kernel@vger.kernel.org,\n Ilya Maximets <i.maximets@ovn.org>, Yang Yang <n05ec@lzu.edu.cn>,\n Eric Dumazet <edumazet@google.com>, Simon Horman <horms@kernel.org>,\n Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,\n Shuah Khan <shuah@kernel.org>, \"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Two patches - the fix for the actual bug and the selftest that reproduces it.\n\nI missed the self-deadlock in the original patch that introduced the issue,\nbecause testing required code modification in the ovs-vswitchd to force it to\nuse legacy tunnel ports. I thought I made the change correctly, but apparently\nsomething went wrong and the tests were run with the standard LWT infra instead.\nThe selftest added in this patch set will at least prevent this kind of mistakes\nin the future.\n\nI mentioned, however, that these tunnel vports are legacy and not actually used\nby ovs-vswitchd. RTM_NEWLINK + COLLECT_METADATA is used in conjunction with the\nstandard OVS_VPORT_TYPE_NETDEV instead since 2017. The code to use the legacy\ntunnels still exists in ovs-vswitchd however, but only as a fallback for older\nkernels and we're planning to remove it in the next release. I'll be sending an\nRFC to remove support for these legacy tunnel types from the kernel, as they\nserve no real purpose today and only increase the uAPI surface for CVEs, but\nwe need to fix the known bugs for stable versions.\n\n\nVersion 2:\n - Added Ack from Eelco to the first patch (not to the second as it\n changed a little).\n - Removed now unused import socket in the dpctl.py [pylint/ruff].\n\n - Regarding comments from both Sashiko instances on the selftest patch:\n\n * The background process is not waited for / not killed.\n If it hangs it will not be killable anyway, so it's not a problem.\n\n * The 'gre' choice for dpctl.py --ptype is not fully handled for --lwt.\n While this is not needed for this patch, I agree that it's not\n fully consistent. Added the proper handling in the TUNNEL_DEFAULTS\n loop in this version.\n\n * Python version concern for argparse.BooleanOptionalAction.\n Python 3.9 is the oldest supported version and it has it, so it's\n not an issue. Creating extra detection will only complicate the\n script with no real benefits.\n\nVersion 1:\n https://lore.kernel.org/netdev/20260429151756.4157670-1-i.maximets@ovn.org/\n\nIlya Maximets (2):\n openvswitch: vport: fix self-deadlock on release of tunnel ports\n selftests: openvswitch: add tests for tunnel vport refcounting\n\n net/openvswitch/vport-netdev.c | 6 ++-\n .../selftests/net/openvswitch/openvswitch.sh | 37 +++++++++++++++++++\n .../selftests/net/openvswitch/ovs-dpctl.py | 19 +++++++---\n 3 files changed, 55 insertions(+), 7 deletions(-)" }