Cover Letter Detail
Show a cover letter.
GET /api/covers/2226907/?format=api
{ "id": 2226907, "url": "http://patchwork.ozlabs.org/api/covers/2226907/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/cover/bmm.hhupnyl5bc.gcc.gcc-TEST.fdumont.131.1.0@forge-stage.sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<bmm.hhupnyl5bc.gcc.gcc-TEST.fdumont.131.1.0@forge-stage.sourceware.org>", "list_archive_url": null, "date": "2026-04-22T19:08:43", "name": "[v1,0/1] libstdc++: Fix std::erase_if behavior for std::__debug containers", "submitter": { "id": 93220, "url": "http://patchwork.ozlabs.org/api/people/93220/?format=api", "name": "François Dumont via Sourceware Forge", "email": "forge-bot+fdumont@forge-stage.sourceware.org" }, "mbox": "http://patchwork.ozlabs.org/project/gcc/cover/bmm.hhupnyl5bc.gcc.gcc-TEST.fdumont.131.1.0@forge-stage.sourceware.org/mbox/", "series": [ { "id": 501115, "url": "http://patchwork.ozlabs.org/api/series/501115/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501115", "date": "2026-04-22T19:08:43", "name": "libstdc++: Fix std::erase_if behavior for std::__debug containers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501115/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2226907/comments/", "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=forge-stage.sourceware.org", "sourceware.org;\n spf=pass smtp.mailfrom=forge-stage.sourceware.org", "server2.sourceware.org;\n arc=none smtp.remote-ip=38.145.34.39" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1CDW2r8gz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 07:34:51 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 5E8764C318BE\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 21:34:49 +0000 (GMT)", "from forge-stage.sourceware.org (vm08.sourceware.org [38.145.34.39])\n by sourceware.org (Postfix) with ESMTPS id 9F55842939AF\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 19:09:42 +0000 (GMT)", "from forge-stage.sourceware.org (localhost [IPv6:::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256)\n (No client certificate requested)\n by forge-stage.sourceware.org (Postfix) with ESMTPS id 7A58B435DB\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 19:09:42 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 5E8764C318BE", "OpenDKIM Filter v2.11.0 sourceware.org 9F55842939AF" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 9F55842939AF", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 9F55842939AF", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776884982; cv=none;\n b=tYNMnLJllOZcBsmBSdzZp+5gGLbUK8ijnCbGf5UdHK6pEqE0+AyO7FqxQJnzei1Xsz/tH0yMqtl4VPNhw5hJ/0aVlFxRfhfzSQEFKDHssABU453sxW//wM+Ym5+ORMCU/JYRBzbOLcsF2KHnNFW3EJ2xfeMxgZgnhoWQ2cz53/Y=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776884982; c=relaxed/simple;\n bh=IMYtpTbAbM0sj0ZRi0HbjcSOnR3z0Zh/TDNSWOn+gHE=;\n h=From:Date:Subject:MIME-Version:To:Message-ID;\n b=IKuJl8v0VL0Tnw9+vCtNzJY4oZH2xGqiNRPisoOxZvWAHTE5k9uaucncyNIpWBUKjKBMEusUnGr9rcrERxyBlBTebHPJae2dETNYJJ71WjgP5y/AjhyKCSgrCZB9gaMPWe6TBi+VTozA78T0Sf5yt7FNTA29pYZL7RJIOUNF1lQ=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "From": "=?utf-8?q?Fran=C3=A7ois_Dumont_via_Sourceware_Forge?=\n <forge-bot+fdumont@forge-stage.sourceware.org>", "Date": "Wed, 22 Apr 2026 19:08:43 +0000", "Subject": "[PATCH v1 0/1] libstdc++: Fix std::erase_if behavior for std::__debug\n containers", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>", "Message-ID": "\n <bmm.hhupnyl5bc.gcc.gcc-TEST.fdumont.131.1.0@forge-stage.sourceware.org>", "X-Mailer": "batrachomyomachia", "X-Pull-Request-Organization": "gcc", "X-Pull-Request-Repository": "gcc-TEST", "X-Pull-Request": "https://forge.sourceware.org/gcc/gcc-TEST/pulls/131", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "gcc-patches mailing list <gcc-patches@gcc.gnu.org>,\n fdumont@gcc.gnu.org", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Hi gcc-patches mailing list,\nFrançois Dumont via Sourceware Forge <forge-bot+fdumont@forge-stage.sourceware.org> has requested that the following forgejo pull request\nbe published on the mailing list.\n\nCreated on: 2025-12-18 21:22:18+00:00\nLatest update: 2026-01-19 05:58:02+00:00\nChanges: 42 changed files, 886 additions, 154 deletions\nHead revision: fdumont/gcc-TEST ref debug_erase_if commit add9e3dd616da332ea69afbb583fd0cfdfc970cf\nBase revision: gcc/gcc-TEST ref trunk commit f89e3c8acdc3a0e12aa8eaaec1bc9c67ea6fde98 r16-6861-gf89e3c8acdc3a0\nMerge base: f89e3c8acdc3a0e12aa8eaaec1bc9c67ea6fde98\nFull diff url: https://forge.sourceware.org/gcc/gcc-TEST/pulls/131.diff\nDiscussion: https://forge.sourceware.org/gcc/gcc-TEST/pulls/131\nRequested Reviewers:\n\nComplete fix of std::erase_if/std::erase for all std::__debug containers and\n__gnu_debug::basic_string. Make sure that iterators erased by this function\nwill be properly detected as such by the debug container and so considered as\ninvalid.\n\nDoing so introduce a new std::__detail::__erase_if function dealing, similarly\nto std::__detail::__erase_node_if, with non-node containers.\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/erase_if.h (__detail::__erase_if): New.\n\t* include/debug/deque (std::erase_if<>(__debug::deque<>&, _Pred): Use latter.\n\t* include/debug/inplace_vector (std::erase_if<>(__debug::inplace_vector<>&, _Pred)):\n\tLikewise.\n\t* include/debug/vector (std::erase_if<>(__debug::vector<>&, _Pred)): Likewise.\n\t* include/std/deque: Include erase_if.h.\n\t(std::erase_if<>(std::vector<>&, _Pred)): Adapt to use __detail::__erase_if.\n\t* include/std/inplace_vector (std::erase_if<>(std::inplace_vector<>&, _Pred)):\n\tLikewise.\n\t* include/std/string (std::erase_if<>(std::basic_string<>&, _Pred)): Likewise.\n\t* include/std/vector (std::erase_if<>(std::vector<>&, _Pred)): Likewise.\n\t* include/debug/forward_list\n\t(std::erase_if<>(__debug::forward_list<>&, _Pred)): New.\n\t(std::erase<>(__debug::forward_list<>&, const _Up&)): New.\n\t* include/debug/list\n\t(std::erase_if<>(__debug::list<>&, _Pred)): New.\n\t(std::erase<>(__debug::list<>&, const _Up&)): New.\n\t* include/debug/map (std::erase_if<>(__debug::map<>&, _Pred)): New.\n\t(std::erase_if<>(__debug::multimap<>&, _Pred)): New.\n\t* include/debug/set (std::erase_if<>(__debug::set<>&, _Pred)): New.\n\t(std::erase_if<>(__debug::multiset<>&, _Pred)): New.\n\t* include/debug/string\n\t(std::erase_if<>(__gnu_debug::basic_string<>&, _Pred)): New.\n\t(std::erase<>(__gnu_debug::basic_string<>&, const _Up&)): New.\n\t* include/debug/unordered_map\n\t(std::erase_if<>(__debug::unordered_map<>&, _Pred)): New.\n\t(std::erase_if<>(__debug::unordered_multimap<>&, _Pred)): New.\n\t* include/debug/unordered_set\n\t(std::erase_if<>(__debug::unordered_set<>&, _Pred)): New.\n\t(std::erase_if<>(__debug::unordered_multiset<>&, _Pred)): New.\n\t* include/std/forward_list (std::erase_if<>(std::forward_list<>&, _Pred)):\n\tAdapt to work exclusively for normal implementation.\n\t(std::erase<>(std::forward_list<>&, const _Up&)): Likewise.\n\t* include/std/list (std::erase_if<>(std::list<>&, _Pred)): Likewise.\n\t(std::erase<>(std::list<>&, const _Up&)): Likewise.\n\t* include/std/map (std::erase_if<>(std::map<>&, _Pred)): Likewise.\n\t(std::erase_if<>(std::multimap<>&, _Pred)): Likewise.\n\t* include/debug/set (std::erase_if<>(std::set<>&, _Pred)): Likewise.\n\t(std::erase_if<>(std::multiset<>&, _Pred)): Likewise.\n\t* include/std/unordered_map\n\t(std::erase_if<>(std::unordered_map<>&, _Pred)): Likewise.\n\t(std::erase_if<>(std::unordered_multimap<>&, _Pred)): Likewise.\n\t* include/std/unordered_set\n\t(std::erase_if<>(std::unordered_set<>&, _Pred)): Likewise.\n\t(std::erase_if<>(std::unordered_multiset<>&, _Pred)): Likewise.\n\t* testsuite/21_strings/basic_string/debug/erase.cc: New test case.\n\t* testsuite/23_containers/forward_list/debug/erase.cc: New test case.\n\t* testsuite/23_containers/forward_list/debug/invalidation/erase.cc: New test case.\n\t* testsuite/23_containers/list/debug/erase.cc: New test case.\n\t* testsuite/23_containers/list/debug/invalidation/erase.cc: New test case.\n\t* testsuite/23_containers/map/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/map/debug/invalidation/erase_if.cc: New test case.\n\t* testsuite/23_containers/multimap/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/multimap/debug/invalidation/erase_if.cc: New test case.\n\t* testsuite/23_containers/multiset/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/multiset/debug/invalidation/erase_if.cc: New test case.\n\t* testsuite/23_containers/set/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/set/debug/invalidation/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_map/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_map/debug/invalidation/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_multimap/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_multimap/debug/invalidation/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_multiset/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_multiset/debug/invalidation/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_set/debug/erase_if.cc: New test case.\n\t* testsuite/23_containers/unordered_set/debug/invalidation/erase_if.cc: New test case.\n\nThanks for taking the time to contribute to GCC!\n\nPlease be advised that https://forge.sourceware.org/ is currently a trial\nthat is being used by the GCC community to experiment with a new workflow\nbased on pull requests.\n\nPull requests sent here may be forgotten or ignored. Patches that you want to\npropose for inclusion in GCC should use the existing email-based workflow,\nsee https://gcc.gnu.org/contribute.html\n\n\nChanged files:\n- A: libstdc++-v3/testsuite/21_strings/basic_string/debug/erase.cc\n- A: libstdc++-v3/testsuite/23_containers/forward_list/debug/erase.cc\n- A: libstdc++-v3/testsuite/23_containers/forward_list/debug/invalidation/erase.cc\n- A: libstdc++-v3/testsuite/23_containers/list/debug/erase.cc\n- A: libstdc++-v3/testsuite/23_containers/list/debug/invalidation/erase.cc\n- A: libstdc++-v3/testsuite/23_containers/map/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/map/debug/invalidation/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/multimap/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/multimap/debug/invalidation/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/multiset/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/multiset/debug/invalidation/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/set/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/set/debug/invalidation/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_map/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_map/debug/invalidation/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_multimap/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_multimap/debug/invalidation/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_multiset/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_multiset/debug/invalidation/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_set/debug/erase_if.cc\n- A: libstdc++-v3/testsuite/23_containers/unordered_set/debug/invalidation/erase_if.cc\n- M: libstdc++-v3/include/bits/erase_if.h\n- M: libstdc++-v3/include/debug/deque\n- M: libstdc++-v3/include/debug/forward_list\n- M: libstdc++-v3/include/debug/inplace_vector\n- M: libstdc++-v3/include/debug/list\n- M: libstdc++-v3/include/debug/map\n- M: libstdc++-v3/include/debug/set\n- M: libstdc++-v3/include/debug/string\n- M: libstdc++-v3/include/debug/unordered_map\n- M: libstdc++-v3/include/debug/unordered_set\n- M: libstdc++-v3/include/debug/vector\n- M: libstdc++-v3/include/std/deque\n- M: libstdc++-v3/include/std/forward_list\n- M: libstdc++-v3/include/std/inplace_vector\n- M: libstdc++-v3/include/std/list\n- M: libstdc++-v3/include/std/map\n- M: libstdc++-v3/include/std/set\n- M: libstdc++-v3/include/std/string\n- M: libstdc++-v3/include/std/unordered_map\n- M: libstdc++-v3/include/std/unordered_set\n- M: libstdc++-v3/include/std/vector\n\n\nFrançois Dumont (1):\n libstdc++: Fix std::erase_if behavior for std::__debug containers\n\n libstdc++-v3/include/bits/erase_if.h | 22 ++++++++++++\n libstdc++-v3/include/debug/deque | 16 ++-------\n libstdc++-v3/include/debug/forward_list | 21 ++++++++++++\n libstdc++-v3/include/debug/inplace_vector | 15 ++------\n libstdc++-v3/include/debug/list | 21 ++++++++++++\n libstdc++-v3/include/debug/map | 21 ++++++++++++\n libstdc++-v3/include/debug/set | 19 +++++++++++\n libstdc++-v3/include/debug/string | 20 +++++++++++\n libstdc++-v3/include/debug/unordered_map | 20 +++++++++++\n libstdc++-v3/include/debug/unordered_set | 20 +++++++++++\n libstdc++-v3/include/debug/vector | 14 +-------\n libstdc++-v3/include/std/deque | 15 ++------\n libstdc++-v3/include/std/forward_list | 8 ++---\n libstdc++-v3/include/std/inplace_vector | 13 ++-----\n libstdc++-v3/include/std/list | 8 ++---\n libstdc++-v3/include/std/map | 25 ++++++--------\n libstdc++-v3/include/std/set | 24 ++++++-------\n libstdc++-v3/include/std/string | 11 ++----\n libstdc++-v3/include/std/unordered_map | 29 +++++++---------\n libstdc++-v3/include/std/unordered_set | 26 ++++++--------\n libstdc++-v3/include/std/vector | 15 ++------\n .../21_strings/basic_string/debug/erase.cc | 25 ++++++++++++++\n .../23_containers/forward_list/debug/erase.cc | 26 ++++++++++++++\n .../forward_list/debug/invalidation/erase.cc | 27 +++++++++++++++\n .../23_containers/list/debug/erase.cc | 29 ++++++++++++++++\n .../list/debug/invalidation/erase.cc | 30 ++++++++++++++++\n .../23_containers/map/debug/erase_if.cc | 33 ++++++++++++++++++\n .../map/debug/invalidation/erase_if.cc | 34 +++++++++++++++++++\n .../23_containers/multimap/debug/erase_if.cc | 33 ++++++++++++++++++\n .../multimap/debug/invalidation/erase_if.cc | 34 +++++++++++++++++++\n .../23_containers/multiset/debug/erase_if.cc | 31 +++++++++++++++++\n .../multiset/debug/invalidation/erase_if.cc | 32 +++++++++++++++++\n .../23_containers/set/debug/erase_if.cc | 31 +++++++++++++++++\n .../set/debug/invalidation/erase_if.cc | 32 +++++++++++++++++\n .../unordered_map/debug/erase_if.cc | 33 ++++++++++++++++++\n .../debug/invalidation/erase_if.cc | 34 +++++++++++++++++++\n .../unordered_multimap/debug/erase_if.cc | 33 ++++++++++++++++++\n .../debug/invalidation/erase_if.cc | 34 +++++++++++++++++++\n .../unordered_multiset/debug/erase_if.cc | 31 +++++++++++++++++\n .../debug/invalidation/erase_if.cc | 32 +++++++++++++++++\n .../unordered_set/debug/erase_if.cc | 31 +++++++++++++++++\n .../debug/invalidation/erase_if.cc | 32 +++++++++++++++++\n 42 files changed, 886 insertions(+), 154 deletions(-)\n create mode 100644 libstdc++-v3/testsuite/21_strings/basic_string/debug/erase.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/forward_list/debug/erase.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/forward_list/debug/invalidation/erase.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/list/debug/erase.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/list/debug/invalidation/erase.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/map/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/map/debug/invalidation/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/multimap/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/multimap/debug/invalidation/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/multiset/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/multiset/debug/invalidation/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/set/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/set/debug/invalidation/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_map/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_map/debug/invalidation/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_multimap/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_multimap/debug/invalidation/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_multiset/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_multiset/debug/invalidation/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_set/debug/erase_if.cc\n create mode 100644 libstdc++-v3/testsuite/23_containers/unordered_set/debug/invalidation/erase_if.cc" }