Cover Letter Detail
Show a cover letter.
GET /api/covers/2226091/?format=api
{ "id": 2226091, "url": "http://patchwork.ozlabs.org/api/covers/2226091/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260422082214.10390-1-armenon@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260422082214.10390-1-armenon@redhat.com>", "list_archive_url": null, "date": "2026-04-22T08:22:12", "name": "[v3,0/2] migration/vmstate: Add VMState support to safely migrate GByteArray", "submitter": { "id": 91136, "url": "http://patchwork.ozlabs.org/api/people/91136/?format=api", "name": "Arun Menon", "email": "armenon@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260422082214.10390-1-armenon@redhat.com/mbox/", "series": [ { "id": 500941, "url": "http://patchwork.ozlabs.org/api/series/500941/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500941", "date": "2026-04-22T08:22:13", "name": "migration/vmstate: Add VMState support to safely migrate GByteArray", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/500941/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2226091/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=U3KL70NX;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=cH0ZTWdn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0sfl3G8fz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 18:22:55 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFSr6-0006T3-43; Wed, 22 Apr 2026 04:22:44 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wFSqq-0006N6-Lq\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 04:22:30 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <armenon@redhat.com>)\n id 1wFSqo-0006aY-F3\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 04:22:27 -0400", "from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-517-Ej0-f1chO4-kQFX36aPKvw-1; Wed, 22 Apr 2026 04:22:22 -0400", "by mail-pj1-f71.google.com with SMTP id\n 98e67ed59e1d1-35d9278587bso6090204a91.2\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 01:22:22 -0700 (PDT)", "from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.110.202])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-3613fabeccesm5991459a91.6.2026.04.22.01.22.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 01:22:19 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776846143;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=v7mXcb0rV5YXLutrX/Be/AdZB7kg6iLn9t0pfFDYmrU=;\n b=U3KL70NXftYXoG/iw6b53G0ZKOwCCWtC5q7LvWIBn0jsBkt8IG8q98WYtY0W5xahmcSbdd\n N/AGDhIqryPq4NHlU71M3CZ3AeZRiZOtRo3edN0jzgyCaR6tXQP+68u9+Kpx49/seWX3Wc\n VizqwlAwEhvO1a5VyWo1bWTtXxXRv0k=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776846141; x=1777450941; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=v7mXcb0rV5YXLutrX/Be/AdZB7kg6iLn9t0pfFDYmrU=;\n b=cH0ZTWdnC+Aa6+bYyi7Qdxlg6h76Ycgp7KMOgXoUfBKhjF6GJYNt98H7pk9RWH/gHy\n cuLFD58d5y5RIag5ZstMSCMlUprXTo99gNl4ZzgoVLP/gBP/66HBpc5dLZN39ELpQBz+\n aKola9Qm1eHB8RYgnKw1tTYh3VGxrFzPpCKiy5cbozi5Fe53AfZlGZZQPjaizxNRw7+b\n HReRuCrK5cl6s3An6xlbeljROUI343EWtRtl/VCQWmmgtAIca6EDQidzacweh+fIi1pk\n odd/q4URM73mcifSRNfwB8DyO0DYHgLNnOQSM5Y0vbwQyGFi6VBBdRT98XKrRq0NL6Ba\n megQ==" ], "X-MC-Unique": "Ej0-f1chO4-kQFX36aPKvw-1", "X-Mimecast-MFC-AGG-ID": "Ej0-f1chO4-kQFX36aPKvw_1776846141", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776846141; x=1777450941;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=v7mXcb0rV5YXLutrX/Be/AdZB7kg6iLn9t0pfFDYmrU=;\n b=IziDA9QpIiPYKxNjG8opnOs51sKS9jwTodNLKIkDhQobdOAFyH0JtXy5zfrQpjRNN6\n pQTjJgKJigl3ynQObpy9c1hHSXhB0tbfZQwzc5DS7aOAqqyAbouwVkabD8S3jvHfs3d8\n yPOTRngzpuMKt6Vv3EQ/1jSHgzckrRPe/8r60bMwpA6jp+NjrZD9oknLRBPoerucOlpL\n 8ho5Q+2mME7uVdC7FZdoa47Kq5Cvmw9TstCBJfW6zhEOtOSmUY7TCMBah4WHYQ7gu2J8\n OwsV52GsjxQWgERwFO2BD6hH3ZFa+an4OMdgFBsVW7UxTbRyR4dw/IwLuGYJM195gWO3\n 33aA==", "X-Gm-Message-State": "AOJu0YzcCSkBQ0N4mXeDwmfe2KnYMiOYM8h2zPuU/TNt9kXBslif+igK\n fS+hvdHVUreisRb54ZN8jOO4eNJzMowtk5UT3zLeUviNgqGNbqSg1RNp7FBsPUQ3LEhUnUCD5vY\n d+HEwwyWoej8yU+hdzTt9B9L7234ZanVW4HlU8rPsVskmYHdaFvjQ2Q8bB91u5L2jXwLSBoh8od\n 1uV740IBe+gF5WKb1fqXvIwmUIYcO7RvNVHkHDy7U=", "X-Gm-Gg": "AeBDieu5WVyZPdcEk8XB0dAB6sS/ag+cUFxbAgqQB0+iigZneZ202WXB447v9gENdyt\n Jrc8yJIterGAVcYWkesL5BwxYplnA48XzF6QwvzOliuXEtc+ojXpAx4RwwZr6DNeTsvQZVgdQjF\n 4FuuorIFq5lp535JhTnNmZBUmTiiQakNX9i8MclVXy9Ce8/6JvHfpWexwQy/LGlr+YQtTE5q3JO\n sKBzGzMp1nKtAa+YvWqfuEZsUYeT/iUBe/YKPeNOdZdKvelJ3FD9pRK0W/rbVy97lLvzD1U2/XH\n SpaHD1musWDpXyydNM1LqI6pW4ZRBO3LZ1zCnAsiLTxurcV11EgqJZbkFTSCSdzxajfoyGYaMmk\n x/mRIdvHOC/WB+ZFX7Y7gEb/Te8/Oq9AJxgi7CspJsKv1id2wFrsQAm4uhxwf/QXy51JOYhTgWQ\n ==", "X-Received": [ "by 2002:a17:90b:4c8c:b0:35f:c1cc:fef0 with SMTP id\n 98e67ed59e1d1-36140473e42mr22550687a91.13.1776846140830;\n Wed, 22 Apr 2026 01:22:20 -0700 (PDT)", "by 2002:a17:90b:4c8c:b0:35f:c1cc:fef0 with SMTP id\n 98e67ed59e1d1-36140473e42mr22550625a91.13.1776846140099;\n Wed, 22 Apr 2026 01:22:20 -0700 (PDT)" ], "From": "Arun Menon <armenon@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Arun Menon <armenon@redhat.com>", "Subject": "[PATCH v3 0/2] migration/vmstate: Add VMState support to safely\n migrate GByteArray", "Date": "Wed, 22 Apr 2026 13:52:12 +0530", "Message-ID": "<20260422082214.10390-1-armenon@redhat.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "In GLib, GByteArray is an object managed by the library. Currently,\nmigrating a GByteArray requires treating it as a raw C struct and using\nVMSTATE_VBUFFER_ALLOC_UINT32. For example, see vmstate_vdba in\nui/vdagent.c\n\nQEMU cannot pretend that GByteArray is a C struct and simply use\nVMS_ALLOC to g_malloc() the buffer. This is because, VMS_ALLOC blindly\noverwrites the data pointer with a newly allocated buffer, thereby\nleaking the previous memory. Besides, GLib tracks the array's capacity\nin a hidden alloc field. Bypassing GLib APIs leave this capacity out of\nsync with the newly allocated buffer, potentially leading to heap buffer\noverflows during subsequent g_byte_array_append() calls.\n\nThis series adds a new VMState called VMSTATE_GBYTEARRAY, which will\ndirectly use GLib library API calls to create, or resize the object.\nThis is then used in ui/vdaagent.c replacing the use of\nVMSTATE_VBUFFER_ALLOC_UINT32.\n\nChanges in v3:\n- Add assert() checks to get and put functions to prevent NULL pointer\n dereferences, as suggested by Peter Xu.\n\nChanges in v2:\n- Marc-André pointed out the problem of not updating the device state\n itself. To do that we should essentially pass a pointer to the\n GByteArray pointer. Remove VMS_POINTER from VMSTATE_GBYTEARRAY. This\n changes 'pv' to be the address of the pointer field (GByteArray **)\n instead of the pointer's value.\n- Update get_g_byte_array and put_g_byte_array to handle this additional\n level of indirection, allowing safe allocation and updating device state.\n- Link to v1: https://lore.kernel.org/all/20260406115247.4879-1-armenon@redhat.com/\n\nArun Menon (2):\n migration/vmstate: Add VMState support for GByteArray\n ui/vdagent: Use VMSTATE_GBYTEARRAY to safely migrate outbuf\n\n include/migration/vmstate.h | 10 ++++++++++\n migration/vmstate-types.c | 37 +++++++++++++++++++++++++++++++++++++\n ui/vdagent.c | 13 +------------\n 3 files changed, 48 insertions(+), 12 deletions(-)" }