Cover Letter Detail
Show a cover letter.
GET /api/covers/2223201/?format=api
{ "id": 2223201, "url": "http://patchwork.ozlabs.org/api/covers/2223201/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/177618728515.4917.14466194789826252277-0@git.sr.ht/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<177618728515.4917.14466194789826252277-0@git.sr.ht>", "list_archive_url": null, "date": "2026-04-14T17:21:25", "name": "[qemu,v3,00/10] Update opentitan uart (part of supporting opentitan version 1)", "submitter": { "id": 92675, "url": "http://patchwork.ozlabs.org/api/people/92675/?format=api", "name": "~lexbaileylowrisc", "email": "lexbaileylowrisc@git.sr.ht" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/177618728515.4917.14466194789826252277-0@git.sr.ht/mbox/", "series": [ { "id": 499878, "url": "http://patchwork.ozlabs.org/api/series/499878/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499878", "date": "2026-04-14T17:21:25", "name": "Update opentitan uart (part of supporting opentitan version 1)", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/499878/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2223201/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=git.sr.ht\n header.i=@git.sr.ht header.a=rsa-sha256 header.s=20240113 header.b=TvEjlW9L;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwB0q70jpz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 03:22:18 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wChSH-0005tR-KS; Tue, 14 Apr 2026 13:21:41 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <outgoing@sr.ht>)\n id 1wChS9-0005rs-G1; Tue, 14 Apr 2026 13:21:33 -0400", "from mail-a.sr.ht ([46.23.81.152])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <outgoing@sr.ht>)\n id 1wChS7-0007Hq-Pr; Tue, 14 Apr 2026 13:21:33 -0400", "from git.sr.ht (unknown [46.23.81.155])\n by mail-a.sr.ht (Postfix) with ESMTPSA id 8020120A30;\n Tue, 14 Apr 2026 17:21:25 +0000 (UTC)" ], "DKIM-Signature": "a=rsa-sha256; bh=P8dgVOGwTlEde/3soL3XZGyks4q2sUF3UObCz6fViOM=;\n c=simple/simple; d=git.sr.ht;\n h=From:Date:Subject:Reply-to:To:Cc;\n q=dns/txt; s=20240113; t=1776187285; v=1;\n b=TvEjlW9LgT25aHBuuayjD/sa/m4JRYmrCBecaoN/NRejvH1beJdliiZXg5TIaOmjlCHE+Xe5\n dF0pbzyQCZr1nuXcacAgb60m0zwWc0Zih8+O7BhQFeO/Y9j159Nfp5kt+N6yDYqisj/sJbzAQKy\n qo4iZAZGcPMQknMreIt+zCZlhLN9ZWMmaGZnwU6FGXbCAYwCf1neYwVaxpVRpRi2fU50fz4I9BV\n ipVXSUKk/RyKsRKi+qVFiKyuhQYE3e92e3BEgra0jLyI7DE9etjXJ+7495va2e7woVY+ZFhHkw6\n MeWt+xLkAGxnG8+OicmacsqiZ/SLf9QrDuN4rfh2ulMtg==", "From": "~lexbaileylowrisc <lexbaileylowrisc@git.sr.ht>", "Date": "Tue, 14 Apr 2026 17:21:25 +0000", "Subject": "[PATCH qemu v3 00/10] Update opentitan uart (part of supporting\n opentitan version 1)", "MIME-Version": "1.0", "Message-ID": "<177618728515.4917.14466194789826252277-0@git.sr.ht>", "X-Mailer": "git.sr.ht", "To": "qemu-riscv@nongnu.org, Alistair Francis <Alistair.Francis@wdc.com>", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>,\n Palmer Dabbelt <palmer@dabbelt.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, qemu-devel@nongnu.org,\n qemu-riscv@nongnu.org, Amit Kumar-Hermosillo <amitkh@google.com>,\n nabihestefan <nabihestefan@google.com>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Received-SPF": "pass client-ip=46.23.81.152; envelope-from=outgoing@sr.ht;\n helo=mail-a.sr.ht", "X-Spam_score_int": "-16", "X-Spam_score": "-1.7", "X-Spam_bar": "-", "X-Spam_report": "(-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,\n DKIM_SIGNED=0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Reply-To": "~lexbaileylowrisc <lex.bailey@lowrisc.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Thanks for the review comments again!\n\nthis is the third revision of the patch set that [starts to] update\nthe OpenTitan uart to align with earlgrey version 1.0.0. I can't really\ngive a specific commit hash, but the there is a branch on the opentitan\nrepo which represents this version:\nhttps://github.com/lowRISC/opentitan/tree/earlgrey_1.0.0\n\nI can't give a specifc hash because these changes do miss out two\nimportant parts of the UART device. The clock manager is not yet present\nin upstream qemu, only in the lowRISC fork, so for now it is not\nconnected here. The other issue is that the alert handler block is\nmissing, and thus the alert test feature of the UART will not work. This\ncan only be fixed after the alert handler is also upstreamed. that will\ncome later.\n\nas before, the details of the version 1 of the UART are found here:\nhttps://opentitan.org/book/hw/ip/uart/index.html\n(and this URL is still added to the file header in one of these commits,\nas before)\n\nI have now split up that large commit into logical steps, which included\nsplitting out that change that removes the timer. You commented on this\nin the last revision. I have put this commit last because it's not\nstrictly required yet. It is a change that is included on our own fork,\nand will be needed when we add the rest of the clock handling from our\nfork. For now though, you can take or leave it as you see fit. I'm happy\nfor this patch set to merge with or without it.\n\nI think I fixed all the other comments too, sorry if I missed anything.\nThanks,\nLex.\n\n\n-----\nLex Bailey (they/them)\nlowRISC C.I.C. 7 Hills Road, Cambridge, CB2 1GE, UK. Registered in\nEngland & Wales 09272283 lex.bailey@lowrisc.org\n\nLex Bailey (10):\n Rename ibex_uart to ot_uart\n ot_uart: move to new reset API\n ot_uart: update register defs, switch to Fifo8 for tx/rx buffers\n ot_uart: replace individual IRQ fields with array, add missing IRQs\n ot_uart: gather similar behaviours togeter in register read and write\n ot_uart: implement RX fifo and loopback\n ot_uart: handle break condition\n ot_uart: update file headers with new authorship and documentation URL\n ot_uart: add tracing\n ot_uart: switch from clock driven transmission to reg R/W driven\n transmission\n\n MAINTAINERS | 1 +\n hw/char/Kconfig | 3 +\n hw/char/ibex_uart.c | 569 --------------------------\n hw/char/meson.build | 2 +-\n hw/char/ot_uart.c | 759 +++++++++++++++++++++++++++++++++++\n hw/char/trace-events | 8 +\n hw/riscv/Kconfig | 1 +\n hw/riscv/opentitan.c | 3 +-\n include/hw/char/ibex_uart.h | 73 ----\n include/hw/char/ot_uart.h | 61 +++\n include/hw/riscv/opentitan.h | 4 +-\n 11 files changed, 838 insertions(+), 646 deletions(-)\n delete mode 100644 hw/char/ibex_uart.c\n create mode 100644 hw/char/ot_uart.c\n delete mode 100644 include/hw/char/ibex_uart.h\n create mode 100644 include/hw/char/ot_uart.h" }