Cover Letter Detail
Show a cover letter.
GET /api/covers/2218890/?format=api
{ "id": 2218890, "url": "http://patchwork.ozlabs.org/api/covers/2218890/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/cover/1e443ab0-129b-42db-b224-253ba8a2f80f@gmail.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1e443ab0-129b-42db-b224-253ba8a2f80f@gmail.com>", "list_archive_url": null, "date": "2026-04-02T01:31:14", "name": "[RFC,v1,0/2] Add Rockchip USBPHY DM driver", "submitter": { "id": 75645, "url": "http://patchwork.ozlabs.org/api/people/75645/?format=api", "name": "Johan Jonker", "email": "jbx6244@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/cover/1e443ab0-129b-42db-b224-253ba8a2f80f@gmail.com/mbox/", "series": [ { "id": 498416, "url": "http://patchwork.ozlabs.org/api/series/498416/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=498416", "date": "2026-04-02T01:31:14", "name": "Add Rockchip USBPHY DM driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/498416/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2218890/comments/", "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=N26LVmi9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"N26LVmi9\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=jbx6244@gmail.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmPTH6qS4z1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 02 Apr 2026 12:31:31 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 44E7A839DF;\n\tThu, 2 Apr 2026 03:31:23 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 7023483CE3; Thu, 2 Apr 2026 03:31:20 +0200 (CEST)", "from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com\n [IPv6:2a00:1450:4864:20::52f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 71C8C80517\n for <u-boot@lists.denx.de>; Thu, 2 Apr 2026 03:31:18 +0200 (CEST)", "by mail-ed1-x52f.google.com with SMTP id\n 4fb4d7f45d1cf-66bd32f5592so46281a12.2\n for <u-boot@lists.denx.de>; Wed, 01 Apr 2026 18:31:18 -0700 (PDT)", "from ?IPV6:2a02:a449:4071:0:32d0:42ff:fe10:6983?\n ([2a02:a449:4071:0:32d0:42ff:fe10:6983])\n by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-b9c3cff0a1esm36262966b.43.2026.04.01.18.31.14\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 01 Apr 2026 18:31:16 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,\n FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775093478; x=1775698278; darn=lists.denx.de;\n h=content-transfer-encoding:content-language:cc:to:subject:from\n :user-agent:mime-version:date:message-id:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dpSX1eoMe+FuZ7BNzP3cyHF7AUUDh4Eo7rHL6N3XgpE=;\n b=N26LVmi9MYt0i5Zsd7GgJR74QKZ1izyFLHmVQzwmmzIemN6ssHYJcQ6vqiRhVjrAFJ\n 6Jk1ssbKnG8KUqwHqWd3Nj3sEMzOYMdzmMtPxyczzBWZeqkTJr5qNxrZleuGU7v5JRji\n GiVXD1PvvW7b+7P/k7Vy3MarHgjRfFIUEgc8WtgiNIm3WniVuZZliK9LdlEQ32UThTY2\n L1X02cdetwEIqvTJV3ffoggWMfNXYwKsax45GnbgNA7eSujQeAURkMALAOT4CUXgV0Fh\n 3bud+WFRap4oBEe+DgL4dKAbtLD6FgrpxikBKh7gGwsI4m6rXJs5f+MvR4Bbfp5pO7ZR\n eMWA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775093478; x=1775698278;\n h=content-transfer-encoding:content-language:cc:to:subject:from\n :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=dpSX1eoMe+FuZ7BNzP3cyHF7AUUDh4Eo7rHL6N3XgpE=;\n b=IGe2xXehdExpKrL7WkUa2aq/BG6OhGJWrScq8mk/lldVtmbJQWvxG4SZHvkbL2YZAK\n uOieFqX2w2nWkJy6bYgRl9Oo+8kTos/3UfcVs4TfNA6dvVtCbdmlJfd+R94Yc8ea2bKW\n XKkpcGne/ejyY5SnXIKikH2PycyksUobT0xjusiRBs+aQHri2MtfCV+OT1Vi51rptto8\n JfBOUT6rNfTsAjaMAQLwI0nZWF8IFXdRS5euVKKkTis2kLTKthkeToPNvHjqfNU/V3Wi\n 99Tl64k0uSeGFTmDRFkc+f14fu+sr3iS7KT6eomHNOdGsi8x2ZpdBJQZeRM0v1FYMRLr\n 9lOA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWz8yxl564Qd+DldWwIhTfIhj7Huo8d/BR8X0jVglf4gcP9JzQEBSjho2++p4+StdWfKY1Sj8E=@lists.denx.de", "X-Gm-Message-State": "AOJu0Yy85JPI+r3vrwJVEjHdwiVzUdXiz3BbNDjDTmHXBrdtJQcYuFQ1\n s2f2Yqp3HsyBe+axe9wbGkGJg1l1OZWWqGwfvHcQWNMdpaMTeXH7azh1", "X-Gm-Gg": "ATEYQzyjKXHdeOia7y8ATmJY54flQ9nshkVitjUbTQcqQbjbbdcph6bSG+wLm5+XkfO\n cQzJNsKZgUe5uUZa+jJ9YCOsJSlBsdCd41GCDvbY/hnz7rswmkgYrSv5PmEQcvnW812+Cyb6XMW\n RrV0uiHblwllIsTM6kGFNPzUiOowMiFncQSTLlzYX/AjPPvPpt99z8hd+AdiblfRSGVloUwwjXp\n /9eAGWlSFJUSN8YZRizrc2LDem6nxlKAK18Jk4LarJafNW+pcxayGjJGi4OC49+TsbIBbsvvvwv\n c9NUAaNiHQnLTouv1oRA52n284/nPj3sKOLI/PBLQQvxi8LkWb6O+cDIMA7xU9YAyTC2pNxV9R4\n VIgzaiW62liC8Va65ONlj4HHMj4X07Zh0etXOaGpyTmRZhMgJXhWiA0A4XiV0JP7vzl8Hdyldsn\n mZIG7yZaz6iZ/kU9gYqOTMUHrUxrVPcL/wgl97pzN7G+I7x+ivLMJvXgiuFqjD4yf4wZeMPVSR", "X-Received": "by 2002:a17:907:9451:b0:b9b:1963:2ff2 with SMTP id\n a640c23a62f3a-b9c1334ed91mr158477866b.0.1775093477607;\n Wed, 01 Apr 2026 18:31:17 -0700 (PDT)", "Message-ID": "<1e443ab0-129b-42db-b224-253ba8a2f80f@gmail.com>", "Date": "Thu, 2 Apr 2026 03:31:14 +0200", "MIME-Version": "1.0", "User-Agent": "Mozilla Thunderbird", "From": "Johan Jonker <jbx6244@gmail.com>", "Subject": "[RFC PATCH v1 0/2] Add Rockchip USBPHY DM driver", "To": "kever.yang@rock-chips.com", "Cc": "sjg@chromium.org, philipp.tomsich@vrull.eu, trini@konsulko.com,\n hl@rock-chips.com, jernej.skrabec@gmail.com, w.egorov@phytec.de,\n jagan@amarulasolutions.com, heiko@sntech.de, jonas@kwiboo.se,\n michael@amarulasolutions.com, marex@denx.de, u-boot@lists.denx.de,\n upstream@lists.phytec.de", "Content-Language": "en-US, ar-EG", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "7bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The Rockchip SoCs with an USB node and compatible = \"snps,dwc2\" can be HOST or OTG\nwhile the PHY driver is hard coded and initiated in the board.c file.\nAbove construction is not very U-boot DM alike.\nThis is an attempt to decouple the USBPHY into a DM driver.\n\nTested on RK3066.\nFeedback request for RK3188 and RK3288.\n\nOn older Rockchip SOCs an usbphy DT node is placed under a SYSCOM node.\n\ngrf: grf@20008000 {\n\tusbphy: usbphy {\n\n\t\tusbphy0: usb-phy@17c {\n\t\t};\n\n\t\tusbphy1: usb-phy@188 {\n\t\t};\n\t};\n};\n\nPROBLEM:\nThe usbphy node does not show up in the DM tree to be found by the\ngeneric_phy_get_by_index() function. Only by manual transfer to the DT root\nis gets detected.\n\nREQUEST:\nA little bit of help from the U-boot FDT and DM experts.\nLocking/bind a driver in the DM model that is not in DT root.\nIs this solvable with current DM stack?\n\n=> dm tree\n Class Seq Probed Driver Name\n-----------------------------------------------------------\n root 0 [ + ] root_driver root_driver\n nop 1 [ + ] rockchip_usbphy |-- usbphy\n phy 0 [ + ] rockchip_usbphy_port | |-- usb-phy@17c\n phy 1 [ + ] rockchip_usbphy_port | `-- usb-phy@188\n\nJohan Jonker (2):\n phy: rockchip: add phy-rockchip-usb2.c\n usb: phy: remove rockchip_usb2_phy.c\n\n arch/arm/dts/rk3066a-u-boot.dtsi | 29 ++\n arch/arm/dts/rk3188-u-boot.dtsi | 29 ++\n arch/arm/dts/rk3288-u-boot.dtsi | 40 +++\n arch/arm/mach-rockchip/board.c | 28 --\n configs/chromebit_mickey_defconfig | 2 +-\n configs/chromebook_jerry_defconfig | 2 +-\n configs/chromebook_minnie_defconfig | 2 +-\n configs/chromebook_speedy_defconfig | 2 +-\n configs/evb-rk3288-rk808_defconfig | 2 +-\n configs/firefly-rk3288_defconfig | 4 +-\n configs/miqi-rk3288_defconfig | 4 +-\n configs/mk808_defconfig | 2 +-\n configs/phycore-rk3288_defconfig | 3 +-\n configs/popmetal-rk3288_defconfig | 3 +-\n configs/rock-pi-n8-rk3288_defconfig | 2 +-\n configs/rock2_defconfig | 3 +-\n configs/rock_defconfig | 3 +-\n configs/tinker-rk3288_defconfig | 4 +-\n configs/tinker-s-rk3288_defconfig | 4 +-\n configs/vyasa-rk3288_defconfig | 2 +-\n drivers/phy/rockchip/Kconfig | 28 +-\n drivers/phy/rockchip/Makefile | 5 +-\n drivers/phy/rockchip/phy-rockchip-usb2.c | 379 +++++++++++++++++++++++\n drivers/usb/phy/Kconfig | 3 -\n drivers/usb/phy/Makefile | 1 -\n drivers/usb/phy/rockchip_usb2_phy.c | 113 -------\n include/usb/dwc2_udc.h | 1 -\n 27 files changed, 522 insertions(+), 178 deletions(-)\n create mode 100644 drivers/phy/rockchip/phy-rockchip-usb2.c\n delete mode 100644 drivers/usb/phy/rockchip_usb2_phy.c\n\n--\n2.39.5" }