Cover Letter Detail
Show a cover letter.
GET /api/covers/2215998/?format=api
{ "id": 2215998, "url": "http://patchwork.ozlabs.org/api/covers/2215998/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/cover/20260325-fix_pciatops-v6-0-10bf19d76dd1@linux.ibm.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260325-fix_pciatops-v6-0-10bf19d76dd1@linux.ibm.com>", "list_archive_url": null, "date": "2026-03-25T15:16:16", "name": "[v6,0/2] PCI: AtomicOps: Fix pci_enable_atomic_ops_to_root()", "submitter": { "id": 85804, "url": "http://patchwork.ozlabs.org/api/people/85804/?format=api", "name": "Gerd Bayer", "email": "gbayer@linux.ibm.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/cover/20260325-fix_pciatops-v6-0-10bf19d76dd1@linux.ibm.com/mbox/", "series": [ { "id": 497465, "url": "http://patchwork.ozlabs.org/api/series/497465/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=497465", "date": "2026-03-25T15:16:18", "name": "PCI: AtomicOps: Fix pci_enable_atomic_ops_to_root()", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/497465/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2215998/comments/", "headers": { "Return-Path": "\n <linux-pci+bounces-51102-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=gneg3v9y;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51102-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"gneg3v9y\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.158.5", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgs6121cGz1y1K\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 02:59:05 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 682AC33D5654\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 15:16:48 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 56141346FAD;\n\tWed, 25 Mar 2026 15:16:36 +0000 (UTC)", "from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DE00020010C;\n\tWed, 25 Mar 2026 15:16:34 +0000 (UTC)", "from pps.filterd (m0356516.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62P1HmXV2945148;\n\tWed, 25 Mar 2026 15:16:30 GMT", "from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1ktv08m7-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 25 Mar 2026 15:16:29 +0000 (GMT)", "from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 62PC6MbX004380;\n\tWed, 25 Mar 2026 15:16:28 GMT", "from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])\n\tby ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d28c26sgh-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tWed, 25 Mar 2026 15:16:28 +0000", "from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com\n [10.20.54.100])\n\tby smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 62PFGOOd41156904\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tWed, 25 Mar 2026 15:16:24 GMT", "from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8B3092004B;\n\tWed, 25 Mar 2026 15:16:24 +0000 (GMT)", "from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3F0EB20040;\n\tWed, 25 Mar 2026 15:16:24 +0000 (GMT)", "from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9])\n\tby smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tWed, 25 Mar 2026 15:16:24 +0000 (GMT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774451796; cv=none;\n b=BRocw2/GmocDGHjCEe9NjOww3xVAW2or7m4NAjOfoLjxplZx+ol9WjGEMAxUwcZFob4CUkekkKFyk5PZzwHCCW1Kc1cEBYqTy3RylINKhVB6pIngrplnjoZEVv+ochaakO+60vA1uY3oMbmOUlHofkuldhlGkk+8VuuFwwseOcs=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774451796; c=relaxed/simple;\n\tbh=VpbZhNuuSl/ns05S2kGFJP+U2qoOXBtQ2LQID/TIRtI=;\n\th=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc;\n b=CvcXbzVNs7E1EUqwKThaVEewUw5ffP3WkLhl+ZJrTKYoCa4mfVTG/kahN08BXghm8k61xTaMc+eKKo0ekRv69Nj6T6lciCIMoy/pa3/hHO8/GDZ/K/Uk2eTstxFXDWmIlmIf0V0gKyGWb49lDB3p9iL/mrWRRQL4hR5mqGyuhJw=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=gneg3v9y; arc=none smtp.client-ip=148.163.158.5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:message-id\n\t:mime-version:subject:to; s=pp1; bh=02sTmvQ1zAB6bEnH7R8KDUUjdfiw\n\tm1jwy5u8OYUaRS8=; b=gneg3v9ykjLDh13RUpbib2s6I9us1k/FkHkgS7uMJeZ8\n\tRUmp323tjLcEzXoN4Z8uyGKoHgLUcBR81qZNuKyyldGoghVWID6AiBzgMsE+5uLc\n\tR9WyUuB6D5R4r5iZsmwvZtuZNNUxmgfQvCuvWZFaCzAeIKpeWkTWOsYKxq99MOWx\n\tYw224eEVbv/jihc4EyGsuRE0hTsK2hSRvVq9aYGlLpJMsGFU/Tsoorg5pb3RSXYk\n\tA0lcp1fzbJ+34yvp8q/yjUnXJ/HjnD1gOc1tbgjbq/+CKOVJ6zlqY3z71x1HH1tm\n\tqNSxTIUtrRt+Rw5bK7uFGtZWrMF9hCVH06m1A8tFGw==", "From": "Gerd Bayer <gbayer@linux.ibm.com>", "Subject": "[PATCH v6 0/2] PCI: AtomicOps: Fix pci_enable_atomic_ops_to_root()", "Date": "Wed, 25 Mar 2026 16:16:16 +0100", "Message-Id": "<20260325-fix_pciatops-v6-0-10bf19d76dd1@linux.ibm.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-B4-Tracking": "v=1; b=H4sIAED8w2kC/23P3WrDMAwF4Fcpvp6LLdV23Ku9xxjDP8pqWJMQd\n 6aj5N3nlI11JpdH4nxIN5ZpTpTZcXdjM5WU0zjUoJ92LJzc8E48xZoZCFBSCs37dH2bQnKXccr\n cUKdFRyF4gaxWppnq/s69vNZ8Svkyzl93vch1+gNJ8R8qkgtOMajOKeM10PNHGj6v++TP+zCe2\n YoV+ANANpcUqEAUEsl6Q0CbAP4CWmD7SsEKWBsl+OB6L+0WcHgAJDbAYQXQByOcRotqC1APALS\n AqkDvojOA6Mh1LbAsyzeQ/xyisAEAAA==", "X-Change-ID": "20251106-fix_pciatops-7e8608eccb03", "To": "Bjorn Helgaas <bhelgaas@google.com>, Jay Cornwall <Jay.Cornwall@amd.com>,\n Felix Kuehling <Felix.Kuehling@amd.com>,\n Christian Borntraeger <borntraeger@linux.ibm.com>,\n Niklas Schnelle <schnelle@linux.ibm.com>", "Cc": "Gerald Schaefer <gerald.schaefer@linux.ibm.com>,\n Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,\n Alexander Gordeev <agordeev@linux.ibm.com>,\n Sven Schnelle <svens@linux.ibm.com>,\n Leon Romanovsky <leon@kernel.org>,\n Alexander Schmidt <alexs@linux.ibm.com>, linux-s390@vger.kernel.org,\n linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n Gerd Bayer <gbayer@linux.ibm.com>, stable@vger.kernel.org", "X-Mailer": "b4 0.14.2", "X-TM-AS-GCONF": "00", "X-Proofpoint-Reinject": "loops=2 maxloops=12", "X-Proofpoint-ORIG-GUID": "uQjG6wlYtha8bjQIqZwWRzjebZrwsQDO", "X-Authority-Analysis": "v=2.4 cv=aMr9aL9m c=1 sm=1 tr=0 ts=69c3fc4d cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8\n a=VnNF1IyMAAAA:8 a=vQOT1DpSoXcvsw1ccD4A:9 a=QEXdDO2ut3YA:10", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzI1MDEwNiBTYWx0ZWRfX2GpDRAcc6WTz\n 1HSdAIaG00oASGwIuCFa6XeHxOR0NoGEHIKMQFmACACBss1N41BmzFVu63Ha//zUCjHgN2AAJW+\n K3tFA3s0pOfj7Swva3WEFJJB70AuF+HSXhBlnEMf9Nbwiuf20Ggwjg3bwowAFt5TrrkSeD/LwyV\n FXyC7FfxgwoG1JNG8nbzZvSqe+msGrPgxrbggPgxscqf82gMJsix/VmvjecEkp2jRpX4RxgScbn\n IogOwZZ/+ka6J378SkulTFktb6oPiryxPOpm+dsmgsakLYmC5NPs9TjRzSS1At6/UFm7VpSB17+\n bNOrHq6UK8CRkNtMG7dLQGqt2vb2fGON2mHVICp2M0XIblt2PAXH/XtUXLSOgAi5uCy6ud1nJkX\n r455av+7ObpP8nAdwhLzF7n90SutxmmgOm88oXVxt6NDvJ7Tmy/q49X9Aae+ykrScIEbe6aSuoy\n HZo88bJJ0GlPWMxv7EQ==", "X-Proofpoint-GUID": "joWoaCiOBWI4xkTdCkeMdT5UmKbpaHg5", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-25_04,2026-03-24_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0\n suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250106" }, "content": "Hi Bjorn et al.\n\nOn s390, AtomicOp Requests are enabled on a PCI function that supports\nthem, despite the helper being ignorant about the root port's capability\nto supporting their completion.\n\nPatch 1: Fix the logic in pci_enable_atomic_ops_to_root()\nPatch 2: Update references to PCIe spec in that function.\n\nI did test that the issue is fixed with these patches. Also, I verified\nthat on a Mellanox/Nvidia ConnectX-6 adapter plugged straight into the\nroot port of a x86 system still gets AtomicOp Requests enabled.\n\nDue to lacking the required hardware, I did not test this with any PCIe\nswitches between root port and endpoint. So test exposure to other\nenvironments is highly appreciated. One particularly rare setup is a\nRCiEP that might act as a AtomicOps Requestor - but was subject to a\nregression in v4 as reported by Sashiko.\n\nv5 of this series tries to make no functional changes for that class of\ndevices either.\n\nSigned-off-by: Gerd Bayer <gbayer@linux.ibm.com>\n---\nChanges in v6:\n- Incorporate Ilpo's editorial comments.\n- Correct logic in pci_is_atomicops_capable_rp() (annotated by Sashiko)\n- Link to v5: https://lore.kernel.org/r/20260323-fix_pciatops-v5-0-fada7233aea8@linux.ibm.com\n\nChanges in v5:\n- Introduce new pcibios_connects_to_atomicops_capable_rc() so arch's can\n declare AtomicOps support outside of PCIe config space. Defaults to\n \"true\" - except s390.\n- rebase to 7.0-rc5\n- Link to v4: https://lore.kernel.org/r/20260313-fix_pciatops-v4-0-93bc70a63935@linux.ibm.com\n\nChanges in v4:\n- drop patch 1 - it will become the base of a new series\n- previous patch 2, now 1: reword commit message\n- add a new patch to update references to PCI spec within\n pci_enable_atomic_ops_to_root()\n- rebase to latest master\n- Link to v3: https://lore.kernel.org/r/20260306-fix_pciatops-v3-0-99d12bcafb19@linux.ibm.com\n\nChanges in v3:\n- rebase to 7.0-rc2\n- gentle ping\n- add netdev and rdma lists for awareness\n- Link to v2: https://lore.kernel.org/r/20251216-fix_pciatops-v2-0-d013e9b7e2ee@linux.ibm.com\n\nChanges in v2:\n- rebase to 6.19-rc1\n- otherwise unchanged to v1\n- Link to v1: https://lore.kernel.org/r/20251110-fix_pciatops-v1-0-edc58a57b62e@linux.ibm.com\n\n---\nGerd Bayer (2):\n PCI: AtomicOps: Do not enable without support in root complex\n PCI: AtomicOps: Update references to PCIe spec\n\n arch/s390/pci/pci.c | 5 +++++\n drivers/pci/pci.c | 54 +++++++++++++++++++++++++++++++++--------------------\n include/linux/pci.h | 1 +\n 3 files changed, 40 insertions(+), 20 deletions(-)\n---\nbase-commit: c369299895a591d96745d6492d4888259b004a9e\nchange-id: 20251106-fix_pciatops-7e8608eccb03\n\nBest regards," }