Cover Letter Detail
Show a cover letter.
GET /api/covers/2215486/?format=api
{ "id": 2215486, "url": "http://patchwork.ozlabs.org/api/covers/2215486/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/cover/20260324170212.481394-1-tomas.alvarez-vanoli@hitachienergy.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260324170212.481394-1-tomas.alvarez-vanoli@hitachienergy.com>", "list_archive_url": null, "date": "2026-03-24T17:02:11", "name": "[0/1] spi: fsl_espi: fix din offset", "submitter": { "id": 87680, "url": "http://patchwork.ozlabs.org/api/people/87680/?format=api", "name": "Tomas Alvarez Vanoli", "email": "tomas.alvarez-vanoli@hitachienergy.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/cover/20260324170212.481394-1-tomas.alvarez-vanoli@hitachienergy.com/mbox/", "series": [ { "id": 497323, "url": "http://patchwork.ozlabs.org/api/series/497323/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=497323", "date": "2026-03-24T17:02:11", "name": "spi: fsl_espi: fix din offset", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/497323/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2215486/comments/", "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.a=rsa-sha256 header.s=duo-1630306886989-947ac67a header.b=jUFlW2Y6;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.a=rsa-sha256 header.s=dkim-high header.b=TAjXY483;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=hitachienergy.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=hitachienergy.com header.i=@hitachienergy.com\n header.b=\"jUFlW2Y6\";\n\tdkim=pass (2048-bit key;\n unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org\n header.b=\"TAjXY483\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=hitachienergy.com", "phobos.denx.de; spf=pass\n smtp.mailfrom=tomas.alvarez-vanoli@hitachienergy.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgHm14lBmz1y1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 04:56:33 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9EEF3807C0;\n\tTue, 24 Mar 2026 18:56:28 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id E245A838BB; Tue, 24 Mar 2026 18:02:29 +0100 (CET)", "from out-ip0052.fra.mailhop.org (out-ip0052.fra.mailhop.org\n [18.158.144.38])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B00FA80087\n for <u-boot@lists.denx.de>; Tue, 24 Mar 2026 18:02:27 +0100 (CET)", "from HPG0000000331.corp.hitachi-powergrids.com (unknown\n [20.71.22.178]) by outbound2.eu.mailhop.org (Halon) with ESMTPSA\n id 3ab56a5a-27a3-11f1-be08-754228886235;\n Tue, 24 Mar 2026 17:02:24 +0000 (UTC)", "from gitsiv.hitachienergy.com (unknown [10.54.139.14])\n by HPG0000000331.corp.hitachi-powergrids.com (Postfix) with ESMTP id\n 440794043;\n Tue, 24 Mar 2026 17:02:24 +0000 (UTC)", "from chbrn3-p-dev026.keymile.net (chbrn3-p-dev026.keymile.net\n [172.31.41.203])\n by gitsiv.hitachienergy.com (Postfix) with ESMTP id 1C0C460B7D47;\n Tue, 24 Mar 2026 18:02:24 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=hitachienergy.com; s=duo-1630306886989-947ac67a;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n cfbl-address:cfbl-feedback-id:from;\n bh=hCh4BjxCaHJSjrb0314AwLSZwsHFgPH5LEc7JuM7tjE=;\n b=jUFlW2Y6p+2hZjCIBhtbDzRm0Lmyjzxliimp7YCWNXqqQGAsOaeGa3fZVDsgbWnYlNh4TyXOz2eKb\n ajvhiBpRqP1/YAJu00ftpjCtcvlEsgeuW4vHIl2xczr7zT74e8atZTtiVIK6Nf2G2dG6SpMxkclJvb\n 53mdLP5RyvSU9X+I=", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=outbound.mailhop.org; s=dkim-high;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from:\n cfbl-address:cfbl-feedback-id:from;\n bh=hCh4BjxCaHJSjrb0314AwLSZwsHFgPH5LEc7JuM7tjE=;\n b=TAjXY4835HNeG+BAwbpTVYRyqHp1ffZbpKpXYmKKWrRBxvMOJOQAI0dny2BYNYo8BCDWMDKPKIFqg\n tAf8j15XgOWM7T8jpK+RMvw9BQVsS0iSb34osnKRKukryVGQPFXpRU8KA8JBzug/smcUunc+7YWDTr\n oalAM00hO75LelLTPNmKffU8jGecBTbrFoit6CaqsU69I9qeOnYtS5hrOMu9CBoDdVLAkjO1Zg2Jer\n jah/NrNYYvLcjpjnfLNW2rsYulb2JIjNV9H17fGT2cGDapIgPryUv3TthkU4uVRHgL7YvP+c2TdhCV\n OtjqPR60XoFelT/E7erXFrvJCOVwCxQ==" ], "X-Originating-IP": "20.71.22.178", "X-MHO-RoutePath": "aGVkY3NtdHA=", "X-MHO-User": "3ab56a5a-27a3-11f1-be08-754228886235", "X-Report-Abuse-To": "\n https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information", "X-Mail-Handler": "DuoCircle Outbound SMTP", "CFBL-Feedback-ID": "3ab56a5a-27a3-11f1-be08-754228886235:5", "CFBL-Address": "prvs=0543124a45=abuse@outbound.mailhop.org; report=arf", "From": "Tomas Alvarez Vanoli <tomas.alvarez-vanoli@hitachienergy.com>", "To": "u-boot@lists.denx.de", "Cc": "trini@konsulko.com, chuanhua.han@nxp.com,\n Tomas Alvarez Vanoli <tomas.alvarez-vanoli@hitachienergy.com>", "Subject": "[PATCH 0/1] spi: fsl_espi: fix din offset", "Date": "Tue, 24 Mar 2026 18:02:11 +0100", "Message-ID": "<20260324170212.481394-1-tomas.alvarez-vanoli@hitachienergy.com>", "X-Mailer": "git-send-email 2.47.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Tue, 24 Mar 2026 18:56:27 +0100", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Hello,\n\nWhile working on an old T1040-based board, I ran into issues when reading data\nwith spi_xfer. It seems to me that the driver is copying the data back to the\ncaller at the wrong addresses. I am not entirely sure what was the intention\nwith the original code as far as I can tell.\n\nWith my suggested change, at least a small tx of 3 bytes works correctly and I\ncan see the expected data in the buffer.\n\nI've really only tested this with a 2016 version of u-boot but the code has not\nchanged regarding this since then, and I suspect that there's not a lot of\nboards left using this driver to read spi data in u-boot :)\n\nBest regards,\nTomas\n\nTomas Alvarez Vanoli (1):\n spi: fsl_espi: fix din offset\n\n drivers/spi/fsl_espi.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)" }