Cover Letter Detail
Show a cover letter.
GET /api/covers/2211190/?format=api
{ "id": 2211190, "url": "http://patchwork.ozlabs.org/api/covers/2211190/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260316072053.1241987-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260316072053.1241987-1-aleksandr.loktionov@intel.com>", "list_archive_url": null, "date": "2026-03-16T07:20:51", "name": "[iwl-next,v5,0/2] ice: implement symmetric RSS hash configuration", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260316072053.1241987-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 496019, "url": "http://patchwork.ozlabs.org/api/series/496019/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=496019", "date": "2026-03-16T07:20:52", "name": "ice: implement symmetric RSS hash configuration", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/496019/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2211190/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=detz7+YM;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fZ62h31dRz1xqn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 16 Mar 2026 18:21:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B425740C8A;\n\tMon, 16 Mar 2026 07:21:01 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id AhItdwfQhDwt; Mon, 16 Mar 2026 07:21:00 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 4364440C88;\n\tMon, 16 Mar 2026 07:21:00 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id C8881D3\n for <intel-wired-lan@lists.osuosl.org>; Mon, 16 Mar 2026 07:20:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id B67D240C81\n for <intel-wired-lan@lists.osuosl.org>; Mon, 16 Mar 2026 07:20:58 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Z6zakszmmMwM for <intel-wired-lan@lists.osuosl.org>;\n Mon, 16 Mar 2026 07:20:58 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by smtp4.osuosl.org (Postfix) with ESMTPS id B3A5540C80\n for <intel-wired-lan@lists.osuosl.org>; Mon, 16 Mar 2026 07:20:56 +0000 (UTC)", "from orviesa007.jf.intel.com ([10.64.159.147])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Mar 2026 00:20:56 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa007.jf.intel.com with ESMTP; 16 Mar 2026 00:20:55 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4364440C88", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org B3A5540C80" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1773645660;\n\tbh=H48cvs97Khlf4xvRcHC1E565UJSXN/21EEA5xFeq6Is=;\n\th=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=detz7+YMxkR7esisjY/0rMWcIn2UoH/dZH43QaN5dheyuCMD0VCA5xDoCAgUbUA12\n\t Z2visIGxJksh0I7XP36eRaSEFo1NhzcAZy4mqkEWuAbAG2rtXcGyHndB8roDs3aaG5\n\t SytQDb/vmcUOo1zQSNcH2ZgwXrWLFBUObqguYic9OEo7WydSKD/GNrqzwUmc73AA36\n\t sG+EG2JqCgJIYHKVeKwj8f0cKH2+Ww52Au6dsNGMKu/lY6oONyLK9BecHt5w+wJWFQ\n\t U3chXXJdg9XjDXXX1nyudSecgTAwYcBt/HG8p2WeISGShOtOuXqo19xaBVIqsyOMbg\n\t +mnkNRavWVglA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.11;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org B3A5540C80", "X-CSE-ConnectionGUID": [ "7fnMIHm8RRewLfVfE2Rq7A==", "7ejrkCxsQCuWLn/rS8Qhzg==" ], "X-CSE-MsgGUID": [ "Iw0yDdZLS8+W7mMcO/c/fA==", "YlyGacnDTT2ZtH2WjcxdbA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11730\"; a=\"84970605\"", "E=Sophos;i=\"6.23,123,1770624000\"; d=\"scan'208\";a=\"84970605\"", "E=Sophos;i=\"6.23,123,1770624000\"; d=\"scan'208\";a=\"222030138\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n anthony.l.nguyen@intel.com, aleksandr.loktionov@intel.com", "Date": "Mon, 16 Mar 2026 08:20:51 +0100", "Message-ID": "<20260316072053.1241987-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1773645658; x=1805181658;\n h=from:to:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=54qse0Zod1IPGDYwpG/5iToZX2jpx6R59l5KQJ9Nw7A=;\n b=VxQTwFq4d4biyc0oSsT1Vjoksz4XeUxCL5SmOjxss80cQ1ArlK2tCHTO\n 7v53yVZgzKd3l3oq2yZRSknPvtSE3kYkYB4EOfTY9wqRZFQSp2LGJYaem\n RR508BGi1laQNXltk8LJseoVqQlPXM5CqyTo6hYUVL9yUOwpOgQxczNjq\n pxg5uz5QwrOBBQIT0/LlveU2sYr+/3zcTwiI8rundjNCMbpNPxodYfxj0\n i8aZtf0CfYpuzYlYIAz/O0vQN9sZPJTQ2wFZ/eaezVd1+TZE0cQPhFMwI\n Mw10aq81t37fj2hqWw1eLFvYIjwBauMsa015dSlpqPvr90rnKjHsnV/kk\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=VxQTwFq4" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v5 0/2] ice: implement symmetric\n RSS hash configuration", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The ice driver has advertised symmetric RSS support via\nsupported_input_xfrm since the capability was added, but ice_set_rxfh()\nignored the input_xfrm parameter entirely, so enabling symmetric hashing\nhad no actual effect.\n\nThis series fixes that. Patch 1 extends the ethtool core so that\ndrivers hashing GTP flows on TEID can report it honestly without\nblocking symmetric-xor configuration. Patch 2 wires up the ice driver.\n\nThe need for patch 1 surfaced because GTP flow profiles in ice always\ninclude TEID in the hash. ethtool_check_flow_types() calls\nget_rxfh_fields() for every hashable flow type before allowing\nsymmetric-xor; ethtool_rxfh_config_is_sym() rejected any bitmap\ncontaining RXH_GTP_TEID since it has no src/dst counterpart. TEID\nis the same value in both tunnel directions, so this rejection is\nincorrect: including it does not break symmetry.\n\nRather than hiding TEID from the reported fields (which would silently\nmisrepresent hardware behaviour), patch 1 fixes the validator, and\npatch 2 reports TEID honestly.\n\nTested with tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py\non an E810 card running kernel 6.19-rc8.\n\n---\nv4 -> v5:\n - remove redundant (u64) type conversion\n\nv3 -> v4:\n - Drop the ICE_HASH_INVALID fallback in ice_get_rxfh_fields() that\n fabricated default L3+L4 hash fields when no hardware RSS config\n exists for a flow type; returning zero fields is more honest and\n avoids misrepresenting hardware state\n - Drop the companion \"if (!l3 && !l4)\" special case in the\n pair-completion block; it was only necessary to cover the synthetic\n defaults added by the fallback, which is now gone\n - No functional change to ice_set_rxfh() or the ethtool core patch\n\nv2 -> v3:\n - Split into 2 patches: ethtool core fix separate from driver change\n - Drop the RXH_GTP_TEID stripping workaround from the driver; instead\n fix ethtool_rxfh_config_is_sym() to accept TEID as intrinsically\n symmetric (patch 1)\n - Fix ice_get_rxfh_fields(): the v2 unconditional assignment\n \"nfc->data = ICE_RSS_ALLOWED_FIELDS\" clobbered fields set earlier in\n the same function; replaced with pair-completion using |= so only\n the missing half of a partial pair is filled in\n - Remove ICE_RSS_ALLOWED_FIELDS define (no longer needed)\n - Report RXH_GTP_TEID honestly for GTP flow types\n\nv1 -> v2:\n - Preserve valid symmetric RSS fields instead of overwriting nfc->data\n unconditionally\n\nAleksandr Loktionov (2):\n ethtool: treat RXH_GTP_TEID as intrinsically symmetric\n ice: implement symmetric RSS hash configuration\n\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 40 +++++++++++++---\n drivers/net/ethernet/intel/ice/ice_lib.c | 7 ++--\n drivers/net/ethernet/intel/ice/ice_lib.h | 1 +\n net/ethtool/common.c | 3 +++\n 4 files changed, 40 insertions(+), 11 deletions(-)" }