Cover Letter Detail
Show a cover letter.
GET /api/covers/2197024/?format=api
{ "id": 2197024, "url": "http://patchwork.ozlabs.org/api/covers/2197024/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260216212952.420120-1-jsnow@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260216212952.420120-1-jsnow@redhat.com>", "list_archive_url": null, "date": "2026-02-16T21:29:32", "name": "[v7,00/19] python: drop qemu.qmp from qemu.git tree", "submitter": { "id": 64343, "url": "http://patchwork.ozlabs.org/api/people/64343/?format=api", "name": "John Snow", "email": "jsnow@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260216212952.420120-1-jsnow@redhat.com/mbox/", "series": [ { "id": 492353, "url": "http://patchwork.ozlabs.org/api/series/492353/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=492353", "date": "2026-02-16T21:29:34", "name": "python: drop qemu.qmp from qemu.git tree", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/492353/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2197024/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hqbXivGt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFGFB6QZKz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 08:31:58 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vs6AX-0005YC-Gq; Mon, 16 Feb 2026 16:30:13 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jsnow@redhat.com>) id 1vs6AW-0005Xa-AU\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:30:12 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jsnow@redhat.com>) id 1vs6AT-0003pZ-KQ\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:30:12 -0500", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-351--khj8uOlMeSpz_fDsZizVw-1; Mon,\n 16 Feb 2026 16:30:04 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id ED8C11955D7A; Mon, 16 Feb 2026 21:30:00 +0000 (UTC)", "from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.120])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7AD9F19560A2; Mon, 16 Feb 2026 21:29:54 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771277407;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=MtBCL7UOtkzlqsKKTJdf2TCiC+3Nt+OdmZZ43ilsAIs=;\n b=hqbXivGthfsnkkyoK54XS9Zl7oYtS6m3CBJUrBwI0LMC/ow+Htur9joisUZcmkvdffRAGJ\n 5CJMtUs8EliYbpnWVGdlxqoXCj9m4elpTuIzhpmBf5YHsWVREcbPTzuaAD8vQRNB88oepP\n /GbBYue9YSNHF7OWx8Acm98R9T0YXc8=", "X-MC-Unique": "-khj8uOlMeSpz_fDsZizVw-1", "X-Mimecast-MFC-AGG-ID": "-khj8uOlMeSpz_fDsZizVw_1771277402", "From": "John Snow <jsnow@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Cleber Rosa <crosa@redhat.com>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Markus Armbruster <armbru@redhat.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Thomas Huth <thuth@redhat.com>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,\n Kyle Evans <kevans@freebsd.org>, Peter Xu <peterx@redhat.com>, =?utf-8?q?Al?=\n\t=?utf-8?q?ex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Daniel_P=2E_?=\n\t=?utf-8?q?Berrang=C3=A9?= <berrange@redhat.com>,\n Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,\n Yonggang Luo <luoyonggang@gmail.com>, John Snow <jsnow@redhat.com>,\n Warner Losh <imp@bsdimp.com>, Maksim Davydov <davydov-max@yandex-team.ru>,\n Alexandre Iooss <erdnaxe@crans.org>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Ed Maste <emaste@freebsd.org>, Kevin Wolf <kwolf@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, Michael Roth <michael.roth@amd.com>,\n Li-Wen Hsu <lwhsu@freebsd.org>, Hanna Reitz <hreitz@redhat.com>", "Subject": "[PATCH v7 00/19] python: drop qemu.qmp from qemu.git tree", "Date": "Mon, 16 Feb 2026 16:29:32 -0500", "Message-ID": "<20260216212952.420120-1-jsnow@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "quoted-printable", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Hello!\n\nThis series drops the in-tree version of our python-qemu-qmp package\n(\"qemu.qmp\") in favor of the version hosted on PyPI, whose repository is\nlocated at https://gitlab.com/qemu-project/python-qemu-qmp.\n\nGitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/2329875804\n\nThe major effects of this patch series are:\n\n1. qemu.qmp and the python/ directory will be installed to the\n configure-time venv (build/pyvenv) by default.\n2. qemu.qmp will be installed from PyPI or vendored packages instead of\n being utilized directly from the qemu.git tree.\n3. \"make check-venv\" is removed as it is no longer needed.\n4. functional test dependencies are installed as-needed when running\n those tests.\n5. Unfortunately, python3-wheel and python3-setuptools are now required\n on the host system if tests are to be executed and >= Python 3.13 is\n used.\n6. An awful lot of deleted lines of code, and a lot fewer headaches\n managing two nearly-identical copies of this source code. O:-)\n\nv7:\n\n - Fixed OpenBSD VM test\n - Fixed a recently failing MacOS test, by...\n - Upgraded lcitool to latest version\n - Upgraded Fedora from 41 -> 43\n - Upgraded Alpine from 3.21 -> 3.23\n - Included contrig/plugins/cpp fix for CI testing purposes\n - Added minimum versions for setuptools and wheel to pythondeps.toml\n\nNote that v7 sees a new(?) failure in check-rust-tools-nightly as a\nresult of the Fedora 43 upgrade. I think this series has spiralled out\nof control trying to keep the CI green and I am not familiar enough with\nour rust tooling to go and fix this myself. The tox test is *also* still\nfailing, but not because of this series - and will be fixed in a\nseparate series that updates our Python testing.\n\nv6:\n\n - Added workaround for configure-less VM tests\n\nv5:\n\n - Changed the local package install mechanism as per Paolo's advice\n - Changed \"file://\" mechanism for local installs, following the msys2\n test fixes upstream that did the same\n - Fix typo in cover letter (thuth)\n - Fixed comments around mkvenv invocations; functests group will\n *always* use the --online flag, whether or not it was\n configured. (danpb)\n - Please, let this nightmare be over\n\nv4:\n\n - Rename \"checktests\" group to \"tooling\", install it by default\n alongside meson at configure-time.\n - Remove \"check-venv\" entirely.\n - Update python/README.rst to reflect the new paradigm\n - Update many scripts that import qemu.qmp to give new errors when they\n are run outside of the configure venv\n\nKNOWN ISSUES IN V4:\n\n - The last patch is an RFC based on Thomas' observations, I don't have\n a strong opinion on if we want it or not.\n - Removing \"make check-venv\" causes the VM tests to rebuild more often;\n I was not sure how to replace the old conditional behavior in an\n equivalent manner. Suggestions, anyone...?\n\nv3:\n\n - Fixed FreeBSD vm test\n - Fixed Cirrus macOS test (Needed setuptools as a dep, \"file:///\" had\n one too many forward slashes, which works fine for older\n pip/setuptools, but was incompatibly fixed recently.)\n - Fixed an issue that prevented installing the local python packages in\n an offline, isolated build environment (need --no-isolated-build and\n pip environment variable flags)\n - Added the python3-wheel and python3-setuptools build dependencies to\n lcitool, owing to the above issues\n - Ensured that the $download flag (for PyPI access) from configure is\n carried over into pytest/meson.build invocations. This defaults to\n \"enabled\", so test dependencies should not have any issue being\n fetched on most developer workstations and build environments.\n - Fixed several bugs in the mkvenv.py local package installation mechanism.\n - Flags and workarounds added for installing local packages offline now\n apply *only* to local package installations, and not \"normal\"\n depspecs.\n - Reordered patches into more logical \"phases\" for easier review (I\n hope...?)\n\nKnown issues: \"make check-build\" still installs all of the test\ndependencies to the pyvenv. I'm not sure if this is desired or not, but\nI ran into problems preventing it from doing this without breaking a ton\nof CI tests. I'll continue to investigate this, but wanted to send this\nv3 out.\n\nv2:\n\n - move \"make check-venv\" earlier in GitLab CI/CD pipeline, to avoid\n re-running configure\n - Fix functional tests not using PyPI to fetch pygdbmi package\n - Remove pre-requisites which are now merged\n\n--js\n\nJohn Snow (18):\n python/mkvenv: create timestamp file for each group \"ensured\"\n python/mkvenv: bump 'qemu.qmp' dependency for testdeps\n python/mkvenv: add 'tooling' and 'functests' dependency groups\n python/mkvenv: add mechanism to install local package(s)\n meson, mkvenv: add functests custom target\n tests: Use configured python to run GitLab iotests\n tests: use \"run\" script to execute device-crash-test\n tests/lcitool: update lcitool to latest version\n tests/lcitool: add python3 wheel and setuptools deps for qemu\n python: add vendored qemu.qmp package\n meson, mkvenv: make functional tests depend on functests group\n meson, mkvenv: add qemu.git/python/qemu package to pythondeps.toml\n configure: unconditionally install \"tooling\" group\n tests: replace check-venv with vm-venv target\n scripts: nudge users to use 'run' script for scripts that import\n qemu.qmp\n python: delete qemu.qmp\n python: update README.rst to reflect qemu.qmp's removal\n python: add setuptools and wheel dependencies\n\nPierrick Bouvier (1):\n [do-not-merge] contrib/plugins/cpp: use __has_include\n\n python/README.rst | 52 +-\n configure | 2 +-\n meson.build | 1 +\n .gitlab-ci.d/buildtest.yml | 26 +-\n .gitlab-ci.d/cirrus/freebsd-14.vars | 2 +-\n .gitlab-ci.d/cirrus/macos-14.vars | 2 +-\n .gitlab-ci.d/windows.yml | 2 +\n contrib/plugins/cpp.cpp | 261 +++-\n python/qemu/qmp/__init__.py | 60 -\n python/qemu/qmp/error.py | 53 -\n python/qemu/qmp/events.py | 751 -----------\n python/qemu/qmp/legacy.py | 339 -----\n python/qemu/qmp/message.py | 217 ----\n python/qemu/qmp/models.py | 146 ---\n python/qemu/qmp/protocol.py | 1101 -----------------\n python/qemu/qmp/py.typed | 0\n python/qemu/qmp/qmp_client.py | 732 -----------\n python/qemu/qmp/qmp_shell.py | 689 -----------\n python/qemu/qmp/qmp_tui.py | 665 ----------\n python/qemu/qmp/util.py | 150 ---\n python/qemu/utils/qom_fuse.py | 1 -\n python/scripts/mkvenv.py | 43 +-\n python/scripts/vendor.py | 2 +\n python/setup.cfg | 31 +-\n python/tests/minreqs.txt | 8 +-\n python/tests/protocol.py | 596 ---------\n python/wheels/qemu_qmp-0.0.5-py3-none-any.whl | Bin 0 -> 72263 bytes\n pythondeps.toml | 21 +-\n pyvenv/meson.build | 27 +\n scripts/compare-machine-types.py | 7 +-\n scripts/device-crash-test | 5 +-\n scripts/qmp/qemu-ga-client | 13 +-\n scripts/qmp/qmp-shell | 13 +-\n scripts/qmp/qmp-shell-wrap | 13 +-\n scripts/qmp/qom-fuse | 13 +-\n scripts/qmp/qom-get | 13 +-\n scripts/qmp/qom-list | 13 +-\n scripts/qmp/qom-set | 13 +-\n scripts/qmp/qom-tree | 13 +-\n scripts/qmp_helper.py | 9 +-\n scripts/render_block_graph.py | 10 +-\n scripts/simplebench/bench_block_job.py | 10 +-\n tests/Makefile.include | 22 +-\n tests/docker/dockerfiles/alpine.docker | 6 +-\n tests/docker/dockerfiles/centos9.docker | 242 ++--\n .../dockerfiles/fedora-rust-nightly.docker | 262 ++--\n .../dockerfiles/fedora-win64-cross.docker | 162 +--\n tests/docker/dockerfiles/fedora.docker | 262 ++--\n tests/docker/dockerfiles/opensuse-leap.docker | 1 +\n tests/functional/meson.build | 5 +-\n tests/lcitool/libvirt-ci | 2 +-\n tests/lcitool/mappings.yml | 2 +-\n tests/lcitool/projects/qemu.yml | 2 +\n tests/lcitool/refresh | 8 +-\n tests/migration-stress/guestperf/engine.py | 15 +-\n tests/vm/Makefile.include | 18 +-\n tests/vm/generated/freebsd.json | 2 +\n tests/vm/openbsd | 3 +\n 58 files changed, 996 insertions(+), 6143 deletions(-)\n delete mode 100644 python/qemu/qmp/__init__.py\n delete mode 100644 python/qemu/qmp/error.py\n delete mode 100644 python/qemu/qmp/events.py\n delete mode 100644 python/qemu/qmp/legacy.py\n delete mode 100644 python/qemu/qmp/message.py\n delete mode 100644 python/qemu/qmp/models.py\n delete mode 100644 python/qemu/qmp/protocol.py\n delete mode 100644 python/qemu/qmp/py.typed\n delete mode 100644 python/qemu/qmp/qmp_client.py\n delete mode 100644 python/qemu/qmp/qmp_shell.py\n delete mode 100644 python/qemu/qmp/qmp_tui.py\n delete mode 100644 python/qemu/qmp/util.py\n delete mode 100644 python/tests/protocol.py\n create mode 100644 python/wheels/qemu_qmp-0.0.5-py3-none-any.whl\n create mode 100644 pyvenv/meson.build" }