Cover Letter Detail
Show a cover letter.
GET /api/covers/2196049/?format=api
{ "id": 2196049, "url": "http://patchwork.ozlabs.org/api/covers/2196049/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/cover/20260212191818.3625264-1-dcostantino@meta.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260212191818.3625264-1-dcostantino@meta.com>", "list_archive_url": null, "date": "2026-02-12T19:18:16", "name": "[0/2] PCI/DPC: Fix EDR recovery path issues", "submitter": { "id": 92636, "url": "http://patchwork.ozlabs.org/api/people/92636/?format=api", "name": "Danielle Costantino", "email": "dcostantino@meta.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/cover/20260212191818.3625264-1-dcostantino@meta.com/mbox/", "series": [ { "id": 492009, "url": "http://patchwork.ozlabs.org/api/series/492009/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=492009", "date": "2026-02-12T19:18:16", "name": "PCI/DPC: Fix EDR recovery path issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/492009/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2196049/comments/", "headers": { "Return-Path": "\n <linux-pci+bounces-47223-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=meta.com header.i=@meta.com header.a=rsa-sha256\n header.s=s2048-2025-q2 header.b=Y0EnoPNN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-47223-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com\n header.b=\"Y0EnoPNN\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=67.231.153.30", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=meta.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=meta.com" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fBlTV49rCz1xpj\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 13 Feb 2026 06:18:54 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 25A77303B5C7\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 19:18:52 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EE0D9246BB2;\n\tThu, 12 Feb 2026 19:18:49 +0000 (UTC)", "from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com\n [67.231.153.30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 836D83EBF3F\n\tfor <linux-pci@vger.kernel.org>; Thu, 12 Feb 2026 19:18:48 +0000 (UTC)", "from pps.filterd (m0001303.ppops.net [127.0.0.1])\n\tby m0001303.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 61CHFmvv1995783;\n\tThu, 12 Feb 2026 11:18:41 -0800", "from mail.thefacebook.com ([163.114.134.16])\n\tby m0001303.ppops.net (PPS) with ESMTPS id 4c9dty5a0b-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT);\n\tThu, 12 Feb 2026 11:18:40 -0800 (PST)", "from devvm16459.vll0.facebook.com (2620:10d:c085:108::150d) by\n mail.thefacebook.com (2620:10d:c08b:78::c78f) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.2562.35; Thu, 12 Feb 2026 19:18:39 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770923929; cv=none;\n b=OSl8Hhk9unfDn4G3ooslm0aLmoeUajF1g7qslTWX6pBlGQ6ll4GKusBn7Ww+tyIyFB1jP2VxrJX/Spo9drbOS/DDj1cp5kNzS2g4h5h+ZsEH13KkPPgPo0MzcysSxVWhcwnWfzlXVhiXEuOnNThSOWwJs0q1YdVQQnAdl/NIrEs=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770923929; c=relaxed/simple;\n\tbh=Hdjf4Jqepm/ofIxsi+srbZQhc0+VYpktby6CEX3HXCs=;\n\th=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type;\n b=OV2vFwfGkKGbmA8X64l08vAZMgZ289ViM0FYZY5GGGoGu+m421ukPTW1/y1LACVOzlb5N0X0JljJBDWOgrdbp4R3disQ5WXMzgfJ0gXcyl8zDAA3cvJh67vvqIBSSKyFLgekau5AV0fgTotZeKJ9CBTxZWsNf4iCe8RkQ34PaAc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=meta.com;\n spf=pass smtp.mailfrom=meta.com;\n dkim=pass (2048-bit key) header.d=meta.com header.i=@meta.com\n header.b=Y0EnoPNN; arc=none smtp.client-ip=67.231.153.30", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=cc\n\t:content-transfer-encoding:content-type:date:from:message-id\n\t:mime-version:subject:to; s=s2048-2025-q2; bh=qLBmqD4RfSQ7N+Q4Wg\n\tiqyHOFEn4aGztR2U98YyUsg6M=; b=Y0EnoPNNSl+URnnuRqX8FujXyqlrD2YHOM\n\tx+tm44WLUO8/ivTGrZN8siFBUrSA+NClWnlq38eLhLU18495wirarR9ueF/VaphB\n\ttHds8moDs1wjR43fP4YbPZVZ8Iu6W209kviSrLKP++EQTnKgO0H/WWNw7EsZGHIV\n\tTtD791MmqznKFskJSSTb4fz3YFlVR1qW6ssyykTkMH6IZL+bbVeFQdBOBrcmPsU6\n\tceTUx98hIE+XK7nGGfLWjydiMk76sMMYoT6cYuuPa/g1uAq6b7Cxwh5rBiWqJszS\n\tnbwDRbjmf4NmxIBBV4A8EPGcp3frdk98i8fKhL5jIPv2TcgUq5TA==", "From": "Danielle Costantino <dcostantino@meta.com>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "CC": "Keith Busch <kbusch@kernel.org>,\n Kuppuswamy Sathyanarayanan\n\t<sathyanarayanan.kuppuswamy@linux.intel.com>,\n Lukas Wunner <lukas@wunner.de>,\n Mahesh J Salgaonkar <mahesh@linux.ibm.com>,\n Oliver O'Halloran\n\t<oohall@gmail.com>, <linux-pci@vger.kernel.org>,\n Danielle Costantino\n\t<dcostantino@meta.com>", "Subject": "[PATCH 0/2] PCI/DPC: Fix EDR recovery path issues", "Date": "Thu, 12 Feb 2026 11:18:16 -0800", "Message-ID": "<20260212191818.3625264-1-dcostantino@meta.com>", "X-Mailer": "git-send-email 2.47.3", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "e0BKfwxAnPyxWxaiNFhde2hMm1vIZ_Pv", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjEyMDE0OSBTYWx0ZWRfX0iUXk0+Fuac5\n uoU1c7YQ+S3xmz1u+0Dr6h+9TJ23Ejs5moCbpFPZAx0kaOttag54MAeVc6FfGuaJicg+9S3uK7z\n U2DRGb9C+yovECnrRCUY8/bqaz9MHF6QeD+sfLjVJB6fsMXvMNbHpEJa1rFvDoFcnv2yceBt2lG\n irHG2y7MnwH8JDhzlcco58+OMvOrvv81cmP7cCrLBhmGXc7UMiG8efTAcsOT61JU3E+fcHqe/4r\n oNpiR1Wo8larBSMyb7cuSv+GDYVBSEw6TNN5vp5UWz2y5UABmgBHYirlMAyHyAAWT9zIyyT2xoI\n dP9Lb/RjZNkjncO6X8NSbGD4Ttc/fRTULKMyxgsoINk9hMeaxxug3F/vKH/Gn/NHRSrg6q2UMCr\n lrQdFy1F/cLPw8jsNqzulV7kjn3Dc0uh/g5ZSgNMxbM6z+hkd+Zjr2asZbPmTAhyopdpi6G4XUq\n UyZd1YuVSBPrSrq7FFg==", "X-Proofpoint-ORIG-GUID": "e0BKfwxAnPyxWxaiNFhde2hMm1vIZ_Pv", "X-Authority-Analysis": "v=2.4 cv=brNBxUai c=1 sm=1 tr=0 ts=698e2790 cx=c_pps\n a=CB4LiSf2rd0gKozIdrpkBw==:117 a=CB4LiSf2rd0gKozIdrpkBw==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=JjB_qaDjHViVyrf1wj4A:9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01" }, "content": "Two fixes for the firmware-first EDR path in DPC error recovery.\n\nBoth were found investigating recurring DPC events on a platform using\nfirmware-first EDR, where each recovery left stale state in the DPC\nStatus register and cleared AER diagnostic data before driver callbacks\ncould inspect it.\n\nPatch 1 fixes DPC Interrupt Status (bit 3) never being cleared in the\nEDR path. In native DPC, dpc_irq() clears it in the top-half, but\nEDR bypasses dpc_irq() entirely. After this fix, dpc_reset_link()\nclears both Trigger Status and Interrupt Status together.\n\nPatch 2 moves pci_aer_raw_clear_status() from before pcie_do_recovery()\nto after it in edr_handle_event(), so AER registers remain readable\nthroughout the driver recovery callbacks.\n\nTested on a firmware-first EDR platform. A natural DPC event\nconfirmed:\n - DPC Status properly cleared: 0x2000 (clean) vs 0x2008 (stale, unpatched)\n - AER data available during recovery (GHES captured aer_uncor_status:\n 0x00100010 throughout recovery window)\n - Full recovery successful in ~2.3s with link re-establishment\n\nDanielle Costantino (2):\n PCI/DPC: Clear Interrupt Status in dpc_reset_link()\n PCI/EDR: Defer AER status clearing until after recovery\n\n drivers/pci/pcie/dpc.c | 10 +++++++++-\n drivers/pci/pcie/edr.c | 11 ++++++++++-\n 2 files changed, 19 insertions(+), 2 deletions(-)\n\n--\n2.47.3" }