Cover Letter Detail
Show a cover letter.
GET /api/covers/2195708/?format=api
{ "id": 2195708, "url": "http://patchwork.ozlabs.org/api/covers/2195708/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260211163318.938776-1-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260211163318.938776-1-berrange@redhat.com>", "list_archive_url": null, "date": "2026-02-11T16:33:03", "name": "[v4,00/15] tests: do more testing of block drivers", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/cover/20260211163318.938776-1-berrange@redhat.com/mbox/", "series": [ { "id": 491877, "url": "http://patchwork.ozlabs.org/api/series/491877/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491877", "date": "2026-02-11T16:33:04", "name": "tests: do more testing of block drivers", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/491877/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2195708/comments/", "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KBpS9zhz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fB3tq2GRdz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 12 Feb 2026 03:34:59 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vqD9g-0005On-8k; Wed, 11 Feb 2026 11:33:32 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1vqD9f-0005OT-7j\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 11:33:31 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1vqD9d-0003cl-CN\n for qemu-devel@nongnu.org; Wed, 11 Feb 2026 11:33:30 -0500", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-H25CIlUqMWCh9aXctnfJPg-1; Wed,\n 11 Feb 2026 11:33:25 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C926419560A3; Wed, 11 Feb 2026 16:33:23 +0000 (UTC)", "from toolbx.redhat.com (unknown [10.45.227.9])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3CD8019560A7; Wed, 11 Feb 2026 16:33:19 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770827608;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=8VTuIb/iu/VFrpnN/4uzR9CXNXuGw53PVUX5NBkfh/A=;\n b=KBpS9zhze5Jf/YRtZc+JjGrDZUTnJPEHSgpz/MrMoaX8cW9f460yCtdMzleAQidiesjIft\n npeXEF6TcI36rm7IjBFwgxC6FZDkceHOB2ZDTvKogyu7FuQm9mFKkoNVzZx87OknouEDaP\n jWEjFT5TwEqpAynfkIyIbGl6cB/Vy9Y=", "X-MC-Unique": "H25CIlUqMWCh9aXctnfJPg-1", "X-Mimecast-MFC-AGG-ID": "H25CIlUqMWCh9aXctnfJPg_1770827604", "From": "=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "Thomas Huth <thuth@redhat.com>, Hanna Reitz <hreitz@redhat.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org,\n Cleber Rosa <crosa@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Daniel_P?=\n\t=?utf-8?q?=2E_Berrang=C3=A9?= <berrange@redhat.com>", "Subject": "[PATCH v4 00/15] tests: do more testing of block drivers", "Date": "Wed, 11 Feb 2026 16:33:03 +0000", "Message-ID": "<20260211163318.938776-1-berrange@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Original (very broken) v1 posting:\n\n https://lists.nongnu.org/archive/html/qemu-devel/2025-10/msg01650.html\n\nThe recent set of regressions identified in the LUKS block driver\nre-inforced that despite having a hugely useful set of I/O tests,\nour CI coverage is still letting through too many bugs.\n\nThe core goals of this series were/are:\n\n * Add LUKS and NBD to the tested formats/protocols\n integrated into \"make check-block SPEED=thorough\"\n\n * Ensure that all qcow2 tests can be run with \"SPEED=slow\",\n not staying limited to only the 'auto' group used by the\n 'make check-block' target in its default 'quick' mode\n\n * Add 'make check-block-$FORMAT' to expose a standalone\n target for running all tests for a given format (or\n equivalently a protocol)\n\n * Add GitLab CI jobs for exercising tests for all formats\n\nA sample pipeline for this is\n\n https://gitlab.com/berrange/qemu/-/pipelines/2258731804/\n\nShowing the 'block-FORMAT-centos' jobs which test the 10\nblock formats/protocols currently enabled.\n\nThis series fixes a couple of bugs\n\n * sendmsg generates a deprecation warning on centos\n\n * Test 128 check for device mapper usage doesn't work\n sufficiently well to detect gitlab's containe env\n can't do dynamic devfs\n\n * Test 185 is reliably failing on gitlab\n\nI'm unclear if there are other non-deterministic failures that\nwould only appear if we start running the tests regularly, or\nagainst QEMU's private runners instead of gitlab shared runners.\n\nThe ones I've fixed have been consistent across quite a few test\npipelines so far with the shared runners.\n\nAt this point it is a chicken & egg problem though.\n\nIf we don't bite the bullet and enable block I/O tests in GitLab\nwe'll never find out if they're stable enough to rely on.\n\nAs a mitigation against instability a patch in this series adds\na QEMU_TEST_IO_SKIP env variable that we are able to set as a\nGitLab CI env variable. This lets us skip broken tests without\nwaiting for a git commit to disable them.\n\nChanged in v4:\n\n - Remove tests from build-tcg-disabled job\n\nChanged in v3:\n\n - Test whether dmsetup create device appeared or not, instead\n of unconditionally skipping test 128 in GitLab\n - Use 'driver' term instead of 'format' or 'protocol'\n - Fix misc typos & rephrasing\n\nDaniel P. Berrangé (15):\n Revert \"python/aqmp: fix send_fd_scm for python 3.6.x\"\n tests: print reason when I/O test is skipped in TAP mode\n tests: remove redundant meson suite for iotests\n tests: ensure all qcow2 I/O tests are able to be run via make\n scripts/mtest2make: ensure output has stable sorting\n scripts/mtest2make: support optional tests grouping\n tests: add a meson suite / make target per block I/O tests format\n docs/devel/testing: expand documentation for 'make check-block'\n tests: add nbd and luks to the I/O test suites\n tests: use 'driver' as collective term for either format or protocol\n tests: validate dmsetup result in test 128\n tests: fix check for sudo access in LUKS I/O test\n tests: add QEMU_TEST_IO_SKIP for skipping I/O tests\n gitlab: add jobs for thorough block tests\n gitlab: remove I/O tests from build-tcg-disabled job\n\n .gitlab-ci.d/buildtest.yml | 101 ++++++++++++++++++++++++++++---\n docs/devel/testing/main.rst | 33 +++++++++-\n python/qemu/qmp/qmp_client.py | 9 +--\n scripts/mtest2make.py | 30 ++++++---\n tests/Makefile.include | 3 +-\n tests/qemu-iotests/128 | 6 ++\n tests/qemu-iotests/149 | 13 ++--\n tests/qemu-iotests/meson.build | 59 +++++++++++++++---\n tests/qemu-iotests/testrunner.py | 18 +++++-\n 9 files changed, 229 insertions(+), 43 deletions(-)" }