Cover Letter Detail
Show a cover letter.
GET /api/covers/2194874/?format=api
{ "id": 2194874, "url": "http://patchwork.ozlabs.org/api/covers/2194874/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/cover/20260210051435.89732-1-dongdong.tao@canonical.com/", "project": { "id": 15, "url": "http://patchwork.ozlabs.org/api/projects/15/?format=api", "name": "Ubuntu Kernel", "link_name": "ubuntu-kernel", "list_id": "kernel-team.lists.ubuntu.com", "list_email": "kernel-team@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260210051435.89732-1-dongdong.tao@canonical.com>", "list_archive_url": null, "date": "2026-02-10T05:14:34", "name": "[SRU,J/N/Q/R:Unstable,0/1] efi: Fix swapped bsearch arguments in SAUCE patch", "submitter": { "id": 81434, "url": "http://patchwork.ozlabs.org/api/people/81434/?format=api", "name": "Dongdong Tao", "email": "dongdong.tao@canonical.com" }, "mbox": "http://patchwork.ozlabs.org/project/ubuntu-kernel/cover/20260210051435.89732-1-dongdong.tao@canonical.com/mbox/", "series": [ { "id": 491603, "url": "http://patchwork.ozlabs.org/api/series/491603/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=491603", "date": "2026-02-10T05:14:34", "name": "efi: Fix swapped bsearch arguments in SAUCE patch", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491603/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2194874/comments/", "headers": { "Return-Path": "<kernel-team-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=G+FWzsu9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com\n (client-ip=185.125.189.65; helo=lists.ubuntu.com;\n envelope-from=kernel-team-bounces@lists.ubuntu.com;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f98rd0HM5z1xwH\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 10 Feb 2026 16:14:56 +1100 (AEDT)", "from localhost ([127.0.0.1] helo=lists.ubuntu.com)\n\tby lists.ubuntu.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1vpg5C-0003dg-7x; Tue, 10 Feb 2026 05:14:42 +0000", "from smtp-relay-internal-0.internal ([10.131.114.225]\n helo=smtp-relay-internal-0.canonical.com)\n by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.86_2) (envelope-from <dongdong.tao@canonical.com>)\n id 1vpg5B-0003dT-2F\n for kernel-team@lists.ubuntu.com; Tue, 10 Feb 2026 05:14:41 +0000", "from mail-pj1-f72.google.com (mail-pj1-f72.google.com\n [209.85.216.72])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id D3E8F3F1C0\n for <kernel-team@lists.ubuntu.com>; Tue, 10 Feb 2026 05:14:40 +0000 (UTC)", "by mail-pj1-f72.google.com with SMTP id\n 98e67ed59e1d1-35301003062so10374175a91.2\n for <kernel-team@lists.ubuntu.com>; Mon, 09 Feb 2026 21:14:40 -0800 (PST)", "from localhost.localdomain\n ([2404:2d00:54fd:451:f589:bf87:3409:6337])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35662e50d4asm1140166a91.3.2026.02.09.21.14.37\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 09 Feb 2026 21:14:37 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1770700480;\n bh=XdkCLgs51iwWYZ6ZPQJMBmsa92J+MJDMNkk/OyxrghM=;\n h=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=G+FWzsu9QZmHBI3lAbJmKA5SSTkAarPvdNdrwDFTSZiHHfGfk14yBmxXfDkrS8+Ij\n MscvmiBVp6vp4LtFao8MTu5tAAsEiv+tpy1MqiNsJbC0Hd2ivUx22uFvrbOsEwgOFf\n edZOyHIeKLQE3ZPhXvmcXi3Yhw2Pdw76GupTdwpssiEJSa0KoNF9wBofVGG0regofC\n 8RVQC56GGWLOF/X85fsclmJQkqDPz2DJh44+kosu4mdpsfUlN3+QZyqA0Sf7BoDWV/\n APbD1kkTxldjGkm3Ci6cTEGKlnJ/oMntWeUuBrjpv5cCKst9yPhXBQmN3aZYMZKs5V\n 76+FuWZ4nXCLUENHb6EJDnEjjX+QOkyVGfWy8dO8CSarZSmlHb3PoznP49d6VJu1aO\n 5BCgOdCGyBMGKRlYA/b7QWaahPkuiG65aKpWdpNj/sKHqqgoMFAWwO0KLdXtbSVOOe\n eYj7Sg673e7FY+MmKiYfYnv/o0O3utqYu/DZaYTSkBgz32TYCaxqEC1qfMvr7PqRs3\n I1gvGE2AbiWjMxgxzHeKLV5YQNuMme1y1elJ7lBcdUv0HYiD8BwrBkNCzsoO7a1gqs\n YHFTNZ6IVZln2VuiJ27+Pkn/a7bNbTk9o05TPrzhBWnSSn7jhIpnKd1xwvfvWXshaS\n It1LLBHaOfMthXjwx3Oq1ClY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770700479; x=1771305279;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XdkCLgs51iwWYZ6ZPQJMBmsa92J+MJDMNkk/OyxrghM=;\n b=ic5F64wcs/9c2tXS1517VUbuxRnIZi60f8NEh6jsbUOS0mX5gaKiDHnWlJu97cp6UZ\n PcXqXmE9TI5aV7ty0Be/Re589UtTNHPZHdv9DD2Cam2wdkRoODsYUxibz7gUDoZmSxFL\n r9PhGnfYd0xl55tBf/UzwLSCI6oTaIZNu2gFVR4sWQIigLgQbd9KYVjOO7g1mEEUoqbP\n 9eZ70sFSWVR9XDR6H2C8b3aKUHk0Moh2EAGoDX/qFuDMm7uamC5IbTN0nXc4TODKzTta\n PaYi/SAxZVUKThz7NPk9N0w8eNU0acNP0VnX/XYQo4iDZe2xPL7SpR0jOmJVZaB3+XJx\n S5BA==", "X-Gm-Message-State": "AOJu0YzkeyHD9cNAhq8x+N4MIiteHXePicCa2K6OfFXiy1C8uZwFFPOt\n yCZMWucutr7M0aoZXu+4ew+02cTCO9HyLfoF2AQJyDFU5ZQZW9PLilt755m2ayABvc0yPk0ZJVU\n sfPG0Lyxs0qhvedlYDNvlLjeG+z0NhycFG1I+dn0jA7tDvCbCoAcIRgLiWX3UHdUAxkujVOGYAH\n 3feQPpYhu4ex66yw==", "X-Gm-Gg": "AZuq6aJt5EY51A/Zhmm+lobRFfJ8uC22ZUTvZPxTpL3Nrpwo774b3BzqlKZ4wYH8Md7\n DhZQTQuIlt+v+dhePSu5c+GZVCDow1hjPdA1vCTt39n9HoogjI8B7LB6UMzJUTFGeAJkyE+PwiO\n ZOECpf8M322Ypmjs/lq0VviqQyO3qqwem8bLWQGIMfBDeh+Ly5//D/+AZlXfnimc1Ip854iYTcN\n OR+FB+y5qiTgSef37OxN9TPLRNcbvm75lqtqIF2KSNlXu73C6ohnZAAE3yNDP/NtQ8/mBaRf1Ee\n syTivDhRAzPt8ZTgZnBoBHlhmDYX+sYP/qe8DjcGHr7QrvAJglmTLLHC39H3Mjw4qTD3Pn+1wBl\n mxCUWZMnzh64gYrGwT4EPoSWSDzzbHjfcw+Wh0vRCY+1RGvquW0prCccNW0/FPto=", "X-Received": [ "by 2002:a17:90b:5744:b0:343:f509:aa4a with SMTP id\n 98e67ed59e1d1-354b3e8cb8dmr12316727a91.36.1770700478880;\n Mon, 09 Feb 2026 21:14:38 -0800 (PST)", "by 2002:a17:90b:5744:b0:343:f509:aa4a with SMTP id\n 98e67ed59e1d1-354b3e8cb8dmr12316700a91.36.1770700478479;\n Mon, 09 Feb 2026 21:14:38 -0800 (PST)" ], "From": "Dongdong Tao <dongdong.tao@canonical.com>", "To": "kernel-team@lists.ubuntu.com", "Subject": "[SRU][J/N/Q/R:Unstable][PATCH 0/1] efi: Fix swapped bsearch arguments\n in SAUCE patch", "Date": "Tue, 10 Feb 2026 14:14:34 +0900", "Message-Id": "<20260210051435.89732-1-dongdong.tao@canonical.com>", "X-Mailer": "git-send-email 2.39.5 (Apple Git-154)", "MIME-Version": "1.0", "X-BeenThere": "kernel-team@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Kernel team discussions <kernel-team.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/kernel-team>", "List-Post": "<mailto:kernel-team@lists.ubuntu.com>", "List-Help": "<mailto:kernel-team-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "kernel-team-bounces@lists.ubuntu.com", "Sender": "\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>" }, "content": "BugLink: https://bugs.launchpad.net/bugs/2141276\n\n== SRU Justification ==\n\n[Impact]\nThe SAUCE patch \"UBUNTU: SAUCE: (lockdown) Add efi_status_to_str() and\nrework efi_status_to_err()\" contains a bug where the 3rd and 4th arguments\nto bsearch() are swapped.\n\nThe bsearch() signature is:\n void *bsearch(key, base, nmemb, size, compar)\n\nCurrent code passes: (sizeof(struct efi_error_code), num) -- WRONG\nShould be: (num, sizeof(struct efi_error_code)) -- CORRECT\n\nThis causes bsearch to calculate incorrect element offsets:\n- Buggy: thinks 24 elements of 12 bytes each\n- Correct: should be 12 elements of 24 bytes each\n\nThis may cause efi_status_to_err() and efi_status_to_str() to return\nincorrect error codes or fail to find valid status codes.\n\n[Test Plan]\n1. Boot system with EFI firmware\n2. Trigger EFI error conditions (e.g., secure boot violations)\n3. Verify correct error messages are displayed\n4. Check dmesg for proper EFI status code translations\n\n[Where problems could occur]\nThe fix is a straightforward argument swap with no functional changes.\nRisk is minimal as this corrects the code to match the documented\nbsearch() API.\n\n[Other]\nThis fix has been merged upstream in kernel-ark:\nhttps://gitlab.com/cki-project/kernel-ark/-/commit/49bcc48074ba\n\nDongdong Tao (1):\n UBUNTU: SAUCE: efi: Fix swapped arguments to bsearch() in\n efi_status_to_*()\n\n drivers/firmware/efi/efi.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.39.5" }