Cover Letter Detail
Show a cover letter.
GET /api/covers/2192313/?format=api
{ "id": 2192313, "url": "http://patchwork.ozlabs.org/api/covers/2192313/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260203125417.37285-5-takkozu@amazon.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260203125417.37285-5-takkozu@amazon.com>", "list_archive_url": null, "date": "2026-02-03T12:54:10", "name": "[iwl-next,v6,0/3] igb: add RSS key get/set support", "submitter": { "id": 92211, "url": "http://patchwork.ozlabs.org/api/people/92211/?format=api", "name": "Takashi Kozu", "email": "takkozu@amazon.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/cover/20260203125417.37285-5-takkozu@amazon.com/mbox/", "series": [ { "id": 490796, "url": "http://patchwork.ozlabs.org/api/series/490796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=490796", "date": "2026-02-03T12:54:10", "name": "igb: add RSS key get/set support", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/490796/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2192313/comments/", "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=4m9yPms2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f53NM0rCNz1xpg\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 03 Feb 2026 23:54:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 109EE80AFE;\n\tTue, 3 Feb 2026 12:54:41 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iUvsfLjU5UJI; Tue, 3 Feb 2026 12:54:39 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2C90980AED;\n\tTue, 3 Feb 2026 12:54:39 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id E939CF4\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Feb 2026 12:54:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id CE08640248\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Feb 2026 12:54:37 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ovs5SAK5KnYY for <intel-wired-lan@lists.osuosl.org>;\n Tue, 3 Feb 2026 12:54:36 +0000 (UTC)", "from pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com\n (pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com\n [44.245.243.92])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 53FD440060\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Feb 2026 12:54:35 +0000 (UTC)", "from ip-10-5-6-203.us-west-2.compute.internal (HELO\n smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203])\n by internal-pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 12:54:34 +0000", "from EX19MTAUWA002.ant.amazon.com [205.251.233.234:16885]\n by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.31.67:2525]\n with esmtp (Farcaster)\n id 8566367f-1b4f-41de-98ea-1ed2801adaaf; Tue, 3 Feb 2026 12:54:34 +0000 (UTC)", "from EX19D001UWA001.ant.amazon.com (10.13.138.214) by\n EX19MTAUWA002.ant.amazon.com (10.250.64.202) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Tue, 3 Feb 2026 12:54:33 +0000", "from 603e5f7bc1fe.amazon.com (10.37.245.7) by\n EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Tue, 3 Feb 2026 12:54:31 +0000" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2C90980AED", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 53FD440060" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770123279;\n\tbh=OXp+EGxucYPxD48JSNx0qV+Yw8ErjHN/lXwrb+uzKyk=;\n\th=From:To:CC:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=4m9yPms2lQT47fDgjsW9zLlzPQOkTr5MdFKTJKojZGY4jaDr1UekHEyFe6Bh56mtD\n\t 4GVaxm0t+fzkzZONewXGrBu+DK7LBS69zAJnJFoUBisPdg4BYEYbRXyDQXKEseyqye\n\t QxwyzQ7Cf7eUQWPElurzJxBXdPEhhnxvjoBn8QTeozRiDNQiVfREiKjZR+wQeWjDqM\n\t cWYdJ5foW4kMIB/xAmEr1r/4tU74diERoG24j9M3C+5b4xBHPk7/NNulPsb8d7cMtE\n\t JiNQdVoQ9dHyXmNqpEyREEqq9gVtMoqcQKo9ogv7i7evpxcZxxY3Y4NGIETAxojYKu\n\t 0DiphNfcF04Dg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=44.245.243.92;\n helo=pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com;\n envelope-from=prvs=487b0b5b4=takkozu@amazon.co.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 53FD440060", "X-CSE-ConnectionGUID": "LCyvKWRqTWqhscHaIuLiVQ==", "X-CSE-MsgGUID": "+1eosR/KRcquiZCc2Q8WTg==", "X-IronPort-AV": "E=Sophos;i=\"6.21,270,1763424000\"; d=\"scan'208\";a=\"11723383\"", "X-Farcaster-Flow-ID": "8566367f-1b4f-41de-98ea-1ed2801adaaf", "From": "Takashi Kozu <takkozu@amazon.com>", "To": "<horms@kernel.org>", "CC": "<anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>,\n <andrew+netdev@lunn.ch>, <davem@davemloft.net>, <edumazet@google.com>,\n <kuba@kernel.org>, <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,\n <netdev@vger.kernel.org>, <aleksandr.loktionov@intel.com>,\n <pmenzel@molgen.mpg.de>, <piotr.kwapulinski@intel.com>, <enjuk@amazon.com>,\n Takashi Kozu <takkozu@amazon.com>", "Date": "Tue, 3 Feb 2026 21:54:10 +0900", "Message-ID": "<20260203125417.37285-5-takkozu@amazon.com>", "X-Mailer": "git-send-email 2.47.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[10.37.245.7]", "X-ClientProxiedBy": "EX19D037UWC003.ant.amazon.com (10.13.139.231) To\n EX19D001UWA001.ant.amazon.com (10.13.138.214)", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2;\n t=1770123276; x=1801659276;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=OXp+EGxucYPxD48JSNx0qV+Yw8ErjHN/lXwrb+uzKyk=;\n b=LWz7ndKj5lniEpXyVFiS0E9tnr9r6XUs0RTCvcQSmQirJaPwkrkC22D0\n 49dR1rbcC2gNY84mY0maQyjCe/X2n9FOgCcFNZp+tObK3EyQ3vamXRM0S\n d4PL1SWqV7ENcXl0123M5KDJGsle6ewzvLk2bpb2kxqlTTqsvwB427JxN\n o/DFVjyU4bYT4P5D3f8sIYTIK08XnbWdk2FoLhaF9mP7H8xnBRuImnRPy\n dDBDMPD78mZuwtrkdwAvC48nsC3wxReMsqRip8Gg4jpEVERFDj0btFEYR\n v+d5Fwi4/ppDB2dTjHcE/JryfEUYlzajvVR3KeBrCxQRFxGbYJADYP3cF\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=amazon.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256\n header.s=amazoncorp2 header.b=LWz7ndKj" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v6 0/3] igb: add RSS key get/set\n support", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This series adds ethtool get/set support for the RSS hash key in the igb\ndriver.\n- `ethtool -x <dev>` to display the RSS key\n- `ethtool -X <dev> hkey <key>` to configure the RSS key\n\nWithout patch:\n\n# ethtool -x $DEV | grep key -A1\nRSS hash key:\nOperation not supported\n# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:00:00:00:000\nCannot set RX flow hash configuration:\n Hash key setting not supported\n\n\nWith patch:\n\n# ethtool -x $DEV | grep key -A1\nRSS hash key:\n86:5d:11:56:bd:6f:20:38:3b:f8:bb:df:00:3a:b0:24:95:9f:f9:f4:25:a3:01:3e:4a:15:d6:7c:4d:af:39:7e:4a:95:f2:fd:f6:b6:26:f7\n\n# ethtool -X $DEV hkey 00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00\n# ethtool -x $DEV | grep key -A1\nRSS hash key:\n00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00\n\n<Changelog>\n v6:\n - fix a typo in the 3/3 commit message. (igc_set_rxfh() → igb_set_rxfh())\n\n v5:\n - delete 'has_user_rss_key' flag because it's unnecessary. \n\n v4: \n - modify the position of the declaration in the igb_write_rss_key() so that it is at the start of the block.\n\n v3: \n - add ASSERT_RTNL() to explicitly show that an rtnl lock is being used\n - Move netdev_rss_key_fill() function from igb_setup_mrqc() to igb_sw_init()\n - Add kernel-doc header to igb_write_rss_key()\n\n <Test>\n - tools/testing/selftests/drivers/net/hw/rss_api.py is successful\n Run the following command\n\n # NETIF=enp0s3 python tools/testing/selftests/drivers/net/hw/rss_api.py | grep -v \"# Exception\" \n\n Then, I checked the diffs before and after applying the patch\n\n $ diff beforePatch.txt afterPatch.txt \n 9c9\n < not ok 6 rss_api.test_rxfh_nl_set_key\n ---\n > ok 6 rss_api.test_rxfh_nl_set_key\n 16c16\n < # Totals: pass:4 fail:8 xfail:0 xpass:0 skip:0 error:0\n ---\n > # Totals: pass:5 fail:7 xfail:0 xpass:0 skip:0 error:0\n\n The failing tests originally fails due to hardware.\n\n - tools/testing/selftests/drivers/net/hw/toeplitz.py is untested since there is no actual hardware, but since the logic around wr32() is preserved as it is, key writing to the device remain the same.\n \n\n v2: Fix typos (igc_* → igb_*) \n https://lore.kernel.org/intel-wired-lan/20260108052020.84218-5-takkozu@amazon.com/T/\n\n v1: https://lore.kernel.org/all/20251205082106.4028-5-takkozu@amazon.com/\n\n\nTakashi Kozu (3):\n igb: prepare for RSS key get/set support\n igb: expose RSS key via ethtool get_rxfh\n igb: allow configuring RSS key via ethtool set_rxfh\n\n drivers/net/ethernet/intel/igb/igb.h | 3 +\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 85 ++++++++++++++------\n drivers/net/ethernet/intel/igb/igb_main.c | 8 +-\n 3 files changed, 66 insertions(+), 30 deletions(-)" }