Cover Letter Detail
Show a cover letter.
GET /api/covers/2174164/?format=api
{ "id": 2174164, "url": "http://patchwork.ozlabs.org/api/covers/2174164/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/cover/20251215-macsmc-subdevs-v6-0-0518cb5f28ae@gmail.com/", "project": { "id": 9, "url": "http://patchwork.ozlabs.org/api/projects/9/?format=api", "name": "Linux RTC development", "link_name": "rtc-linux", "list_id": "linux-rtc.vger.kernel.org", "list_email": "linux-rtc@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251215-macsmc-subdevs-v6-0-0518cb5f28ae@gmail.com>", "list_archive_url": null, "date": "2025-12-15T09:37:44", "name": "[v6,0/7] mfd: macsmc: add rtc, hwmon and hid subdevices", "submitter": { "id": 89516, "url": "http://patchwork.ozlabs.org/api/people/89516/?format=api", "name": "James Calligeros", "email": "jcalligeros99@gmail.com" }, "mbox": "http://patchwork.ozlabs.org/project/rtc-linux/cover/20251215-macsmc-subdevs-v6-0-0518cb5f28ae@gmail.com/mbox/", "series": [ { "id": 485366, "url": "http://patchwork.ozlabs.org/api/series/485366/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/list/?series=485366", "date": "2025-12-15T09:37:44", "name": "mfd: macsmc: add rtc, hwmon and hid subdevices", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/485366/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2174164/comments/", "headers": { "Return-Path": "\n <linux-rtc+bounces-5539-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-rtc@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=WkBuMQaV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-rtc+bounces-5539-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"WkBuMQaV\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.182", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dVFP15PDrz1xyL\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 15 Dec 2025 20:38:29 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id D3538300E0CC\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 15 Dec 2025 09:38:25 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BE149314D1D;\n\tMon, 15 Dec 2025 09:38:23 +0000 (UTC)", "from mail-pl1-f182.google.com (mail-pl1-f182.google.com\n [209.85.214.182])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C486314B77\n\tfor <linux-rtc@vger.kernel.org>; Mon, 15 Dec 2025 09:38:20 +0000 (UTC)", "by mail-pl1-f182.google.com with SMTP id\n d9443c01a7336-2a110548cdeso3931645ad.0\n for <linux-rtc@vger.kernel.org>; Mon, 15 Dec 2025 01:38:20 -0800 (PST)", "from [192.168.2.3]\n (2403-580a-80ed-0-4835-5a07-49e7-f115.ip6.aussiebb.net.\n [2403:580a:80ed:0:4835:5a07:49e7:f115])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-29efd74f5e1sm113017705ad.16.2025.12.15.01.38.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 15 Dec 2025 01:38:19 -0800 (PST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1765791503; cv=none;\n b=arZ3d+bQkZDR6nQdxLiojFuGohICkPu9FUki/KpRy4ib7ypieoIOdP5BWhyqAiK3FeBiKc5levoojdWR/aJgpX0Xsq2lYug97ORYF4lN6p3+RxAH+jCDZcWRMO/orwi2tVB+qqzgozY1zD+8wEGbz/C+tCwtAv1qYFEhecPf3ZU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1765791503; c=relaxed/simple;\n\tbh=LpUT1tST1uzwN8B4qY2fL3L3g40kh3NGJb9E7/IhWWo=;\n\th=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc;\n b=RRS3qobgNp7vrj7MHNJU0XqwzmstALH5qH3HmBRqCyvcE6FSFoaALqZ18Jo+E3baHBXjn4AZG71fKuY6rouRxECyg7yD4IMbnpK046PxCLKdgPi2cCxnvx5wlSeLjx7fXakRDBgxWHrOE506da+7SnR3U2jaQle/8VWYQ5gLtcs=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=WkBuMQaV; arc=none smtp.client-ip=209.85.214.182", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1765791500; x=1766396300;\n darn=vger.kernel.org;\n h=cc:to:content-transfer-encoding:mime-version:message-id:date\n :subject:from:from:to:cc:subject:date:message-id:reply-to;\n bh=A2ofUMV8vPgmaOuh+YZV7CVgRP8TEUPgjBpp5OjiYrM=;\n b=WkBuMQaVNm3w2IFMdDpuPihJ4CviWsphhMGLfaRffcQIW8utplyzsq+avhCViEEmsn\n OWFUs9ozb3ExlRtcyHLjJD5rXSTGfuVQlB1UfnBEXwacX5gPP82gJjXE2jH/mpzpf3JC\n 0bEroh1HMKHYBWY0x9ykuQyPJZRAFJK5pb5Y1H7tSgWBG3nYTgl94tZqfd/B/8gbtQ+V\n igubWP3/oQ3uyKUUnEkju6vQNeIu4AOjozOdJx+4faUbiyqjTscSZO4TVIS8f3Y/5Zv5\n R4dZXR/yMsDUx2Ma8e/Y81uLbDZQf5mahaiASn83YnCGfWLInyJk/ZUpvakerrdO6ieX\n aeaw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765791500; x=1766396300;\n h=cc:to:content-transfer-encoding:mime-version:message-id:date\n :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=A2ofUMV8vPgmaOuh+YZV7CVgRP8TEUPgjBpp5OjiYrM=;\n b=TSV+DqUU60I476ADA6jdP+X0NkCR/KcyycQMk6kQ1q/GQlfO2Q0R0jhDe9x/lYEcf8\n 7CKAv4MuAjJFM3tBI5jGm//3gJmRP3BybLyi4vppIX6eyD+MLqEwEeVpy8xRLEpzRhHJ\n G2DTth6pN2eXiL59VOZQQQ/zWn5RxGQhJD8UEpEkdqG0CzkQ2UOwYRdtYlQKV4Kcjz6e\n /8kheEm06kyY38hdGSQjjeXOM4WpfMpB+EKzMSaCH2quElmGM6YgJTltnM7pqx+O8p4K\n ZwrjuPGZvr9du6xuzV2cbBBeZHiTqDlzV011N/RmDtbaDx4HhurNbFM2EFZbY1vXNj/b\n knCQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCW7Yk6b4GgXzs2KmIM0TAbSMF2a1U9yf69BACi0e5lHBA/kwB7/bLifGXa3puby2fvDub1Vz1702CI=@vger.kernel.org", "X-Gm-Message-State": "AOJu0Yxqf04hXk6o48iyBO3s+QQWEk33auClJFNRvWZIMcTV5ALjk8dD\n\tQ/b/Qk+CxlYjydB9gGZT9uCGmZupfAam19DGKfzMzOQeApcd2F9GdTy5", "X-Gm-Gg": "AY/fxX4jhtOvyTIzsiRI1F6DvmZ5pQ0lC0LX1AzvjRIkfXLCvuLwDI9lD9WvFxtM/VQ\n\tHjeLu6H/BAvNSEMsDjRieI1HWo4UuTWaW2HFOZyzpwGUCw6HWDhocPyugFT+7Gd99xPbTCv9DXX\n\tsFjdpAhCEWujuMhhVPV4W+10fT87W9hlEwOBFCHuLal3Dckr5UisggI6TWFTkc4Mo393ZqmBj09\n\t07cNHHkjuA5S01lEuu0xQkYOR5lWzoyb7wLO/2qaWSKu/fbpcuYoPkAGDEFu9AlTU+cgiiSsg1v\n\teGd35o9avWnQ/TQ29We8nW1pntl1ZIK+W8j2B5G35+xUILvwCjdWGomxEz3EJ1L8hZCU6AT3g7m\n\tNSbLE9WtzdF/FaZ5WVm4fSE58qf/pYOPj4dhy4lbCd2sPuX/5AH0LokETnI5B0+H+5pIfxWpOrS\n\tMnCATZKwzyQcKficQmA+BjT1n7P9uLFWUCdHUy192P0E7j5pJCExmf+MyPMYQcw8vU/e43w0phO\n\tlpxcB2284o1S/GGp7k8NseYFbLrnOrpelV/oDb6NwFeulcZbu4TWHs3lEpwbYQjwIpPM2B+bygI\n\t8dqbPLDzdZ5f2FNeTzB0NebnSzyXOZApkKzqR+4G3xn/H1Q00Yg=", "X-Google-Smtp-Source": "\n AGHT+IGE3gq1ZgxyZw713bIINxNwXEl9ah/Lp4tSBM1uH035Fhp+NAhTmMOItSGS6fepfB6QrYDu/A==", "X-Received": "by 2002:a17:903:19c8:b0:2a0:906c:5caf with SMTP id\n d9443c01a7336-2a0906c6125mr74500505ad.17.1765791499706;\n Mon, 15 Dec 2025 01:38:19 -0800 (PST)", "From": "James Calligeros <jcalligeros99@gmail.com>", "Subject": "[PATCH v6 0/7] mfd: macsmc: add rtc, hwmon and hid subdevices", "Date": "Mon, 15 Dec 2025 19:37:44 +1000", "Message-Id": "<20251215-macsmc-subdevs-v6-0-0518cb5f28ae@gmail.com>", "Precedence": "bulk", "X-Mailing-List": "linux-rtc@vger.kernel.org", "List-Id": "<linux-rtc.vger.kernel.org>", "List-Subscribe": "<mailto:linux-rtc+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-rtc+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-B4-Tracking": "v=1; b=H4sIAOjWP2kC/2XMQW7DIBCF4atErEs1M4AxXfUeURcYhgSpjivTo\n FaR714Sqa1lL9+Tvv8mCs+Zi3g53MTMNZc8Xdrong4inP3lxDLHtgUBGeixk6MPZQyyXIfItcj\n egqIAaCME0dDHzCl/PYLHt7bPuXxO8/ejX/H+/qbcNlVRgjQ2pi4oNgnd62n0+f05TKO4pyqtO\n Nkdp8YDG3YuGh2o33L1xxFgz1Xj0UY1pGg9A225XnEyO64bV1ZHExwPHnjLzT9HpB03jVvqWQ8\n OE/e45suy/AAFQXzSqAEAAA==", "X-Change-ID": "20250816-macsmc-subdevs-87032c017d0c", "To": "Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,\n Alyssa Rosenzweig <alyssa@rosenzweig.io>, Neal Gompa <neal@gompa.dev>,\n Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,\n Krzysztof Kozlowski <krzk+dt@kernel.org>,\n Conor Dooley <conor+dt@kernel.org>,\n Alexandre Belloni <alexandre.belloni@bootlin.com>,\n Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,\n Dmitry Torokhov <dmitry.torokhov@gmail.com>,\n Jonathan Corbet <corbet@lwn.net>,\n James Calligeros <jcalligeros99@gmail.com>", "Cc": "asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,\n devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-rtc@vger.kernel.org, linux-hwmon@vger.kernel.org,\n linux-input@vger.kernel.org, linux-doc@vger.kernel.org,\n Hector Martin <marcan@marcan.st>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=6798;\n i=jcalligeros99@gmail.com; h=from:subject:message-id;\n bh=LpUT1tST1uzwN8B4qY2fL3L3g40kh3NGJb9E7/IhWWo=;\n b=owGbwMvMwCV2xczoYuD3ygTG02pJDJn21/4fePXRd+6nrcW5vKI302y0pikzlru+kH3HvytCo\n fmZYPnyjoksDGJcDJZiiiwbmoQ8Zhux3ewXqdwLM4eVCWSItEgDAxCwMPDlJuaVGukY6ZlqG+oZ\n GuoY6xgxcHEKwFR7ajH8s3quunnFa2uOfSd6L0zwelt5/9nyrN63qRPEs2tjNjp8TWNkmN+WJnz\n yVdkGuzIzjo630/fd+rZPtCeC86b6tA9J0lNvsgMA", "X-Developer-Key": "i=jcalligeros99@gmail.com; a=openpgp;\n fpr=B08212489B3206D98F1479BDD43632D151F77960" }, "content": "Hi all,\n\nThis series adds support for the remaining SMC subdevices. These are the\nRTC, hwmon, and HID devices. They are being submitted together as the RTC\nand hwmon drivers both require changes to the SMC DT schema.\n\nThe RTC driver is responsible for getting and setting the system clock,\nand requires an NVMEM cell. This series replaces Sven's original RTC driver\nsubmission [1].\n\nThe hwmon function is an interesting one. While each Apple Silicon device\nexposes pretty similar sets of sensors, these all seem to be paired to\ndifferent SMC keys in the firmware interface. This is true even when the\nsensors are on the SoC. For example, an M1 MacBook Pro will use different\nkeys to access the LITTLE core temperature sensors to an M1 Mac mini. This\nnecessitates describing which keys correspond to which sensors for each\ndevice individually, and populating the hwmon structs at runtime. We do\nthis with a node in the device tree. This series includes only the keys\nfor sensors which we know to be common to all devices. The SMC is also\nresponsible for monitoring and controlling fan speeds on systems with fans,\nwhich we expose via the hwmon driver.\n\nThe SMC also handles the hardware power button and lid switch. Power\nbutton presses and lid opening/closing are emitted as HID events, so we\nadd an input subdevice to handle them.\n\nSince there are no real dependencies between the components of this series,\nit should be fine for each subsystem to take the relevant patches through\ntheir trees. The mfd one-liners should be taken in order to avoid trivial\nconflicts.\n\nRegards,\n\nJames\n\n[1] https://lore.kernel.org/asahi/CAEg-Je84XxLWH7vznQmPRfjf6GxWOu75ZetwN7AdseAwfMLLrQ@mail.gmail.com/T/#t\n[2] https://lore.kernel.org/asahi/20251106140050.GQ8064@google.com/\n\n---\nChanges in v6:\n- Rebase onto 6.19-rc1, dropping already merged commits\n- Link to v5: https://lore.kernel.org/r/20251112-macsmc-subdevs-v5-0-728e4b91fe81@gmail.com\n\nChanges in v5:\n- Drop inadvertent mfd core includes in rtc and input drivers\n- Link to v4: https://lore.kernel.org/r/20251025-macsmc-subdevs-v4-0-374d5c9eba0e@gmail.com\n\nChanges in v4:\n- Added Rob's R-b to hwmon Devicetree schema\n- Added missing include to hwmon driver\n- Dropped superfluous dev_info() from hwmon probe\n- Added Guenter's A-b to hwmon driver\n- Renamed INPUT_MACSMC_INPUT to INPUT_MACSMC\n- Dropped leftover mention of HID in input driver\n- Reinstated input driver MODULE_ALIAS\n- Trigger a hard wakeup on power button/lid switch when coming out of\n s2idle\n- Suppress KEY_POWER event on wakeup to prevent an immediate shutdown\n when waking up\n- Squashed hwmon Devicetree commits into one\n- Link to v3: https://lore.kernel.org/r/20251007-macsmc-subdevs-v3-0-d7d3bfd7ae02@gmail.com\n\nChanges in v3:\n- Renamed macsmc-hid to macsmc-input\n- Switched to pm_wakeup_event in macsmc-input\n- macsmc-input now configures its capabilities before registering the device\n- Renamed macsmc_hwmon to macsmc-hwmon\n- Dropped module aliases in macsmc-input and macsmc_hwmon\n- Introduced new SMC FourCC macro to silence GCC errors\n- Condensed hwmon binding using $defs\n- Made label property optional for hwmon sensors\n- Fixed incorrect hwmon is_visible implementation\n- Dropped 64-bit math from SMC float ops\n- Fixed incorrect use of error numbers in hwmon driver\n- Replaced a number of non-fatal dev_errs with dev_dbgs in hwmon driver\n- Added hwmon driver documentation\n- Added hwmon subdevice directly to the DT SMC node\n- Included \"common\" hwmon sensors in SoC .dtsi files\n- Fixed typo in hwmon-common.dtsi\n- Added Neal's R-b to series\n- Added required nodes to t602x Devicetrees\n- Link to v2: https://lore.kernel.org/r/20250827-macsmc-subdevs-v2-0-ce5e99d54c28@gmail.com\n\nChanges in v2:\n- Added Rob's R-b tag to RTC DT binding\n- Removed redundant nesting from hwmon DT binding\n- Dedpulicated property definitions in hwmon DT schema\n- Made label a required property for hwmon DT nodes\n- Clarified semantics in hwmon DT schema definitions\n- Split mfd tree changes into separate commits\n- Fixed numerous style errors in hwmon driver\n- Removed log messages sysfs read/write functions in hwmon driver\n- Removed ignored errors from hwmon driver\n- Removed uses of dev_err for non-errors in hwmon driver\n- Made it more obvious that a number of hwmon fan properties are optional\n- Modified hwmon driver to reflect DT schema changes\n- Added compatible property to hwmon node\n- Link to v1: https://lore.kernel.org/r/20250819-macsmc-subdevs-v1-0-57df6c3e5f19@gmail.com\n\n---\nHector Martin (1):\n input: macsmc-input: New driver to handle the Apple Mac SMC buttons/lid\n\nJames Calligeros (5):\n dt-bindings: hwmon: Add Apple System Management Controller hwmon schema\n mfd: macsmc: Wire up Apple SMC RTC subdevice\n mfd: macsmc: Wire up Apple SMC hwmon subdevice\n mfd: macsmc: Wire up Apple SMC input subdevice\n arm64: dts: apple: t8103, t8112, t60xx: Add hwmon SMC subdevice\n\nSven Peter (1):\n arm64: dts: apple: t8103,t60xx,t8112: Add SMC RTC node\n\n .../bindings/hwmon/apple,smc-hwmon.yaml | 86 ++++++++++\n .../bindings/mfd/apple,smc.yaml | 36 +++++\n MAINTAINERS | 2 +\n .../boot/dts/apple/hwmon-common.dtsi | 33 ++++\n .../boot/dts/apple/hwmon-fan-dual.dtsi | 22 +++\n arch/arm64/boot/dts/apple/hwmon-fan.dtsi | 17 ++\n .../boot/dts/apple/hwmon-laptop.dtsi | 33 ++++\n .../boot/dts/apple/hwmon-mac-mini.dtsi | 15 ++\n .../arm64/boot/dts/apple/t6001-j375c.dts | 2 +\n arch/arm64/boot/dts/apple/t6001.dtsi | 2 +\n .../arm64/boot/dts/apple/t6002-j375d.dts | 2 +\n .../arm64/boot/dts/apple/t600x-die0.dtsi | 10 ++\n .../boot/dts/apple/t600x-j314-j316.dtsi | 3 +\n .../arm64/boot/dts/apple/t602x-die0.dtsi | 10 ++\n arch/arm64/boot/dts/apple/t8103-j274.dts | 2 +\n arch/arm64/boot/dts/apple/t8103-j293.dts | 3 +\n arch/arm64/boot/dts/apple/t8103-j313.dts | 2 +\n arch/arm64/boot/dts/apple/t8103-j456.dts | 2 +\n arch/arm64/boot/dts/apple/t8103-j457.dts | 2 +\n arch/arm64/boot/dts/apple/t8103.dtsi | 11 ++\n arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +\n arch/arm64/boot/dts/apple/t8112-j473.dts | 2 +\n arch/arm64/boot/dts/apple/t8112-j493.dts | 3 +\n arch/arm64/boot/dts/apple/t8112.dtsi | 11 ++\n drivers/input/misc/Kconfig | 11 ++\n drivers/input/misc/Makefile | 1 +\n drivers/input/misc/macsmc-input.c | 207 +++++++++++++++++++++++++\n drivers/mfd/macsmc.c | 3 +\n 28 files changed, 535 insertions(+)\n---\nbase-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8\nchange-id: 20250816-macsmc-subdevs-87032c017d0c\n\nBest regards," }