Cover Letter Detail
Show a cover letter.
GET /api/covers/2074538/?format=api
{ "id": 2074538, "url": "http://patchwork.ozlabs.org/api/covers/2074538/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/cover/20250418-binman-pubkey-dir-v2-0-b6b90a765ffe@cherry.de/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20250418-binman-pubkey-dir-v2-0-b6b90a765ffe@cherry.de>", "list_archive_url": null, "date": "2025-04-18T11:26:06", "name": "[v2,0/2] binman: properly error out if path provided to key-name-hint in signature nodes", "submitter": { "id": 84425, "url": "http://patchwork.ozlabs.org/api/people/84425/?format=api", "name": "Quentin Schulz", "email": "foss+uboot@0leil.net" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/cover/20250418-binman-pubkey-dir-v2-0-b6b90a765ffe@cherry.de/mbox/", "series": [ { "id": 453380, "url": "http://patchwork.ozlabs.org/api/series/453380/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=453380", "date": "2025-04-18T11:26:06", "name": "binman: properly error out if path provided to key-name-hint in signature nodes", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/453380/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/covers/2074538/comments/", "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=0leil.net", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=0leil.net", "phobos.denx.de;\n spf=pass smtp.mailfrom=foss+uboot@0leil.net" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ZfCBT33njz1yJW\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 18 Apr 2025 21:26:09 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7F62182E38;\n\tFri, 18 Apr 2025 13:26:25 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4170982EBE; Fri, 18 Apr 2025 13:26:24 +0200 (CEST)", "from smtp-bc0d.mail.infomaniak.ch (smtp-bc0d.mail.infomaniak.ch\n [45.157.188.13])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D9E2F82C15\n for <u-boot@lists.denx.de>; Fri, 18 Apr 2025 13:26:21 +0200 (CEST)", "from smtp-4-0001.mail.infomaniak.ch (unknown\n [IPv6:2001:1600:7:10:40ca:feff:fe05:1])\n by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4ZfCBj3kn5zmBQ;\n Fri, 18 Apr 2025 13:26:21 +0200 (CEST)", "from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA\n id 4ZfCBh1N6JzQKH; Fri, 18 Apr 2025 13:26:20 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "From": "Quentin Schulz <foss+uboot@0leil.net>", "Subject": "[PATCH v2 0/2] binman: properly error out if path provided to\n key-name-hint in signature nodes", "Date": "Fri, 18 Apr 2025 13:26:06 +0200", "Message-Id": "<20250418-binman-pubkey-dir-v2-0-b6b90a765ffe@cherry.de>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-B4-Tracking": "v=1; b=H4sIAM42AmgC/22NQQ6CMBBFr0Jm7Zi2KVBceQ/DgtJRJsZCpkokh\n LtbSdy5fC/576+QSJgSnIoVhGZOPMYM5lBAP3TxRsghMxhlSmW1Rs/x0UWcXv5OCwYWtM47V3l\n dl00DeTcJXfm9Ny9t5oHTc5Rlv5j11/5q9k9t1qhQ1c6G0nZ9ZfS5H0hkOQaCdtu2D/d5+BmyA\n AAA", "X-Change-ID": "20250411-binman-pubkey-dir-48b886b17599", "To": "Simon Glass <sjg@chromium.org>,\n Alper Nebi Yasak <alpernebiyasak@gmail.com>, Tom Rini <trini@konsulko.com>,\n Alexander Kochetkov <al.kochet@gmail.com>,\n Lukas Funke <lukas.funke@weidmueller.com>", "Cc": "u-boot@lists.denx.de, Quentin Schulz <quentin.schulz@cherry.de>", "X-Mailer": "b4 0.14.2", "X-Infomaniak-Routing": "alpha", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "I misunderstood the documentation and put the signing key in a keys/\ndirectory while setting key-name-hint property in the signature node and\nu-boot-spl-pubkey-dtb to a path.\n\nmkimage doesn't fail if it cannot find the public key when signing a\nFIT but returns something on stderr to notify the user it couldn't find\nthe key. The issue is that bintool currently discards stderr if the\ncommand successfully returns, so the FIT is not signed AND the user\nisn't made aware of it unless the image is manually inspected.\n\nmkimage does fail when trying to insert a public key in a DTB if it\nisn't found but we can have a better error message.\n\nSigned-off-by: Quentin Schulz <quentin.schulz@cherry.de>\n---\nChanges in v2:\n- added tests,\n- fixed typo in docstring,\n- synced both error messages,\n- Link to v1: https://lore.kernel.org/r/20250414-binman-pubkey-dir-v1-0-0784d54ac621@cherry.de\n\n---\nQuentin Schulz (2):\n binman: etype: fit: raise ValueError if key-name-hint is a path\n binman: etype: u_boot_spl_pubkey_dtb: provide more explicit error for key-name-hint with path\n\n tools/binman/etype/fit.py | 3 +\n tools/binman/etype/u_boot_spl_pubkey_dtb.py | 2 +\n tools/binman/ftest.py | 25 ++++++\n .../test/347_key_name_hint_dir_fit_signature.dts | 98 ++++++++++++++++++++++\n .../test/348_key_name_hint_dir_spl_pubkey_dtb.dts | 16 ++++\n 5 files changed, 144 insertions(+)\n---\nbase-commit: cb7555e93075114fe4af0adb806877ac4d4ef80d\nchange-id: 20250411-binman-pubkey-dir-48b886b17599\n\nBest regards," }